Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Has bzip2 ever been both available and unusable? #14849

Closed
SnarkBoojum mannequin opened this issue Jul 3, 2013 · 7 comments
Closed

Has bzip2 ever been both available and unusable? #14849

SnarkBoojum mannequin opened this issue Jul 3, 2013 · 7 comments

Comments

@SnarkBoojum
Copy link
Mannequin

SnarkBoojum mannequin commented Jul 3, 2013

I'm surprised the bzip2 spkg-install doesn't start by checking if bzip2 is in the path... and just bail out if so: why build it anyway? As asked in the summary: was there ever a case where the system bzip2 wasn't suitable for sage?

Component: build

Reviewer: Jeroen Demeyer

Issue created by migration from https://trac.sagemath.org/ticket/14849

@SnarkBoojum SnarkBoojum mannequin added this to the sage-5.11 milestone Jul 3, 2013
@SnarkBoojum SnarkBoojum mannequin added c: build labels Jul 3, 2013
@nexttime
Copy link
Mannequin

nexttime mannequin commented Jul 3, 2013

Replying to @SnarkBoojum:

Was there ever a case where the system bzip2 wasn't suitable for sage?

I strongly doubt that... ;-)

As with many other spkgs, Sage simply doesn't bother to use a system-wide version.

Ceterum censeo Sage should (ship and) use xz. (And make bzip2 a prerequisite + an optional spkg.)

Btw., zlib and similar are (redundantly) included in many upstream packages...

@kiwifb
Copy link
Member

kiwifb commented Jul 7, 2013

comment:2

System bzip2 has probably always be suitable... provided that all the interesting bits are installed. I am guessing headers may be required and I am willing to bet that the library may not always installed by default (and that may have been more frequent in the past).

@SnarkBoojum
Copy link
Mannequin Author

SnarkBoojum mannequin commented Jul 8, 2013

comment:3
  1. Do we really need the headers? [for python perhaps?]
  2. If bzip2 is here, doesn't that mean libbzip2 is here too?

@kiwifb
Copy link
Member

kiwifb commented Jul 8, 2013

comment:4

I cannot talk about bzip2 in particular but I take care of some SLES servers in a professional capacity. I have seen libraries shipped as part of the dev package rather than the main package. The main executable shipped can very well be statically linked for speed.

@jdemeyer
Copy link

jdemeyer commented Aug 5, 2013

comment:5

Replying to @SnarkBoojum:

  1. Do we really need the headers? [for python perhaps?]

I know for sure that Python checks for and links against the bzip2 library. And I guess that the non-Darwin implementation of sage --pkg uses this.

@jdemeyer jdemeyer modified the milestones: sage-5.11, sage-5.12 Aug 13, 2013
@jdemeyer
Copy link

comment:7

Can this be closed as "wontfix"?

@jdemeyer
Copy link

Reviewer: Jeroen Demeyer

@jdemeyer jdemeyer removed this from the sage-6.1 milestone Dec 24, 2013
@vbraun vbraun closed this as completed Dec 25, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants