Implement Similarity Class Types

[amritanshu-prasad]

Implement similarity class types for square matrices with entries in a finite field.

---

Apply: attachment: trac_14907-similarity_classes-ap.patch

Depends on #10630

CC: @sagetrac-sage-combinat @tscrim

Component: combinatorics

Keywords: similarity class type finite field

Author: Amritanshu Prasad

Reviewer: Travis Scrimshaw

Merged: sage-5.12.beta2

Issue created by migration from https://trac.sagemath.org/ticket/14907

[tscrim]

comment:2

Looks good to me. Thanks.

[tscrim]

Changed reviewer from tscrim to Travis Scrimshaw

[zabrocki]

comment:3

Does this patch have a dependency on #10630 and maybe something else? Something is wrong because I get errors.
One of the tests from sage.combinat.matrix_type import primitives I get the error:
ImportError: No module named matrix_type

I don't even know where to look for these. Can someone point me to the right patches and maybe how to even look this up myself?

[tscrim]

Attachment: trac_14907-review-ts.patch.gz

[tscrim]

comment:4

I was working with Armi on this patch and we forgot to run sync-build after changing the name of the file (hence this was still there as a compiled file). Here's the small review patch which fixes this.

[zabrocki]

Dependencies: #10630

[zabrocki]

comment:5

And the dependency? I am right about this, right?

[tscrim]

comment:6

I don't think so...but it's better safe than sorry.

[amritanshu-prasad]

comment:8

I will be adding some new methods and functions which get used frequently with these classes.

[amritanshu-prasad]

comment:9

Attachment: trac_14907-similarity_classes-ap.patch.gz

I think I am done with it for now.

[tscrim]

comment:10

Looks good to me. Thanks.

[jdemeyer]

comment:11

Please clarify which patches should be applied.

[tscrim]

comment:12

Forgot to add that. Sorry.

For patchbot:

Apply: trac_14907-similarity_classes-ap.patch

[jdemeyer]

Merged: sage-5.12.beta2