Update to MPIR 2.7.0-alpha12

[jpflori]

MPIR 2.6.0 does not build on Cygwin 64.
The next version should fix this problem (and others).
Patches from Sage will mostly be integrated.

upstream at: http://mpir.org/mpir-2.7.0-alpha12.tar.bz2

Upstream: Fixed upstream, but not in a stable release.

CC: @kcrisman @dimpase @tscrim @williamstein

Component: packages: standard

Keywords: mpir spkg cygwin

Author: Jean-Pierre Flori, Jeroen Demeyer

Branch/Commit: d97c066

Reviewer: Jean-Pierre Flori

Issue created by migration from https://trac.sagemath.org/ticket/15015

[jpflori]

comment:1

This should surely be renamed to "Update to MPIR 2.6.1" when the official version get released (no idea when...).

[jpflori]

Author: Jean-Pierre Flori

[jdemeyer]

Dependencies: MPIR 2.6.1 upstream

[tscrim]

comment:4

For the record, the current spkg built for me on cygwin64.

[jpflori]

comment:5

On top of that the current MPIR 2.6.0 fails to properly build on Cygwin when CXX support is not enabled.
Therefore it is not possible/easy to build GCC on Cygwin.
That is because of a dirty hack in the autotools stuff already present in GMP before MPIR was forked.
This is also fixed in the current git version.

[nexttime]

comment:6

Otherwise we'd probably have to close it as won't fix. :-)

Current upstream tarball: http://mpir.org/mpir-2.7.0-alpha4.tar.bz2

Still needs to be tested on Darwin PowerPC I think. (moufang? Does it still live?)

And probably also Macs with more recent versions of Xcode.

[kcrisman]

comment:7

So are you saying that JP should make a tarball for this as an alpha? I don't have time to test this on PPC until that exists. Currently trying to built 6.2.beta7, I'll wait until I get a clean build for that platform before I try new things. (Hopefully rpy is the only remaining problem there.)

[nexttime]

comment:8

Replying to @kcrisman:

So are you saying that JP should make a tarball for this as an alpha?

I think that would be convenient for testing, and there are still some issues on Cygwin* JP knows about.

By the way, note that the latest changes in the alpha4 tarball aren't yet committed on github (it's still at alpha3).

[jpflori]

comment:9

Replying to @kcrisman:

So are you saying that JP should make a tarball for this as an alpha? I don't have time to test this on PPC until that exists. Currently trying to built 6.2.beta7, I'll wait until I get a clean build for that platform before I try new things. (Hopefully rpy is the only remaining problem there.)

I happens I did and almost have an almost completely working out of the box cygwin64 branch.
I just have to cherry-pick commits and push them to different branches on trac.

[jpflori]

comment:10

There are still issues with PPL...
See https://groups.google.com/forum/?fromgroups=#!topic/mpir-devel/JFDaMAc0YpY

---

New commits:

a564118	Update MPIR to 2.7.0.alpha4
5d7a2e9	Remove unnecessary fix for MPIR.

[jpflori]

Changed dependencies from MPIR 2.6.1 upstream to none

[jpflori]

Commit: 5d7a2e9

[jpflori]

Branch: u/jpflori/ticket/15015

[nexttime]

comment:11

A few comments/questions:

• Do we lose the Clang / XCode 5 patch? (I did have other clang patches elsewhere, also just preventing configure to fail for no real reason.)

• Sun compiler patch (probably less important)?

• What is patch ... || continue supposed to achieve? (The if [ $? -ne 0 ] afterwards gets useless.)

• In if uname -a | grep x86_64; then ... any output (stdout and stderr) should get redirected to /dev/null.

Should #16149 be added as a dependency of this ticket, or do you want to deal with that in MPIR's spkg-install? (I'd prefer the former, but am also undecided about the solution to choose on #16149, hence "needs info".)

[nexttime]

comment:12

I recall we also had issues with AVX-enabled CPUs on Darwin and (not that) old Apple assemblers not supporting AVX instructions. IIRC Jeroen removed a work-around (with a bunch of other things dealing with proper CFLAGS) from spkg-install a while ago, so this is presumably no longer an issue (just because we meanwhile require some more recent version of Xcode I guess), but I might be wrong.

[jpflori]

comment:13

Replying to @nexttime:

A few comments/questions:

All (Most?) should be upstream now if I did not screw up a long time ago.

• Do we lose the Clang / XCode 5 patch? (I did have other clang patches elsewhere, also just preventing configure to fail for no real reason.)

Must admit I don't remember about that one.

• Sun compiler patch (probably less important)?

This one is in (IIRC).

• What is patch ... || continue supposed to achieve? (The if [ $? -ne 0 ] afterwards gets useless.)

When there is no patch at all I guess.
Not sure naymore.

• In if uname -a | grep x86_64; then ... any output (stdout and stderr) should get redirected to /dev/null.

Maybe!

Should #16149 be added as a dependency of this ticket, or do you want to deal with that in MPIR's spkg-install? (I'd prefer the former, but am also undecided about the solution to choose on #16149, hence "needs info".)

The CXXFLAGS issue should be fixed in MPIR (maybe not alpha4, but in git master).

[jpflori]

comment:14

Replying to @nexttime:

I recall we also had issues with AVX-enabled CPUs on Darwin and (not that) old Apple assemblers not supporting AVX instructions. IIRC Jeroen removed a work-around (with a bunch of other things dealing with proper CFLAGS) from spkg-install a while ago, so this is presumably no longer an issue (just because we meanwhile require some more recent version of Xcode I guess), but I might be wrong.

I don't now.
We surely added thing for apple ocmpiler/assembler/linker but couldn't promise it was AVX related.

[nexttime]

comment:15

Replying to @jpflori:

Replying to @nexttime:

Should #16149 be added as a dependency of this ticket, or do you want to deal with that in MPIR's spkg-install? (I'd prefer the former, but am also undecided about the solution to choose on #16149, hence "needs info".)

The CXXFLAGS issue should be fixed in MPIR (maybe not alpha4, but in git master).

No, a slightly different one (but with the same effect). AC_PROG_CXX in MPIR is now correctly called after CXXFLAGS have been saved, and MPIR now behaves correctly (I'd say). But Sage sets (and exports) CXXFLAGS to the empty string, so MPIR doesn't touch them (again assuming they were intentionally set), such that we end up with missing flags (unless the user had really set them, or CFLAGS, to something meaningful).

[jpflori]

comment:48

I don't really agree...
If we keep on like that Sage will grow huge.
Hard disks are cheap but internet connections aren't always, e.g. I get a poor bandwith between my office and boxen.
Let's discuss this on sage-devel.

[jpflori]

comment:49

https://groups.google.com/forum/#!topic/sage-devel/a9yIdaqNHKU

[jpflori]

comment:50

The gcdext change in MPIR was to be expected (at least the gcdext(1,1) example Jeroen found) and I personally don't think it's a bug.
I'm not sure what Bill will think though.

At the very least it makes MPIR consistent with GMP.

[jpflori]

comment:51

(And ok for not shipping any spkg-src script.)

[jpflori]

comment:53

The only thing really annoying me right now is the name of the tarball.
When we update to another alpha or the final version it will be a pain, so we should still repackage the upstream tarball to change the dir name wihtin it (rather than renaming the tarball).

[jpflori]

Work Issues: fix tarball name issue

[jdemeyer]

Changed work issues from fix tarball name issue to none

[sagetrac-git]

Changed commit from 8c7fbbd to aefe0eb

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

aefe0eb

Upgrade to MPIR 2.7.0-alpha12

[jdemeyer]

New commits:

aefe0eb

Upgrade to MPIR 2.7.0-alpha12

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

3d583af	Merge remote-tracking branch 'origin/develop' into ticket/15015
d97c066	Rename source directory

[sagetrac-git]

Changed commit from aefe0eb to d97c066

[jpflori]

comment:60

Looks fine.

I had a vague souvenir we had trouble with dashes in version numbers but it does not seem to be the case anymore.
Maybe we could also switch back to verbatim version numbers for Singular 4-0-1.

[jpflori]

comment:61

Got two files with failing doctests but cannot reproduce these failures:

• src/sage/modular/modform/ambient.py
• src/sage/graphs/genus.pyx

[vbraun]

Changed branch from u/jdemeyer/ticket/15015 to d97c066