New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Branching rule A2->A1 never returns #15023
Comments
comment:1
This works:
But it remains a problem that the code is not very forgiving if you forget to specify a branching rule. There are two possible approaches to fixing this. The first would be to raise a ValueError if the branching rule is omitted. The second would be to try to guess the branching rule by consulting a table. The first way would be easy to implement and I can submit a patch for it. |
comment:2
Though generally the If you really don't want to have a default then |
comment:3
I agree and I am thinking the default branching rule should be to do the obvious thing
That might be enough for an initial implementation. I thought of adding These are the default rules implemented by the patch. If a default rule is not found, an error is raised. |
Attachment: trac_15023_branch.patch.gz #15023: implements correct default branching rules |
Author: bump |
Changed keywords from none to "branching rule" |
This comment has been minimized.
This comment has been minimized.
Reviewer: Travis Scrimshaw |
Changed author from bump to Dan Bump |
comment:8
Hey Dan, Here's a review patch which removes the bare |
comment:9
Thanks Travis. The reviewer patch looks good. I'll wait until tomorrow or so to set pos review since Volker Braun might have some comment. |
comment:10
Looks good to me, thanks! |
comment:11
Your welcome. Thanks. |
comment:12
Attachment: trac_15023-review-ts.patch.gz I had to do a minor tweak to catch an A1 issue (change an |
Merged: sage-5.12.beta3 |
Changed author from Dan Bump to Daniel Bump |
The following goes into an infinite loop and never returns:
Apply:
CC: @sagetrac-sage-combinat @dwbump
Component: combinatorics
Keywords: "branching rule"
Author: Daniel Bump
Reviewer: Travis Scrimshaw
Merged: sage-5.12.beta3
Issue created by migration from https://trac.sagemath.org/ticket/15023
The text was updated successfully, but these errors were encountered: