-
-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests in the category of euclidean domains #15191
Comments
Branch: u/saraedum/ticket/15191 |
Author: Julian Rueth |
Commit: |
Branch pushed to git repo; I updated commit sha1. New commits:
|
Changed branch from u/saraedum/ticket/15191 to u/pbruin/15191-EuclideanDomains_tests |
comment:7
resolved merge conflicts |
Work Issues: fix doctest failures |
comment:8
After resolving the conflicts there are various doctest failures:
Some of these are due to the testsuite running
|
Changed keywords from none to sd59 |
Changed branch from u/pbruin/15191-EuclideanDomains_tests to u/saraedum/ticket/15191 |
Branch pushed to git repo; I updated commit sha1. New commits:
|
Changed work issues from fix doctest failures to none |
comment:14
Like many inexact rings, the p-adics have zerodivisors. Not in theory of course, but in practice (i.e. the p-adics are an integral domain but typically implemented with finite precision which leads to zero-divisors). That's why I put the continue there if a or a*b are zero. I had put a remark in the commit message but not in the code (which was probably not very smart). The check you put there is valid for exact rings however. As you say it should probably not be in the category of euclidean domains. Would you mind moving this to a different ticket? |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:16
Okay, I'v reverted the change and created #16596 for the zero divisors tests (I'll post a branch there shortly). |
Branch pushed to git repo; I updated commit sha1. New commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:21
Thanks for your review patches. What is the status of this ticket now? Do you want a review of your latest changes? |
comment:22
Yes please (and Frédéric's too). If you're happy with the changes, then I believe it's a positive review. (Also I'd appreciate a review of #16596 too.) |
Changed reviewer from Peter Bruin, Travis Scrimshaw to Peter Bruin, Travis Scrimshaw, Frédéric Chapoton |
Changed branch from public/ticket/euclidean_domains_tests-15191 to |
Currently, there are no generic tests in the category of euclidean domain which test the correctness of the quotient with remainder.
Depends on #14482
Depends on #15192
Component: categories
Keywords: sd59
Author: Julian Rueth
Branch/Commit:
6261466
Reviewer: Peter Bruin, Travis Scrimshaw, Frédéric Chapoton
Issue created by migration from https://trac.sagemath.org/ticket/15191
The text was updated successfully, but these errors were encountered: