create the new development scripts/library

[ohanar]

In order to switch to the new workflow, we need to create a set of development scripts for interfacing against git and trac. We use https://github.com/sagemath/sage-workflow/issues to keep track of issues.

Depends on #14480
Depends on #14557
Depends on #15222

CC: @koffie @robertwb @roed314 @jdemeyer @kini @saraedum @nexttime @simon-king-jena

Component: misc

Keywords: sd51

Author: Robert Bradshaw, David Roe, Julian Rueth, R. Andrew Ohana, Martin Raum, Timo Kluck

Branch/Commit: u/vbraun/dev_scripts @ 946b5b4

Reviewer: Volker Braun

Issue created by migration from https://trac.sagemath.org/ticket/14482

[ohanar]

Changed author from Robert Bradshaw, David Roe, Julian Rueth to Robert Bradshaw, David Roe, Julian Rueth, R. Andrew Ohana

[ohanar]

Changed dependencies from #13015 to #13015, #14557

[ohanar]

Branch: u/ohanar/dev_scripts

[ohanar]

Changed dependencies from #13015, #14557 to #13015, #14557, #14480

[saraedum]

Changed branch from u/ohanar/dev_scripts to u/saraedum/ticket/14482

[saraedum]

Changed dependencies from #13015, #14557, #14480 to {}

[saraedum]

Changed dependencies from {} to #13015, #14557, #14480

[tkluck]

Changed dependencies from #13015, #14557, #14480 to none

[tkluck]

Changed branch from u/saraedum/ticket/14482 to u/tkluck/ticket/14482

[tkluck]

Dependencies: #13015, #14557, #14480

[tkluck]

comment:10

The dependencies got lost through the ./sage --dev upload script. I'm putting them back.

[tkluck]

Changed keywords from none to sd51

[saraedum]

Changed branch from u/tkluck/ticket/14482 to u/saraedum/ticket/14482

[tkluck]

comment:13

Remove circular dependency.

[tkluck]

Changed dependencies from #13015, #14557, #14480 to #14557, #14480

[sagetrac-mraum]

Changed branch from u/saraedum/ticket/14482 to u/mraum/ticket/14482

[saraedum]

Changed branch from u/mraum/ticket/14482 to u/saraedum/ticket/14482

[saraedum]

Changed dependencies from #14557, #14480 to #13015, #14557, #14480

[tkluck]

Changed branch from u/saraedum/ticket/14482 to public/sage-git/ticket/14482

[sagetrac-mraum]

Changed branch from public/sage-git/ticket/14482 to u/mraum/ticket/14482

[sagetrac-mraum]

Changed dependencies from #13015, #14557, #14480 to #13015, #14480, #14557

[sagetrac-mraum]

Changed author from Robert Bradshaw, David Roe, Julian Rueth, R. Andrew Ohana to Robert Bradshaw, David Roe, Julian Rueth, R. Andrew Ohana, Martin Raum

[sagetrac-mraum]

Changed author from Robert Bradshaw, David Roe, Julian Rueth, R. Andrew Ohana, Martin Raum to Robert Bradshaw, David Roe, Julian Rueth, R. Andrew Ohana, Martin Raum, Timo Kluck

[sagetrac-mraum]

Changed branch from u/mraum/ticket/14482 to public/sage-git/ticket/14482

[saraedum]

Changed branch from public/sage-git/ticket/14482 to u/saraedum/ticket/14482

[saraedum]

comment:22

We can now add comments.

[vbraun]

comment:156

I agree with everything that I haven't written myself here... Andrew, is there anything left that we need to fix?

[ohanar]

comment:157

Not that I know of.

[vbraun]

comment:158

I get doctest failures on fresh accounts (cached stuff in DOT_SAGE?) of the type

File "src/sage/dev/git_interface.py", line 118, in sage.dev.git_interface.GitProxy._run_git
Failed example:
    dev.git.status()
Expected:
    Traceback (most recent call last):
    ...
    AssertionError: working with the sage repository in a doctest
Got:
    <BLANKLINE>
    Traceback (most recent call last):
      File "/home/buildslave/slave/local_full/build/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 480, in _run
        self.execute(example, compiled, test.globs)
      File "/home/buildslave/slave/local_full/build/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 839, in execute
        exec compiled in globs
      File "<doctest sage.dev.git_interface.GitProxy._run_git[7]>", line 1, in <module>
        dev.git.status()
      File "lazy_import.pyx", line 312, in sage.misc.lazy_import.LazyImport.__getattr__ (sage/misc/lazy_import.c:2402)
      File "lazy_import.pyx", line 248, in sage.misc.lazy_import.LazyImport._get_object (sage/misc/lazy_import.c:1885)
      File "/home/buildslave/slave/local_full/build/local/lib/python2.7/site-packages/sage/dev/sagedev_wrapper.py", line 250, in <module>
        dev = SageDevWrapper(SageDev())
      File "/home/buildslave/slave/local_full/build/local/lib/python2.7/site-packages/sage/dev/sagedev.py", line 119, in __init__
        self.trac = TracInterface(self.config['trac'], self._UI)
      File "/home/buildslave/slave/local_full/build/local/lib/python2.7/site-packages/sage/dev/trac_interface.py", line 212, in __init__
        self.__ticket_cache = SavingDict(ticket_cache_file)
      File "/home/buildslave/slave/local_full/build/local/lib/python2.7/site-packages/sage/dev/saving_dict.py", line 116, in __init__
        self._write()
      File "/home/buildslave/slave/local_full/build/local/lib/python2.7/site-packages/sage/dev/saving_dict.py", line 236, in _write
        assert os.path.abspath(self._filename).startswith(SAGE_TMP), error
    AssertionError: write attempt to a saving_dict in a doctest

Doesn't happen in my own user account. Anybody knows whats up?

[vbraun]

comment:159

On skynet/mark (Sparc Solaris, Sun_SSH_1.1) you must specify the key type in ssh-keygen:

-bash-3.00$ ssh-keygen -q -f /tmp/foo -P ''
You must specify a key type (-t).
Usage: ssh-keygen [options]
Options:
  -b bits     Number of bits in the key to create.
  -c          Change comment in private and public key files.
  -e          Convert OpenSSH to IETF SECSH key file.
  -f filename Filename of the key file.
  -i          Convert IETF SECSH to OpenSSH key file.
  -l          Show fingerprint of key file.
  -p          Change passphrase of private key file.
  -q          Quiet.
  -y          Read private key file and print public key.
  -t type     Specify type of key to create.
  -B          Show bubblebabble digest of key file.
  -C comment  Provide new comment.
  -N phrase   Provide new passphrase.
  -P phrase   Provide old passphrase.

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

[6a512d6](https://github.com/sagemath/sagetrac-mirror/commit/6a512d6)

Explicitly specify the key type in ssh-keygen (requried for Sun SSH)

[sagetrac-git]

Changed commit from 702d7af to 6a512d6

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

[2941308](https://github.com/sagemath/sagetrac-mirror/commit/2941308)

Use a DoctestSageDevWrapper for the global dev object during doctests

[sagetrac-git]

Changed commit from 6a512d6 to 2941308

[sagetrac-git]

Changed commit from 2941308 to 946b5b4

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

[946b5b4](https://github.com/sagemath/sagetrac-mirror/commit/946b5b4)

fix the commandline sage -dev script

[tscrim]

comment:163

I am having trouble importing Hg patches. I added an issue to the Github page with the details.

EDIT - Also I don't like that when aborting patch imports that it deletes all untracked directories (in particular, documentation output). I'd prefer if we could only delete newly created directories.

Thanks for all your work on this.

[vbraun]

comment:164

Which github page? In any case, our bug tracker is not on github.

I'm sure there are a lot of small things that could be improved, but improvement requests should go into a separate ticket by now. Unless you think that the deleting of documentation output merits delaying the git transition.

[tscrim]

comment:165

Replying to @vbraun:

Which github page? In any case, our bug tracker is not on github.

The issues forum in the ticket description: ​https://github.com/sagemath/sage-workflow/issues

I'm sure there are a lot of small things that could be improved, but improvement requests should go into a separate ticket by now. Unless you think that the deleting of documentation output merits delaying the git transition.

It's not worth the delay. It's an annoyance IMO, but not horribly so.