Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow using Sage without dev/git #15465

Closed
vbraun opened this issue Nov 28, 2013 · 11 comments
Closed

Allow using Sage without dev/git #15465

vbraun opened this issue Nov 28, 2013 · 11 comments

Comments

@vbraun
Copy link
Member

vbraun commented Nov 28, 2013

For binary builds / system-wide installs and perhaps tarballs we should not require the git repository. This ticket fixes two doctests for that use case.

That is, to remove the development functionality you can now

  • delete SAGE_SRC/sage/dev
  • delete SAGE_ROOT/.git
    and all doctests still pass

Depends on #14482

Component: misc

Author: Volker Braun

Branch/Commit: u/vbraun/run_without_git @ 24e5a73

Reviewer: R. Andrew Ohana

Issue created by migration from https://trac.sagemath.org/ticket/15465

@vbraun vbraun added this to the sage-5.13 milestone Nov 28, 2013
@vbraun
Copy link
Member Author

vbraun commented Nov 28, 2013

Branch: u/vbraun/run_without_git

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 28, 2013

Branch pushed to git repo; I updated commit sha1. New commits:

[067dfc6](https://github.com/sagemath/sagetrac-mirror/commit/067dfc6)Relax the cmdline test of "sage -dev", it may be disabled
[fa29095](https://github.com/sagemath/sagetrac-mirror/commit/fa29095)Merging latest dev scripts to avoid conflict in sage-dev
[713737f](https://github.com/sagemath/sagetrac-mirror/commit/713737f)fall back to doctesting all files if new files cannot be identified
[946b5b4](https://github.com/sagemath/sagetrac-mirror/commit/946b5b4)fix the commandline sage -dev script
[2941308](https://github.com/sagemath/sagetrac-mirror/commit/2941308)Use a DoctestSageDevWrapper for the global dev object during doctests
[6a512d6](https://github.com/sagemath/sagetrac-mirror/commit/6a512d6)Explicitly specify the key type in ssh-keygen (requried for Sun SSH)
[702d7af](https://github.com/sagemath/sagetrac-mirror/commit/702d7af)do not suggest force push

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 28, 2013

Commit: 067dfc6

@vbraun
Copy link
Member Author

vbraun commented Nov 28, 2013

Dependencies: #14482

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 29, 2013

Branch pushed to git repo; I updated commit sha1. New commits:

[24e5a73](https://github.com/sagemath/sagetrac-mirror/commit/24e5a73)better to ask for forgiveness

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 29, 2013

Changed commit from 067dfc6 to 24e5a73

@ohanar
Copy link
Member

ohanar commented Dec 1, 2013

comment:5

Because of the lazy import of the dev object, asking for forgiveness won't work.

@ohanar
Copy link
Member

ohanar commented Dec 1, 2013

Reviewer: R. Andrew Ohana

@ohanar ohanar modified the milestones: sage-5.13, sage-6.0 Dec 1, 2013
@vbraun
Copy link
Member Author

vbraun commented Dec 1, 2013

comment:8

The idea is to delete the src/sage/dev directory if development is not possible (e.g. because of file permissions). Just not importing dev is not a solution as the dev doctests are still around (and will all fail).

@vbraun

This comment has been minimized.

@vbraun vbraun changed the title Allow using Sage without git repository Allow using Sage without dev/git Dec 1, 2013
@ohanar
Copy link
Member

ohanar commented Dec 6, 2013

comment:10

ok, in that case, this seems fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants