Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to latest upstream git #15468

Closed
vbraun opened this issue Nov 29, 2013 · 14 comments
Closed

update to latest upstream git #15468

vbraun opened this issue Nov 29, 2013 · 14 comments

Comments

@vbraun
Copy link
Member

vbraun commented Nov 29, 2013

The git self-tests fail on OSX 10.8, 10.9 because of braindamage in Apple's regex library. This is worked around in upstream git, so just update to the latest and greatest:

*** t0070-fundamental.sh ***
ok 1 - character classes (isspace, isalpha etc.)
ok 2 - mktemp to nonexistent directory prints filename
ok 3 - mktemp to unwritable directory prints filename
not ok - 4 check for a bug in the regex routines
#	
#		# if this test fails, re-build git with NO_REGEX=1
#		test-regex
#	
# failed 1 among 4 test(s)
1..4
make[5]: *** [t0070-fundamental.sh] Error 1
make[4]: *** [test] Error 2
make[3]: *** [test] Error 2
Error running git's combined build/test suite.

Upstream tarball: https://www.kernel.org/pub/software/scm/git/git-1.8.4.4.tar.bz2

Depends on #14482

CC: @haraldschilly

Component: packages: standard

Author: Volker Braun

Branch/Commit: u/vbraun/git_1_8_4_4 @ f6fcc98

Reviewer: R. Andrew Ohana

Issue created by migration from https://trac.sagemath.org/ticket/15468

@vbraun vbraun added this to the sage-5.13 milestone Nov 29, 2013
@vbraun

This comment has been minimized.

@vbraun

This comment has been minimized.

@vbraun
Copy link
Member Author

vbraun commented Nov 29, 2013

Branch: u/vbraun/git_1_8_4_4

@vbraun
Copy link
Member Author

vbraun commented Nov 29, 2013

Commit: f3df294

@vbraun
Copy link
Member Author

vbraun commented Nov 29, 2013

New commits:

[f3df294](https://github.com/sagemath/sagetrac-mirror/commit/f3df294)update git to latest upstream version 1.8.4.4

@vbraun
Copy link
Member Author

vbraun commented Nov 29, 2013

Dependencies: #14482

@vbraun
Copy link
Member Author

vbraun commented Nov 29, 2013

comment:5

The update breaks some sage-dev doctests. Fixing...

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 29, 2013

Changed commit from f3df294 to f6fcc98

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 29, 2013

Branch pushed to git repo; I updated commit sha1. New commits:

[f6fcc98](https://github.com/sagemath/sagetrac-mirror/commit/f6fcc98)fixing git interface doctests for new git version
[4dd4da5](https://github.com/sagemath/sagetrac-mirror/commit/4dd4da5)Merge dev scripts branch since their doctests are changed by the new git
[946b5b4](https://github.com/sagemath/sagetrac-mirror/commit/946b5b4)fix the commandline sage -dev script
[2941308](https://github.com/sagemath/sagetrac-mirror/commit/2941308)Use a DoctestSageDevWrapper for the global dev object during doctests
[6a512d6](https://github.com/sagemath/sagetrac-mirror/commit/6a512d6)Explicitly specify the key type in ssh-keygen (requried for Sun SSH)
[702d7af](https://github.com/sagemath/sagetrac-mirror/commit/702d7af)do not suggest force push

@ohanar
Copy link
Member

ohanar commented Dec 1, 2013

comment:7

Other than being slightly dated (1.8.5 came out a few days ago), this seems fine.

@ohanar
Copy link
Member

ohanar commented Dec 1, 2013

Reviewer: R. Andrew Ohana

@vbraun
Copy link
Member Author

vbraun commented Dec 16, 2013

comment:10

Harald: please mirror tarball...

@haraldschilly
Copy link
Member

comment:11

I'm not sure where to put this: the packages in "standard" are updated for every new release. There are also git packages in "optional" and "experimental" and the new "upstream/git".

I think we can get rid of the ones in optional and experimental and you mean to replace the one in upstream/git ?

@vbraun
Copy link
Member Author

vbraun commented Dec 16, 2013

comment:12

This ticket is not a spkg, just a new-style tarball. Should go into upstream. We should probably keep the old git spkg in "standard" for a while if Sage 5 users need it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants