Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve documentation of projective dynatomic polynomial #15490

Closed
bhutz opened this issue Dec 6, 2013 · 19 comments
Closed

improve documentation of projective dynatomic polynomial #15490

bhutz opened this issue Dec 6, 2013 · 19 comments
Assignees
@sagetrac-w-wu
Labels
c: documentation p: trivial / 5 t: bug
Milestone
sage-6.2

Comments

@bhutz
Copy link

bhutz commented Dec 6, 2013

There are two current issues. There is a typo: n instead of period.

Also, it would be nice to verify that the roots are actually giving preperiodic points of the correct period as a doctest.

Component: documentation

Author: Weixin Wu

Branch/Commit: baf61f1

Reviewer: Ben Hutz

Issue created by migration from https://trac.sagemath.org/ticket/15490
@bhutz bhutz added this to the sage-6.1 milestone Dec 6, 2013
@sagetrac-w-wu
Copy link
Mannequin

sagetrac-w-wu mannequin commented Dec 6, 2013

#15490: improve documentation of projective dynatomic polynomial

@bhutz
Copy link
Author

bhutz commented Dec 7, 2013

comment:1

Attachment: trac#15490.patch.gz

Needs a commit message and a more descriptive patch name.

@sagetrac-w-wu
Copy link
Mannequin

sagetrac-w-wu mannequin commented Dec 8, 2013

Trac 15490: improve documentation of projective dynatomic polynomial

@sagetrac-w-wu
Copy link
Mannequin

sagetrac-w-wu mannequin commented Dec 8, 2013

comment:2

Attachment: trac_15490_dynatomic_poly_documentation.patch.gz

@sagetrac-w-wu sagetrac-w-wu mannequin added the s: needs review label Dec 8, 2013
@bhutz
Copy link
Author

bhutz commented Dec 9, 2013

comment:3

Line 553-556 are duplicated and should be removed.

Line 539, 557 need a space around the =.

Since there are two attachments you should add an 'apply' block to the description.

@bhutz
Copy link
Author

bhutz commented Dec 9, 2013

Reviewer: Ben Hutz

@sagetrac-w-wu
Copy link
Mannequin

sagetrac-w-wu mannequin commented Jan 13, 2014

Trac 15490: improve documentation of projective dynatomic polynomial

@sagetrac-w-wu
Copy link
Mannequin

sagetrac-w-wu mannequin commented Jan 13, 2014

comment:4

Attachment: trac_15490_dynatomic_poly_documentation.2.patch.gz

@bhutz
Copy link
Author

bhutz commented Jan 18, 2014

comment:5

trying to move this to git today...

@bhutz
Copy link
Author

bhutz commented Jan 18, 2014

Branch: u/bhutz/15490

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 18, 2014

Branch pushed to git repo; I updated commit sha1. New commits:

8237337Merging Sage-5.12.rc0 and sage-git fixes
07152d8Merge important bugfix for dev scripts
a1e5ad5Merge branch 'master' of ssh://trac.sagemath.org:2222/sage into trac_master
33bb808projective_product.patch
1cd006cImprove documentation of projective dynatomic polynomial

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 18, 2014

Commit: 1cd006c

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 18, 2014

Changed commit from 1cd006c to baf61f1

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 18, 2014

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

baf61f1Improve documentation of projective dynatomic polynomial

@bhutz
Copy link
Author

bhutz commented Jan 18, 2014

comment:8

ok. I think I got it right the second time. These changes now look fine to me and pass on my system.

@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.1, sage-6.2 Jan 30, 2014
@sagetrac-w-wu
Copy link
Mannequin

sagetrac-w-wu mannequin commented Feb 9, 2014

comment:10

I already checked everything, this ticket works on my system.

@vbraun
Copy link
Member

vbraun commented Feb 23, 2014

comment:11

Please fill in author field

@bhutz
Copy link
Author

bhutz commented Feb 23, 2014

Author: Weixin Wu

@vbraun
Copy link
Member

vbraun commented Mar 3, 2014

Changed branch from u/bhutz/15490 to baf61f1

@vbraun vbraun closed this as completed in b43ae56 Mar 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sagetrac-w-wu sagetrac-w-wu

Labels
c: documentation p: trivial / 5 t: bug
Projects
None yet
Milestone
sage-6.2
Development

No branches or pull requests
2 participants
@vbraun @bhutz