Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Petersen Family #15893

Closed
nathanncohen mannequin opened this issue Mar 5, 2014 · 10 comments
Closed

The Petersen Family #15893

nathanncohen mannequin opened this issue Mar 5, 2014 · 10 comments
Labels
c: graph theory p: major / 3 t: enhancement
Milestone
sage-6.2

Comments

@nathanncohen
Copy link
Mannequin

nathanncohen mannequin commented Mar 5, 2014

Heeeeeeeeeeeere it is !

http://en.wikipedia.org/wiki/Petersen_family

Nathann

CC: @sagetrac-tmonteil

Component: graph theory

Author: Nathann Cohen

Branch/Commit: 5a75528

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/15893
@nathanncohen nathanncohen mannequin added this to the sage-6.2 milestone Mar 5, 2014
@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Mar 5, 2014

Branch: u/ncohen/15893

@nathanncohen nathanncohen mannequin added the s: needs review label Mar 5, 2014
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 5, 2014

Branch pushed to git repo; I updated commit sha1. New commits:

bbec915trac #15893: graphs.petersen_family

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 5, 2014

Commit: bbec915

@fchapoton
Copy link
Contributor

Changed branch from u/ncohen/15893 to u/chapoton/15893

@fchapoton
Copy link
Contributor

Changed commit from bbec915 to 5a75528

@fchapoton
Copy link
Contributor

comment:3

Hello,

here is a review patch.

It looks good to me and you can set to positive review if you want.

One suggestion : maybe Y-Delta and Delta-Y transformations can be useful to have as general methods ? in another ticket ?

New commits:

5a75528trac #15893 review patch

@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Mar 7, 2014

comment:4

Good for me ! Thank you very much :-)

About making those functions public: I only thought they were too specific to be Graph functions... It's not a huge loss even if somebody rewrites them for they are very easy and short, and well... The graph library already contains more useful stuff which is only available in modules, sooooo... :-)

Nathann

@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Mar 7, 2014

comment:5

by the way, can you name your branch public/something when you modify somebody else's branch ? This way if I have things to change later we don't keep changing the branch name and we can work on the same.

Nathann

@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Mar 7, 2014

Reviewer: Frédéric Chapoton

@vbraun
Copy link
Member

vbraun commented Mar 11, 2014

Changed branch from u/chapoton/15893 to 5a75528

@vbraun vbraun closed this as completed in 2ad8c50 Mar 11, 2014
tscrim pushed a commit to tscrim/sage that referenced this issue Jun 1, 2023
Merge branch 'develop' into public/algebras/fp_algebras
48fcf2f 
* develop: (100 commits)
  Updated Sage version to 6.2.beta4
  added documentation, patchlevel bump
  trac sagemath#15894 modif of two warnings
  delete cruft from the guava package
  trac sagemath#15893 review patch
  trac sagemath#15894 another backward change
  trac sagemath#15894 changin back the category names
  trac #15xxx proper names should start by a capital letter
  Fix changelog entry for ell_wp
  trac sagemath#15893: graphs.petersen_family
  Fixes to code from sagemath#9505.
  Fix the banner displayed by sage -h
  trac sagemath#15466: remove dead import
  trac sagemath#15795 line wrap
  trac sagemath#15795 redone with ( ::)
  Fraction to power series: doctests
  Fraction to power series conversion when the fraction coerces into the base ring
  15698: Allow construction of power series from fractions
  Create *unevaluated* integrals when converting sage integrals to sympy
  Use evaluate=False in SympyConverter too
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: graph theory p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-6.2
Development

No branches or pull requests
2 participants
@vbraun @fchapoton