-
-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FiniteStateMachine.__and__ calls intersection and FiniteStateMachine.__or__ calls union. #16016
Comments
Author: Sara Kropf |
comment:2
I believe that | and + should be aliases for union. That's how it works for sets already
And for graphs only + is defined
If you agree with that you can add a Nathann |
comment:4
Well, could you answer yesterday's question ? What do you think ? Nathann |
comment:5
For me, that sounds good. But I would like to wait for possible other opinions on this topic before I change it, since originally it was suggested to use only I will wait until Monday. |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:7
Now |
comment:8
Oooooooooookayyyyyyyyyyyyyyyyyyyyyyyy !!! http://grooveshark.com/s/Let+s+Bang/3S4pl4?src=5 Nathann |
comment:9
OOops, nononono. It does not pass tests
|
comment:10
Replying to @sagetrac-skropf:
I am Ok for But, do we agree that Sébastien |
comment:11
Yepyep, in the current patch we only have an alias from add to or. Nathann |
comment:12
Replying to @nathanncohen:
I don't know what you mean. For me, all doctests pass. Can you check it again, please, and tell me your error messages? |
comment:13
My mistake ! I must have forgotten to recompile or something. Sorry for that, good to go Nathann |
Reviewer: Nathann Cohen |
Changed branch from u/skropf/fsm/and-intersection-or-union to |
Nevertheless, intersection and union are still not implemented. Thus, this only changes the names of the functions. Previously
__mul__
called intersection and__add__
called union.This is an answer to one of the comments in #15078 comment:32.
CC: @dkrenn @cheuberg @seblabbe
Component: combinatorics
Author: Sara Kropf
Branch/Commit:
3c34436
Reviewer: Nathann Cohen
Issue created by migration from https://trac.sagemath.org/ticket/16016
The text was updated successfully, but these errors were encountered: