Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement method _an_element_ for Words #16125

Closed
avirmaux mannequin opened this issue Apr 10, 2014 · 12 comments
Closed

Implement method _an_element_ for Words #16125

avirmaux mannequin opened this issue Apr 10, 2014 · 12 comments
Labels
c: combinatorics p: major / 3 t: bug
Milestone
sage-6.2

Comments

@avirmaux
Copy link
Mannequin

avirmaux mannequin commented Apr 10, 2014 

sage: W = Words(4)
sage: w = W([3,1,2,1])
sage: w in ZZ
NotImplementedError                       Traceback (most recent call last)
[...]
NotImplementedError: please implement _an_element_ for Words over {1, 2, 3, 4}

CC: @seblabbe

Component: combinatorics

Author: Aladin Virmaux

Branch/Commit: 1af525d

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/16125
@avirmaux avirmaux mannequin added this to the sage-6.2 milestone Apr 10, 2014
@avirmaux
Copy link
Mannequin Author

avirmaux mannequin commented Apr 10, 2014

Branch: u/virmaux/16125

@avirmaux
Copy link
Mannequin Author

avirmaux mannequin commented Apr 10, 2014

Commit: b9d0ac1

@avirmaux avirmaux mannequin added the s: needs review label Apr 10, 2014
@fchapoton
Copy link
Contributor

Author: Aladin Virmaux

@fchapoton
Copy link
Contributor

comment:4

looks good to me, positive review.

Aladin, maybe you could add yourself to the list in the front page http://trac.sagemath.org/ ?

@fchapoton
Copy link
Contributor

Reviewer: Frédéric Chapoton

@vbraun
Copy link
Member

vbraun commented Apr 12, 2014

comment:6
sage -t --long src/sage/algebras/shuffle_algebra.py  # 4 doctests failed
sage -t --long src/sage/categories/modules_with_basis.py  # 1 doctest failed

@fchapoton
Copy link
Contributor

Changed branch from u/virmaux/16125 to public/ticket/16125

@fchapoton
Copy link
Contributor

Changed commit from b9d0ac1 to 1af525d

@fchapoton
Copy link
Contributor

comment:7

Please accept my apologies, I should have run the tests.

New commits:

1af525dtrac #16125 corrected doctests

@fchapoton
Copy link
Contributor

comment:8

NOTA BENE: I have not got enough time to run sage -t --all in full. This should work, but has to be checked before a positive review is given.

@avirmaux
Copy link
Mannequin Author

avirmaux mannequin commented Apr 14, 2014

comment:9

Am I allowed to review it ?

@vbraun
Copy link
Member

vbraun commented Apr 14, 2014

Changed branch from public/ticket/16125 to 1af525d

@vbraun vbraun closed this as completed in d1f7862 Apr 14, 2014
tscrim pushed a commit to tscrim/sage that referenced this issue Jun 1, 2023
Merge branch 'develop' into public/algebras/fp_algebras
59b06c3 
* develop: (148 commits)
  Updated Sage version to 6.2.beta8
  Fixed failing doctests.
  clean empty directories
  fix crun doctest
  Solaris does not have -a option for cp. Use -r.
  make our own prompt stripper run before the IPython one
  Add comment about not picking up Win64 as OS on Cygwin64.
  Corrected BasisExchangeMatroid.dependent_r_sets(r) to enumerate all r-sets if r > full rank.
  BasisExchangeMatroid.independent_r_sets() and .dependent_r_sets() now check if input r exceeds the full rank.
  Patch Python uuid module to lower side effects when it is imported.
  Update libpng to version 1.2.51.
  Update sqlite to version 3.8.4.3.
  Trac 15030: replace fast_float with fast_callable in 2D plotting
  some small changes to the documentation
  reviewer patch for sagemath#8198
  trac sagemath#16125 corrected doctests
  trac sagemath#16150 better doc still
  trac sagemath#16150 more doc for the triangulation of the torus
  Fixed last bad link.
  I couldn't count parentheses correctly during merge resolution.
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: combinatorics p: major / 3 t: bug
Projects
None yet
Milestone
sage-6.2
Development

No branches or pull requests
2 participants
@vbraun @fchapoton