magma(P) for multivariate polynomial rings

[malb]

This currently fails, but shouldn't.

sage: P = PolynomialRing(GF(127),10, 'x')
sage: magma(P)

Component: interfaces

Keywords: magma

Author: Martin Albrecht

Branch: 566082b

Reviewer: Volker Braun

Issue created by migration from https://trac.sagemath.org/ticket/16282

[malb]

New commits:

548d2e6	fix magma(P) for P a multivariate polynomial ring
566082b	fix various Magma doctest failures

[malb]

Branch: u/malb/16282-magma-cache

[malb]

Commit: 566082b

[vbraun]

Reviewer: Volker Braun

[nexttime]

comment:5

Haha, I was just going to write "Waiting for unfinished jobs..."

[nexttime]

comment:6

sage -t --long src/sage/rings/integer_ring.pyx
**********************************************************************
File "src/sage/rings/integer_ring.pyx", line 1241, in sage.rings.integer_ring.IntegerRing_class._magma_init_
Failed example:
    magma(ZZ)           # optional - magma
Expected:
    Integer Ring              # indirect doctest
Got:
    Integer Ring
**********************************************************************
1 item had failures:
   1 of   2 in sage.rings.integer_ring.IntegerRing_class._magma_init_
    [187 tests, 1 failure, 3.17 s]

? 8)

[nexttime]

comment:7

sage -t --long src/sage/rings/number_field/number_field.py
**********************************************************************
File "src/sage/rings/number_field/number_field.py", line 4393, in sage.rings.number_field.number_field.NumberField_generic.galois_group
Failed example:
    NumberField(x^3 + 2*x + 1, 'a').galois_group(algorithm='magma')   # optional - magma, , database_gap
Exception raised:
    Traceback (most recent call last):
      File "/Users/leif/Sage/sage-6.2.beta7/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 480, in _run
        self.execute(example, compiled, test.globs)
      File "/Users/leif/Sage/sage-6.2.beta7/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 839, in execute
        exec compiled in globs
      File "<doctest sage.rings.number_field.number_field.NumberField_generic.galois_group[10]>", line 1, in <module>
        NumberField(x**Integer(3) + Integer(2)*x + Integer(1), 'a').galois_group(algorithm='magma')   # optional - magma, , database_gap
      File "cachefunc.pyx", line 1591, in sage.misc.cachefunc.CachedMethodCaller.__call__ (sage/misc/cachefunc.c:9194)
      File "cachefunc.pyx", line 2191, in sage.misc.cachefunc.CachedMethod._instance_call (sage/misc/cachefunc.c:11887)
      File "/Users/leif/Sage/sage-6.2.beta7/local/lib/python2.7/site-packages/sage/rings/number_field/number_field.py", line 4420, in galois_group
        return GaloisGroup_v2(self, names)
      File "/Users/leif/Sage/sage-6.2.beta7/local/lib/python2.7/site-packages/sage/rings/number_field/galois_group.py", line 184, in __init__
        self._galois_closure, self._gc_map = number_field.galois_closure(names=names, map=True)
      File "/Users/leif/Sage/sage-6.2.beta7/local/lib/python2.7/site-packages/sage/rings/number_field/number_field.py", line 6841, in galois_closure
        L, self_into_L = self._galois_closure_and_embedding(names)
      File "/Users/leif/Sage/sage-6.2.beta7/local/lib/python2.7/site-packages/sage/rings/number_field/number_field.py", line 6758, in _galois_closure_and_embedding
        raise TypeError("You must specify the name of the generator.")
    TypeError: You must specify the name of the generator.
**********************************************************************
1 item had failures:
   1 of  17 in sage.rings.number_field.number_field.NumberField_generic.galois_group
    [1690 tests, 1 failure, 68.83 s]

(It's actually Sage 6.2.rc2, despite the folder name.)

[nexttime]

comment:8

Getting more doctest failures; full report later^TM...

[malb]

comment:9

These should go into a new ticket, though (?) Or is that something this patch broke?

[vbraun]

Changed branch from u/malb/16282-magma-cache to 566082b

[malb]

Changed commit from 566082b to none

[malb]

comment:11

See #16322 for those doctest failures.