Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magma doctest failures #16322

Closed
malb opened this issue May 10, 2014 · 15 comments
Closed

Magma doctest failures #16322

malb opened this issue May 10, 2014 · 15 comments

Comments

@malb
Copy link
Member

malb commented May 10, 2014

These doctests currently fail:

sage -t --long --optional sage,magma /bulk/home/malb/software/sage/src/sage/symbolic/expression.pyx
sage -t --long --optional sage,magma /bulk/home/malb/software/sage/src/sage/rings/number_field/number_field.py
sage -t --long --optional sage,magma /bulk/home/malb/software/sage/src/sage/matrix/benchmark.py
sage -t --long --optional sage,magma /bulk/home/malb/software/sage/src/sage/rings/polynomial/polynomial_rational_flint.pyx
sage -t --long --optional sage,magma /bulk/home/malb/software/sage/src/sage/rings/polynomial/multi_polynomial_sequence.py
sage -t --long --optional sage,magma /bulk/home/malb/software/sage/src/sage/rings/integer_ring.pyx 

Depends on #16282

Upstream: None of the above - read trac for reasoning.

CC: @nexttime

Component: PLEASE CHANGE

Keywords: magma

Author: Martin Albrecht

Branch/Commit: 1b5d36d

Reviewer: Volker Braun

Issue created by migration from https://trac.sagemath.org/ticket/16322

@malb malb added this to the sage-6.3 milestone May 10, 2014
@malb
Copy link
Member Author

malb commented May 10, 2014

Commit: 46246fa

@malb
Copy link
Member Author

malb commented May 10, 2014

comment:2

All doctest failures fixed except for

sage -t --long --optional sage,magma /bulk/home/malb/software/sage/src/sage/rings/number_field/number_field.py

where I'm not immediately sure what to do.


New commits:

548d2e6fix magma(P) for P a multivariate polynomial ring
566082bfix various Magma doctest failures
1938841Merge branch 'develop' of trac.sagemath.org:sage into magma
46246fafix magma doctest failures

@malb
Copy link
Member Author

malb commented May 10, 2014

Branch: u/malb/16322-magma-doctests

@malb
Copy link
Member Author

malb commented May 10, 2014

Dependencies: 16282

@malb
Copy link
Member Author

malb commented May 10, 2014

Changed dependencies from 16282 to #16282

@nexttime
Copy link
Mannequin

nexttime mannequin commented May 10, 2014

comment:5

These were the ones failing for me on bsd.math with vanilla Sage 6.2 (and --long --optional=magma,sage --all, Magma V2.18-6):

----------------------------------------------------------------------
sage -t --long src/sage/interfaces/magma.py  # 21 doctests failed
sage -t --long src/sage/matrix/benchmark.py  # 26 doctests failed
sage -t --long src/sage/matrix/matrix1.pyx  # 2 doctests failed
sage -t --long src/sage/rings/integer_ring.pyx  # 1 doctest failed
sage -t --long src/sage/rings/quotient_ring.py  # 1 doctest failed
sage -t --long src/sage/rings/quotient_ring_element.py  # 2 doctests failed
sage -t --long src/sage/rings/number_field/number_field.py  # 1 doctest failed
sage -t --long src/sage/rings/polynomial/multi_polynomial.pyx  # 4 doctests failed
sage -t --long src/sage/rings/polynomial/multi_polynomial_ideal.py  # 4 doctests failed
sage -t --long src/sage/rings/polynomial/multi_polynomial_ring_generic.pyx  # 5 doctests failed
sage -t --long src/sage/rings/polynomial/multi_polynomial_sequence.py  # 1 doctest failed
sage -t --long src/sage/rings/polynomial/pbori.pyx  # 3 doctests failed
sage -t --long src/sage/rings/polynomial/polynomial_element.pyx  # 1 doctest failed
sage -t --long src/sage/rings/polynomial/polynomial_rational_flint.pyx  # 1 doctest failed
sage -t --long src/sage/rings/polynomial/term_order.py  # 1 doctest failed
sage -t --long src/sage/symbolic/expression.pyx  # 1 doctest failed
sage -t --long src/doc/en/bordeaux_2008/birds_other.rst  # 3 doctests failed
----------------------------------------------------------------------

@nexttime
Copy link
Mannequin

nexttime mannequin commented May 10, 2014

comment:6

P.S.: Sorry, I only later noticed the purpose of #16282 was not to fix all Magma doctests; I somehow completely misread the ticket and/or your post to sage-devel (presumably due to the Gmane outage ;-) )...

@nexttime
Copy link
Mannequin

nexttime mannequin commented May 10, 2014

comment:7

Replying to @nexttime:

These were the ones failing for me on bsd.math with vanilla Sage 6.2 (and --long --optional=magma,sage --all, Magma V2.18-6)

Full log here.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 11, 2014

Branch pushed to git repo; I updated commit sha1. New commits:

1b5d36dmagma error reporting changed

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 11, 2014

Changed commit from 46246fa to 1b5d36d

@malb
Copy link
Member Author

malb commented May 11, 2014

comment:9

these are all resolved except for the Galois group thing mentioned above (I fixed one more issue where newer versions of Magma report errors slightly different from older versions)

@malb
Copy link
Member Author

malb commented Jun 25, 2014

comment:10

anyone up for reviewing tis?

@vbraun
Copy link
Member

vbraun commented Jul 16, 2014

Reviewer: Volker Braun

@vbraun
Copy link
Member

vbraun commented Jul 16, 2014

comment:11

Maybe you want to set the ticket to "needs review" first? Is it?

@vbraun
Copy link
Member

vbraun commented Jul 17, 2014

Changed branch from u/malb/16322-magma-doctests to 1b5d36d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants