Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UniqueFactory for unhashable elements #16317

Closed
saraedum opened this issue May 9, 2014 · 7 comments
Closed

UniqueFactory for unhashable elements #16317

saraedum opened this issue May 9, 2014 · 7 comments
Labels
p: minor / 4 t: enhancement
Milestone
sage-6.3

Comments

@saraedum
Copy link
Member

saraedum commented May 9, 2014

Similar to #16316, caching does not work in factories if some of the parameters
are not hashable.
With this ticket, factories look at the _cache_key defined for cached
functions/methods if a parameter is not hashable.

Depends on #16316

Component: misc

Author: Julian Rueth

Branch/Commit: ba9befa

Reviewer: Peter Bruin

Issue created by migration from https://trac.sagemath.org/ticket/16317
@saraedum saraedum added this to the sage-6.2 milestone May 9, 2014
@saraedum
Copy link
Member Author

saraedum commented May 9, 2014

Branch: u/saraedum/ticket/16317

@saraedum
Copy link
Member Author

saraedum commented May 9, 2014

Dependencies: #16316

@saraedum
Copy link
Member Author

saraedum commented May 9, 2014

New commits:

7a0f094Introduced _cache_key for sage objects
62c9681made polynomials with unhashable coefficients unhashable
fa16bc7Merge branch 'u/saraedum/ticket/16251' of git://trac.sagemath.org/sage into ticket/16316
798aaf8Implemented _cache_key() for polynomials
877302eEnable caching for non-hashable objects
ba9befaEnabled caching for unhashable objects in factories

@saraedum
Copy link
Member Author

saraedum commented May 9, 2014

Commit: ba9befa

@saraedum
Copy link
Member Author

saraedum commented May 9, 2014

Author: Julian Rueth

@nexttime nexttime mannequin modified the milestones: sage-6.2, sage-6.3 May 11, 2014
@pjbruin
Copy link
Contributor

pjbruin commented Jun 24, 2014

Reviewer: Peter Bruin

@vbraun
Copy link
Member

vbraun commented Jul 15, 2014

Changed branch from u/saraedum/ticket/16317 to ba9befa

@vbraun vbraun closed this as completed in b5e0434 Jul 15, 2014
@simon-king-jena simon-king-jena mentioned this issue Nov 28, 2014
Closed
@mmasdeu mmasdeu mentioned this issue Mar 26, 2016
Closed
This was referenced Sep 30, 2015
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p: minor / 4 t: enhancement
Projects
None yet
Milestone
sage-6.3
Development

No branches or pull requests
3 participants
@saraedum @vbraun @pjbruin