Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DirichletGroup broken over rings with unhashable coefficients #16342

Open
saraedum opened this issue May 12, 2014 · 22 comments
Open

DirichletGroup broken over rings with unhashable coefficients #16342

saraedum opened this issue May 12, 2014 · 22 comments
Labels
c: modular forms p: minor / 4 s: needs work t: bug

Comments

@saraedum
Copy link
Member

The following fails

sage: K.<a> = Qq(9)
sage: DirichletGroup(1,zeta=K(-1),base_ring=K,zeta_order=2)
TypeError

Depends on #16317
Depends on #15692

Component: modular forms

Keywords: days71

Work Issues: probably does not work anymore

Author: Julian Rüth

Branch/Commit: u/saraedum/ticket/16342 @ b3f50f1

Reviewer: Aly Deines

Issue created by migration from https://trac.sagemath.org/ticket/16342
@saraedum saraedum added this to the sage-6.3 milestone May 12, 2014
@saraedum
Copy link
Member Author

Branch: u/saraedum/ticket/16342

@saraedum
Copy link
Member Author

Dependencies: #16317

@saraedum
Copy link
Member Author

Author: Julian Rueth

@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.3, sage-6.4 Aug 10, 2014
@jdemeyer
Copy link

jdemeyer commented May 6, 2015

Commit: 8b7a3f6

@jdemeyer
Copy link

jdemeyer commented May 6, 2015

comment:5

What's the relation between #16342 and #16258? In any case, needs rebasing.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 4, 2015

Branch pushed to git repo; I updated commit sha1. New commits:

69c1cdcMerge branch 'develop' into t/16342/ticket/16342
677a927Made output of DirichletGroup test case stable

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 4, 2015

Changed commit from 8b7a3f6 to 677a927

@pjbruin
Copy link
Contributor

pjbruin commented Oct 5, 2015

comment:9

Note: this also appears to be fixed by #6018.

@pjbruin
Copy link
Contributor

pjbruin commented Oct 5, 2015

comment:10

There are doctest failures, see the patchbot report.

@saraedum
Copy link
Member Author

comment:11

The cache can currently not be pickled if it contains p-adics. #15692 sort of fixes this, but once this gets merged, I need to change the __setstate__ in here to restore the cache.

@saraedum
Copy link
Member Author

Changed dependencies from #16317 to #16317, #15692

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 23, 2016

Changed commit from 677a927 to f0d91d4

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 23, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

f0d91d4Merge branch 'develop' into t/16342/ticket/16342

@adeines
Copy link
Mannequin

adeines mannequin commented Mar 23, 2016

comment:14

Looks good.

@adeines
Copy link
Mannequin

adeines mannequin commented Mar 23, 2016

Reviewer: Aly Deines

@jbalakrishnan
Copy link

Changed keywords from none to days71

@pjbruin
Copy link
Contributor

pjbruin commented Apr 12, 2016

comment:16

Merge conflict with #6018.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 21, 2017

Changed commit from f0d91d4 to b3f50f1

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 21, 2017

Branch pushed to git repo; I updated commit sha1. New commits:

b3f50f1Merge remote-tracking branch 'origin/develop' into t/16342/ticket/16342

@saraedum
Copy link
Member Author

Work Issues: probably does not work anymore

@saraedum
Copy link
Member Author

New commits:

b3f50f1Merge remote-tracking branch 'origin/develop' into t/16342/ticket/16342

@saraedum
Copy link
Member Author

Changed author from Julian Rueth to Julian Rüth

@mkoeppe mkoeppe removed this from the sage-6.4 milestone Dec 29, 2022
@mmasdeu mmasdeu mentioned this issue Mar 26, 2016
Closed
@saraedum saraedum mentioned this issue Jan 21, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: modular forms p: minor / 4 s: needs work t: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@saraedum @jbalakrishnan @jdemeyer @mkoeppe @pjbruin