MOLS: Table with n<600 and updated syntax

[nathanncohen]

Heeeeere it is ! A longer table, as we can compute it rather quickly now, aaaaand also a change in the syntax of the new function mutually_orthogonal_latin_squares which accepted n,k when all others (TD and OA) expected k,n.

Nathann

Depends on #16535

CC: @videlec

Component: combinatorial designs

Author: Nathann Cohen

Branch/Commit: 01689fd

Reviewer: Vincent Delecroix

Issue created by migration from https://trac.sagemath.org/ticket/16582

[nathanncohen]

Branch: u/ncohen/16582

[sagetrac-git]

Commit: ae762e6

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

8da2c73	trac #16503: Broken doc
0d768df	trac #16535: merge #16503
002ceee	trac #16524: OA(9,135)
c6e78c8	trac #16524: move the cyclic difference set to the constructor
a0294d3	trac #16524: more comments in the doc
41b7f00	trac #16535: merge #16524
3487f09	trac #16528: OA(9,120)
c80b7f4	trac #16528: review
2b3c809	trac #16535: merge #16528
ae762e6	trac #16582: MOLS: Table with n<600 and updated syntax

[videlec]

comment:3

Hi Nathann,

How does it fit with #16541?

Vincent

[nathanncohen]

comment:4

Arggggggg... Yes, it is in conflict T_T

Nathann

[nathanncohen]

Changed dependencies from #16535 to #16541

[nathanncohen]

Changed dependencies from #16541 to #16541, #16535

[nathanncohen]

comment:6

Funny. There was no conflict during the merge. Git is smarter than I thought ;-)

Nathann

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

29c48c3	trac #16541: MOLS table : 10 000 integers
4e8556d	trac #16582: Merged with #16541

[sagetrac-git]

Changed commit from ae762e6 to 4e8556d

[videlec]

comment:8

But I am less smart than git and it will help me for the reviews ;-) Thanks.

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

[sagetrac-git]

Changed commit from 4e8556d to ae762e6

[nathanncohen]

Changed dependencies from #16541, #16535 to #16535

[nathanncohen]

comment:11

How does it fit with #16541?

Let me answer your question again : there is no conflict between the two, they don't touch the same parts of the code :-P

Nathann

[sagetrac-git]

Changed commit from ae762e6 to 442b328

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

442b328

trac #16582: MOLS: Table with n<600 and updated syntax

[videlec]

comment:13

Hi Nathann,

• You could remove the # long time for the test at lines 480 and 488.

• We will run into troubles if somebody asks for a table larger than the one available (with compare=True). There is no overflow check. Actually, it is not that bad, on the line failure you will get a IndexError.

Otherwise, looks good to me. What do you think of having designs.MOLS_table globally available? It is a cool feature.

Vincent

[nathanncohen]

comment:15

• You could remove the # long time for the test at lines 480 and 488.

Done.

• We will run into troubles if somebody asks for a table larger than the one available (with compare=True).

You mean 10 000 ? O_o

Otherwise, looks good to me. What do you think of having designs.MOLS_table globally available? It is a cool feature.

Well, it is a cool feature but designs.<tab> is meant to gather constructors, so where could we put it ?...

Plus it is "cool" but it is mostly a toy. And it is well advertised at the head of the MOLS module's doc.

Nathann

[sagetrac-git]

Changed commit from 442b328 to e16a2e2

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

e16a2e2

trac #16582: MOLS: Table with n<600 and updated syntax

[sagetrac-git]

Changed commit from e16a2e2 to 01689fd

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

01689fd

trac #16582: MOLS: Table with n<600 and updated syntax

[videlec]

comment:18

Good to go!

Vincent

[videlec]

Reviewer: Vincent Delecroix

[vbraun]

Changed branch from u/ncohen/16582 to 01689fd