Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new OA for n=112,160,176,208,224,352,416,514,544,640,796,896 #16604

Closed
nathanncohen mannequin opened this issue Jul 2, 2014 · 79 comments
Closed

new OA for n=112,160,176,208,224,352,416,514,544,640,796,896 #16604

nathanncohen mannequin opened this issue Jul 2, 2014 · 79 comments

Comments

@nathanncohen
Copy link
Mannequin

nathanncohen mannequin commented Jul 2, 2014

As the title says.

Because this method also needs to shorten a matrix in the middle of OA_from_Vmt, it is split into QDM_from_Vmt and OA_from_quasi_difference_matrix (which was already called).

Nathann

Depends on #16582
Depends on #16797

CC: @videlec

Component: combinatorial designs

Author: Nathann Cohen

Branch/Commit: 24c4f7f

Reviewer: Vincent Delecroix

Issue created by migration from https://trac.sagemath.org/ticket/16604

@nathanncohen nathanncohen mannequin added this to the sage-6.3 milestone Jul 2, 2014
@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Jul 2, 2014

Branch: u/ncohen/16604

@nathanncohen nathanncohen mannequin added the s: needs review label Jul 2, 2014
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 2, 2014

Commit: 00654fb

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 2, 2014

Branch pushed to git repo; I updated commit sha1. New commits:

01689fdtrac #16582: MOLS: Table with n<600 and updated syntax
0c08a79trac #16582: Merged with beta5
00654fbtrac #16604: new OA for n=112,160,224,514,796

@videlec
Copy link
Contributor

videlec commented Jul 3, 2014

comment:3

Hey Nathann,

In OA_14_124, it is not safe to ask for a finite field of size 25 and hope that, by chance, its generator satisfies w^5 + w^2 + 1 = 0. You would rather give the constructor an explicit polynomial:

sage: R = PolynomialRing(GF(2),'x')
sage: x = R.gen()
sage: GF(2**5, 'w', modulus=x**5+x**2+1)
Finite Field in w of size 2^5

and I got a docbuild error

OSError: [combinat ] None:5: WARNING: citation not found: BvR514

Vincent

@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Jul 3, 2014

comment:4

Yo !

In OA_14_124, it is not safe to ask for a finite field of size 25 and hope that, by chance, its generator satisfies w^5 + w^2 + 1 = 0.

Yeah... And "by chance" it always works ?

Given that you are the one to complain about this, I will use the first's trick against you : conway=True :-P

and I got a docbuild error

OSError: [combinat ] None:5: WARNING: citation not found: BvR514

Ahahahah. I must have replaced 82 with 514 at some point :-D

I had also "made a small mistake" in the implementation. I had forgotten to set some flag from "False" to "True", which means that the new OA have a longer width. I didn't like to notice that I had implemented so many new OA and that they did not even reach the Handbook's bound.... Now all is good :-P

I also added an OA for 640, freshly debugged.

Nathann

@nathanncohen nathanncohen mannequin changed the title new OA for n=112,160,224,514,796 new OA for n=112,160,224,514,640,796 Jul 3, 2014
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 3, 2014

Changed commit from 00654fb to ee7ac60

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 3, 2014

Branch pushed to git repo; I updated commit sha1. New commits:

ee7ac60trac #16604: OA for n=640, reviewer's remarks and silly mistake

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 3, 2014

Changed commit from ee7ac60 to ba6609d

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 3, 2014

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

ba6609dtrac #16604: OA for n=640, reviewer's remarks and silly mistake

@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Jul 3, 2014

comment:7

(I had forgotten a "Found by Julian R. Abel" line)

Nathann

@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Jul 4, 2014

comment:8

added a OA(15,896).

@nathanncohen nathanncohen mannequin changed the title new OA for n=112,160,224,514,640,796 new OA for n=112,160,224,514,640,796,896 Jul 4, 2014
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 4, 2014

Changed commit from ba6609d to c218148

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 4, 2014

Branch pushed to git repo; I updated commit sha1. New commits:

c218148trac #16604: OA(15,896)

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 4, 2014

Changed commit from c218148 to 03c2ca3

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 4, 2014

Branch pushed to git repo; I updated commit sha1. New commits:

03c2ca3trac #16604: OA(16,208)

@nathanncohen nathanncohen mannequin changed the title new OA for n=112,160,224,514,640,796,896 new OA for n=112,160,208,224,514,640,796,896 Jul 4, 2014
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 4, 2014

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

6074f4btrac #16604: OA(16,208)

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 4, 2014

Changed commit from 03c2ca3 to 6074f4b

@nathanncohen nathanncohen mannequin changed the title new OA for n=112,160,208,224,514,640,796,896 new OA for n=112,160,176,208,224,514,640,796,896 Jul 5, 2014
@videlec
Copy link
Contributor

videlec commented Aug 11, 2014

comment:46

The matrix A has as many rows as the length of Y and has 2|G| columns...

Vincent

@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Aug 11, 2014

comment:47

Cool ! This time I got it ! :-D

It really is hell with everybody using the matrix or its transpose T_T

By the wayyyyyy... As this function is now public... Would you feel like writing some code to check that all constraints are satisfied ? ^^;

You see all these things better than I, that's why I ask... ^^;

Nathann

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 11, 2014

Branch pushed to git repo; I updated commit sha1. New commits:

bff470etrac #16604: small check of dimensions

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 11, 2014

Changed commit from d612056 to bff470e

@videlec
Copy link
Contributor

videlec commented Aug 11, 2014

comment:49

Good idea. I did the dimension check... if we want more, we need is_difference_matrix.

I would go for a positive review at this stage... what do you think?

Vincent

@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Aug 11, 2014

comment:50

Yo !

Good idea. I did the dimension check... if we want more, we need is_difference_matrix.

We don't have is_difference_matrix ? O_o

Okay then I will write this today. You may like difference families but I like difference matrices.

We need a is_difference_matrix. Then we'll finish this ticket.

Nathann

@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Aug 11, 2014

comment:51

Ticket for is_difference_matrix: #16797

Nathann

@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Aug 11, 2014

Changed dependencies from #16582 to #16582,#16797

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 13, 2014

Changed commit from bff470e to 579e75b

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 13, 2014

Branch pushed to git repo; I updated commit sha1. New commits:

8f10d94trac #16797: is_difference_matrix
aa097f6trac #16797: Fit with the current definition until we can change everything at once
5d21b8ctrac #16797: int * and ** instead of Python list
8f29bd1trac #16797: change int to int * in a malloc
811e3e9trac #16797: better malloc + better error msg
1b8c2e3trac #16797: More compact mallocs
b78c347trac #16797: Reorder the arguments to copy is_orthogonal_array
6c21904trac #16797: correct a row/column inversion
48b6902trac #16604: merge #16797
579e75btrac #16604: input check + doctest

@videlec
Copy link
Contributor

videlec commented Aug 13, 2014

comment:53

Needs review.

Vincent

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 13, 2014

Changed commit from 579e75b to 05c6915

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 13, 2014

Branch pushed to git repo; I updated commit sha1. New commits:

e1a83d0trac #16604: Optional check flag
05c6915trac #16604: Variable rename and list->set

@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Aug 13, 2014

comment:55

Your turn !

Nathann

@videlec
Copy link
Contributor

videlec commented Aug 13, 2014

comment:56

I am happy with the current version.

Vincent

@videlec
Copy link
Contributor

videlec commented Aug 13, 2014

Reviewer: Vincent Delecroix

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 16, 2014

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

dee4275trac #16797: Merged with 6.4.beta0
24c4f7ftrac #16604: Merge with updated #16797

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 16, 2014

Changed commit from 05c6915 to 24c4f7f

@vbraun
Copy link
Member

vbraun commented Aug 16, 2014

Changed branch from public/16604 to 24c4f7f

@vbraun vbraun closed this as completed in 63387fd Aug 16, 2014
vbraun pushed a commit that referenced this issue Jun 21, 2023
    
<!-- Please provide a concise, informative and self-explanatory title.
-->
<!-- Don't put issue numbers in the title. Put it in the Description
below. -->
<!-- For example, instead of "Fixes #12345", use "Add a new method to
multiply two integers" -->

### 📚 Description

<!-- Describe your changes here in detail. -->
<!-- Why is this change required? What problem does it solve? -->
- move `powerset` (= `subsets`) from the problematic `sage.misc.misc`
module to `sage.combinat.subset`,
- likewise we move the implementation of `uniq`
(`sage.misc.misc._stable_uniq`) and finish the job from #27014,
- we remove `sage.misc.misc.union`, deprecated in #16604,
- some other fixes to imports.

<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes #12345". -->
Part of:
- #29705
<!-- If your change requires a documentation PR, please link it
appropriately. -->

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. It should be `[x]` not `[x
]`. -->

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- #12345: short description why this is a dependency
- #34567: ...
-->
- Depends on #35672

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
    
URL: #35564
Reported by: Matthias Köppe
Reviewer(s): David Coudert, Matthias Köppe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants