New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new OA for n=112,160,176,208,224,352,416,514,544,640,796,896 #16604
Comments
Branch: u/ncohen/16604 |
Commit: |
comment:3
Hey Nathann, In
and I got a docbuild error
Vincent |
comment:4
Yo !
Yeah... And "by chance" it always works ? Given that you are the one to complain about this, I will use the first's trick against you :
Ahahahah. I must have replaced 82 with 514 at some point I had also "made a small mistake" in the implementation. I had forgotten to set some flag from "False" to "True", which means that the new OA have a longer width. I didn't like to notice that I had implemented so many new OA and that they did not even reach the Handbook's bound.... Now all is good I also added an OA for 640, freshly debugged. Nathann |
Branch pushed to git repo; I updated commit sha1. New commits:
|
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
|
comment:7
(I had forgotten a "Found by Julian R. Abel" line) Nathann |
comment:8
added a |
Branch pushed to git repo; I updated commit sha1. New commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
|
comment:46
The matrix Vincent |
comment:47
Cool ! This time I got it ! It really is hell with everybody using the matrix or its transpose By the wayyyyyy... As this function is now public... Would you feel like writing some code to check that all constraints are satisfied ? You see all these things better than I, that's why I ask... Nathann |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:49
Good idea. I did the dimension check... if we want more, we need I would go for a positive review at this stage... what do you think? Vincent |
comment:50
Yo !
We don't have Okay then I will write this today. You may like difference families but I like difference matrices. We need a Nathann |
comment:51
Ticket for is_difference_matrix: #16797 Nathann |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:53
Needs review. Vincent |
comment:55
Your turn ! Nathann |
comment:56
I am happy with the current version. Vincent |
Reviewer: Vincent Delecroix |
Changed branch from public/16604 to |
<!-- Please provide a concise, informative and self-explanatory title. --> <!-- Don't put issue numbers in the title. Put it in the Description below. --> <!-- For example, instead of "Fixes #12345", use "Add a new method to multiply two integers" --> ### 📚 Description <!-- Describe your changes here in detail. --> <!-- Why is this change required? What problem does it solve? --> - move `powerset` (= `subsets`) from the problematic `sage.misc.misc` module to `sage.combinat.subset`, - likewise we move the implementation of `uniq` (`sage.misc.misc._stable_uniq`) and finish the job from #27014, - we remove `sage.misc.misc.union`, deprecated in #16604, - some other fixes to imports. <!-- If this PR resolves an open issue, please link to it here. For example "Fixes #12345". --> Part of: - #29705 <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. It should be `[x]` not `[x ]`. --> - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - #12345: short description why this is a dependency - #34567: ... --> - Depends on #35672 <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: #35564 Reported by: Matthias Köppe Reviewer(s): David Coudert, Matthias Köppe
As the title says.
Because this method also needs to shorten a matrix in the middle of
OA_from_Vmt
, it is split intoQDM_from_Vmt
andOA_from_quasi_difference_matrix
(which was already called).Nathann
Depends on #16582
Depends on #16797
CC: @videlec
Component: combinatorial designs
Author: Nathann Cohen
Branch/Commit:
24c4f7f
Reviewer: Vincent Delecroix
Issue created by migration from https://trac.sagemath.org/ticket/16604
The text was updated successfully, but these errors were encountered: