Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coercion fixes for PolyBoRi #1667

Closed
burcin opened this issue Jan 3, 2008 · 2 comments
Closed

coercion fixes for PolyBoRi #1667

burcin opened this issue Jan 3, 2008 · 2 comments
Assignees
@williamstein
Labels
c: interfaces p: minor / 4 t: bug
Milestone
sage-2.9.2

Comments

@burcin
Copy link

burcin commented Jan 3, 2008

BooleanPolynomialRing supports coercion from rings where the number of variables is greater than self. This code should be in __call__ and coercion should first check for the number of variables of the parent ring.

Attached patch fixes this problem, and adds similar coercion and __call__ semantics to BooleanMonomialMonoid. It also fixes minor problems where using iterators of polynomials over a ring other than the current one messes PolyBoRi up.

Component: interfaces

Keywords: polybori

Issue created by migration from https://trac.sagemath.org/ticket/1667
@burcin burcin added this to the sage-2.9.2 milestone Jan 3, 2008
@burcin
Copy link
Author

burcin commented Jan 3, 2008

coercion & minor fixes to polybori

@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented Jan 3, 2008

comment:1

Attachment: polybori-coercion.patch.gz

Looks good to me. This is isolated to polybori, so I merged it.

Cheers,

Michael

@sagetrac-mabshoff sagetrac-mabshoff mannequin closed this as completed Jan 3, 2008
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@williamstein williamstein

Labels
c: interfaces p: minor / 4 t: bug
Projects
None yet
Milestone
sage-2.9.2
Development

No branches or pull requests
2 participants
@burcin @williamstein