Remove deprecated code

[a-andre]

Remove code deprecated in #7983, #13109, #13605, #13192, #14063.

Component: misc

Keywords: deprecated

Author: André Apitzsch

Branch/Commit: cf77bc2

Reviewer: Jeroen Demeyer

Issue created by migration from https://trac.sagemath.org/ticket/16933

[a-andre]

Branch: u/aapitzsch/ticket/16933

[a-andre]

Commit: 46f4fdc

[tscrim]

comment:2

I'm pretty sure the stuff in integer_list.py is not deprecated yet as it's still needed.

[sagetrac-git]

Changed commit from 46f4fdc to ea330d3

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

ea330d3

revert remove of iterator() and list()

[jdemeyer]

comment:4

I know I'm being pedantic here...

Explicitly calling Partition._repr_(self, compact=False) hasn't been deprecated so I guess the argument cannot be removed, it should just be totally ignored but not disallowed.

[jdemeyer]

comment:5

And RootSystem(['A',2]).weight_lattice().pi isn't deprecated either...

[a-andre]

comment:6

Replying to @jdemeyer:

And RootSystem(['A',2]).weight_lattice().pi isn't deprecated either...

According to the comment it somehow is deprecated. But I can revert this change.

Replying to @jdemeyer:

Explicitly calling Partition._repr_(self, compact=False) hasn't been deprecated so I guess the argument cannot be removed, it should just be totally ignored but not disallowed.

Do you want me to deprecate the argument?

[jdemeyer]

comment:7

Replying to @a-andre:

Replying to @jdemeyer:

And RootSystem(['A',2]).weight_lattice().pi isn't deprecated either...

According to the comment it somehow is deprecated. But I can revert this change.

What I meant is that the deprecation warning is commented out in the code for reasons which are not entirely clear to me. I think you should just uncomment that deprecation warning (with ticket number #16933).

Replying to @jdemeyer:

Explicitly calling Partition._repr_(self, compact=False) hasn't been deprecated so I guess the argument cannot be removed, it should just be totally ignored but not disallowed.

Do you want me to deprecate the argument?

Perhaps replace the argument with def _repr(self, compact=None): and then you can do in the code

if compact is not None:

[a-andre]

comment:8

Adding a deprecation warning to pi() leads to several failing doctests because of the @lazy_attribute. Removing @lazy_attribute also doesn't help.

Since there is a warning about the deprecation of pi() in documentation for more than 2 years now (see #6588), we should simply remove pi().

[sagetrac-git]

Changed commit from ea330d3 to cf77bc2

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

2e4f269	Merge remote-tracking branch 'origin/develop' into depr_func
cf77bc2	deprecate compact argument

[jdemeyer]

Reviewer: Jeroen Demeyer

[vbraun]

Changed branch from u/aapitzsch/ticket/16933 to cf77bc2