Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCD_list should return zero for an empty list #17257

Closed
slel opened this issue Oct 29, 2014 · 19 comments
Closed

GCD_list should return zero for an empty list #17257

slel opened this issue Oct 29, 2014 · 19 comments

Comments

@slel
Copy link
Member

slel commented Oct 29, 2014

The function GCD_list from sage.rings.integer returns one instead of zero for an empty list.

Component: basic arithmetic

Author: Samuel Lelièvre

Branch: b7a04f7

Reviewer: Vincent Delecroix, Peter Bruin

Issue created by migration from https://trac.sagemath.org/ticket/17257

@slel slel added this to the sage-6.4 milestone Oct 29, 2014
@slel
Copy link
Member Author

slel commented Oct 29, 2014

Commit: c36e453

@slel
Copy link
Member Author

slel commented Oct 29, 2014

Branch: u/slelievre/17257_GCD_list

@slel
Copy link
Member Author

slel commented Oct 29, 2014

New commits:

c36e453trac #17257: fix GCD_list

@videlec
Copy link
Contributor

videlec commented Oct 29, 2014

Changed branch from u/slelievre/17257_GCD_list to public/17257

@videlec
Copy link
Contributor

videlec commented Oct 29, 2014

Changed commit from c36e453 to 94a9e48

@videlec
Copy link
Contributor

videlec commented Oct 29, 2014

Reviewer: Vincent Delecroix

@videlec
Copy link
Contributor

videlec commented Oct 29, 2014

comment:2

Hello,

I added a commit on top of yours. If you like it you can set to positive review.

Vincent


New commits:

94a9e48trac #17257: improve documentation

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 29, 2014

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

2a2a3c5trac #17257: improve documentation

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 29, 2014

Changed commit from 94a9e48 to 2a2a3c5

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 30, 2014

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

4f8b380trac #17257: improve documentation

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 30, 2014

Changed commit from 2a2a3c5 to 4f8b380

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 30, 2014

Branch pushed to git repo; I updated commit sha1. New commits:

b7a04f7Trac 17257: more documentation improvements

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 30, 2014

Changed commit from 4f8b380 to b7a04f7

@pjbruin
Copy link
Contributor

pjbruin commented Oct 30, 2014

comment:6

Replying to @videlec:

I added a commit on top of yours. If you like it you can set to positive review.

Same for me.

@pjbruin
Copy link
Contributor

pjbruin commented Oct 30, 2014

Changed reviewer from Vincent Delecroix to Vincent Delecroix, Peter Bruin

@slel
Copy link
Member Author

slel commented Oct 30, 2014

comment:7

Thanks for the improvements to the documentation. Positive review.

@vbraun
Copy link
Member

vbraun commented Oct 31, 2014

Changed branch from public/17257 to b7a04f7

@slel
Copy link
Member Author

slel commented Nov 3, 2014

comment:9

For reference, the gcd of an empty list is discussed in this sage-devel thread.

@slel
Copy link
Member Author

slel commented Nov 3, 2014

Changed commit from b7a04f7 to none

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants