Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the empty set to generate IntegerModRing(1) #17337

Closed
pjbruin opened this issue Nov 13, 2014 · 4 comments
Closed

Use the empty set to generate IntegerModRing(1) #17337

pjbruin opened this issue Nov 13, 2014 · 4 comments
Labels
c: finite rings p: minor / 4 t: enhancement
Milestone
sage-6.4

Comments

@pjbruin
Copy link
Contributor

pjbruin commented Nov 13, 2014

The following choice of generators for two trivial groups is somewhat inconsistent:

sage: Zmod(1).unit_gens()
(0,)
sage: Zmod(2).unit_gens()
()

It would be better to use the empty set as a set of generators for the unit group of Zmod(1) as well.

The main adaptation that this requires is that DirichletGroup(1).0 no longer works (this group is also generated by the empty set) and needs to be changed to DirichletGroup(1)[0].

Depends on #17317

CC: @jdemeyer

Component: finite rings

Keywords: unit group

Author: Peter Bruin

Branch/Commit: a38ab1f

Reviewer: Volker Braun

Issue created by migration from https://trac.sagemath.org/ticket/17337
@pjbruin pjbruin added this to the sage-6.4 milestone Nov 13, 2014
@pjbruin
Copy link
Contributor Author

pjbruin commented Nov 13, 2014

Commit: a38ab1f

@pjbruin
Copy link
Contributor Author

pjbruin commented Nov 13, 2014

Branch: u/pbruin/17337-IntegerModRing_empty_generating_set

@vbraun
Copy link
Member

vbraun commented Dec 3, 2014

Reviewer: Volker Braun

@vbraun
Copy link
Member

vbraun commented Dec 3, 2014

Changed branch from u/pbruin/17337-IntegerModRing_empty_generating_set to a38ab1f

@vbraun vbraun closed this as completed in 2fcb35e Dec 3, 2014
@pjbruin pjbruin mentioned this issue Dec 3, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: finite rings p: minor / 4 t: enhancement
Projects
None yet
Milestone
sage-6.4
Development

No branches or pull requests
2 participants
@vbraun @pjbruin