Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix printing of Dirichlet characters #17338

Closed
pjbruin opened this issue Nov 13, 2014 · 4 comments
Closed

Fix printing of Dirichlet characters #17338

pjbruin opened this issue Nov 13, 2014 · 4 comments
Labels
c: number theory p: minor / 4 t: bug
Milestone
sage-6.4

Comments

@pjbruin
Copy link
Contributor

pjbruin commented Nov 13, 2014

Dirichlet characters modulo 2 are printed in a strange way:

sage: DirichletGroup(2)[0]
Dirichlet character modulo 2 of conductor 1 mapping

After #17337, this also happens for Dirichlet characters modulo 1.

This ticket makes Dirichlet characters modulo 1 and 2 print as

sage: DirichletGroup(1)[0]
Dirichlet character modulo 1 of conductor 1
sage: DirichletGroup(2)[0]
Dirichlet character modulo 2 of conductor 1

and uses the mapping ... only for conductors >= 3:

sage: DirichletGroup(3)[1]
Dirichlet character modulo 3 of conductor 1 mapping 2 |--> -1

Depends on #17337

CC: @jdemeyer

Component: number theory

Keywords: Dirichlet characters

Author: Peter Bruin

Branch/Commit: f431aad

Reviewer: Volker Braun

Issue created by migration from https://trac.sagemath.org/ticket/17338
@pjbruin pjbruin added this to the sage-6.4 milestone Nov 13, 2014
@pjbruin
Copy link
Contributor Author

pjbruin commented Nov 13, 2014

Branch: u/pbruin/17338-DirichletCharacter_printing

@pjbruin
Copy link
Contributor Author

pjbruin commented Nov 13, 2014

Commit: f431aad

@vbraun
Copy link
Member

vbraun commented Dec 3, 2014

Reviewer: Volker Braun

@vbraun
Copy link
Member

vbraun commented Dec 3, 2014

Changed branch from u/pbruin/17338-DirichletCharacter_printing to f431aad

@vbraun vbraun closed this as completed in 8faa2a5 Dec 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: number theory p: minor / 4 t: bug
Projects
None yet
Milestone
sage-6.4
Development

No branches or pull requests
2 participants
@vbraun @pjbruin