Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sage-crap script #17465

Closed
jdemeyer opened this issue Dec 8, 2014 · 11 comments
Closed

Remove sage-crap script #17465

jdemeyer opened this issue Dec 8, 2014 · 11 comments

Comments

@jdemeyer
Copy link

jdemeyer commented Dec 8, 2014

Remove this obsolete script from Sage.

CC: @williamstein

Component: scripts

Author: Jeroen Demeyer

Branch/Commit: 5b7363d

Reviewer: William Stein, Karl-Dieter Crisman

Issue created by migration from https://trac.sagemath.org/ticket/17465

@jdemeyer jdemeyer added this to the sage-6.5 milestone Dec 8, 2014
@jdemeyer
Copy link
Author

jdemeyer commented Dec 8, 2014

Branch: u/jdemeyer/ticket/17465

@jdemeyer
Copy link
Author

jdemeyer commented Dec 8, 2014

Commit: 5b7363d

@jdemeyer
Copy link
Author

jdemeyer commented Dec 8, 2014

New commits:

5b7363dRemove obsolete sage-crap script

@kcrisman
Copy link
Member

kcrisman commented Dec 8, 2014

comment:3

I don't have a problem with removing - just curious why it's obsolete, since presumably it was to detect things like Mac .DS_Store files or upstream binary files or something. Does the git transition and reorganization of the files make this unnecessary?

@jdemeyer
Copy link
Author

jdemeyer commented Dec 8, 2014

comment:4

Replying to @kcrisman:

Does the git transition and reorganization of the files make this unnecessary?

Essentially yes. The Sage tarball is made in a much better way than it used to be, using git indeed.

@kcrisman
Copy link
Member

kcrisman commented Dec 8, 2014

comment:5

I'm happy with this, but I'd feel more comfortable if William said "go for it", since I think he's one of the only people who ever really used it...

@jdemeyer
Copy link
Author

jdemeyer commented Dec 8, 2014

comment:6

Replying to @kcrisman:

he's one of the only people who ever really used it...

That should even be an extra indication that it can be removed...

@williamstein
Copy link
Contributor

comment:7

Go for it! The project that required this functionality is over.

@kcrisman
Copy link
Member

kcrisman commented Dec 8, 2014

Reviewer: William Stein, Karl-Dieter Crisman

@kcrisman
Copy link
Member

kcrisman commented Dec 8, 2014

comment:8

Awesome. Let me just check this merges, though given the author I have no doubts :)

@vbraun
Copy link
Member

vbraun commented Dec 18, 2014

Changed branch from u/jdemeyer/ticket/17465 to 5b7363d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants