Deprecate moved imports from sage.misc #17460

jdemeyer · 2014-12-07T23:21:51Z

Lots of things are imported in sage.misc.misc for "backwards compatibility". Let's deprecate these.

Depends on #10057
Depends on #17455
Depends on #17458
Depends on #17459
Depends on #17465

Component: misc

Author: Jeroen Demeyer

Branch/Commit: 92de9fc

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/17460

The text was updated successfully, but these errors were encountered:

jdemeyer · 2014-12-08T09:35:37Z

Changed dependencies from #10057, #17455, #17458, #17459 to #10057, #17455, #17458, #17459, #17465

jdemeyer · 2014-12-08T18:41:13Z

Branch: u/jdemeyer/ticket/17460

sagetrac-git · 2014-12-18T16:49:57Z

Branch pushed to git repo; I updated commit sha1. New commits:

`8e8202a`	`Merge remote-tracking branch 'origin/develop' into ticket/17460`
`fa8cb36`	`Remove unused database modules`
`92753f4`	`Merge commit 'fa8cb3694034f4d1735f7aaffee9c83e8ee65ce3' into ticket/17460`
`75d7418`	`Skip lazy imports when docbuilding`
`96634b9`	`Merge commit '75d7418c1d5e8e7bf2523cd2ad298d45fc4015d6' into ticket/17460`

sagetrac-git · 2014-12-18T16:49:57Z

Commit: 96634b9

sagetrac-git · 2014-12-18T16:55:55Z

Branch pushed to git repo; I updated commit sha1. New commits:

`afafc75`	`Simplify computation of wordsize`

sagetrac-git · 2014-12-18T16:55:55Z

Changed commit from 96634b9 to afafc75

sagetrac-git · 2014-12-18T20:28:46Z

Branch pushed to git repo; I updated commit sha1. New commits:

`3dee489`	`Deprecate is_32_bit and is_64_bit globals`

sagetrac-git · 2014-12-18T20:28:46Z

Changed commit from afafc75 to 3dee489

sagetrac-git · 2014-12-24T09:39:31Z

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

`14d3291`	`Upgrade sagenb to version 0.11.2`
`d113d1d`	`Merge branch 'u/jdemeyer/ticket/17455' of git://trac.sagemath.org/sage into ticket/10057`
`307c605`	`Deprecate moved imports from sage.misc.misc`

sagetrac-git · 2014-12-24T09:39:31Z

Changed commit from 3dee489 to 307c605

jdemeyer · 2014-12-24T12:46:04Z

Author: Jeroen Demeyer

sagetrac-git · 2015-01-19T10:50:12Z

Changed commit from 307c605 to f6e149c

sagetrac-git · 2015-01-19T10:50:12Z

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

`f6e149c`	`Deprecate moved imports from sage.misc.misc`

jdemeyer · 2015-01-19T10:50:56Z

Changed dependencies from #10057, #17455, #17458, #17459, #17465 to none

sagetrac-git · 2015-01-19T11:02:15Z

Changed commit from f6e149c to 67e7b5e

sagetrac-git · 2015-01-19T11:02:15Z

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

`67e7b5e`	`Deprecate moved imports from sage.misc.misc`

jdemeyer · 2015-01-19T11:02:18Z

Dependencies: #10057, #17455, #17458, #17459, #17465

jdemeyer · 2015-01-19T11:02:36Z

Changed dependencies from #10057, #17455, #17458, #17459, #17465 to none

sagetrac-git · 2015-01-19T12:36:16Z

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

`d12c094`	`Deprecate moved imports from sage.misc.misc`

sagetrac-git · 2015-01-19T12:36:16Z

Changed commit from 67e7b5e to d12c094

jdemeyer · 2015-01-19T12:36:19Z

Dependencies: #10057, #17455, #17458, #17459, #17465

fchapoton · 2015-01-19T21:22:17Z

comment:15

LGTM

fchapoton · 2015-01-19T21:22:17Z

Reviewer: Frédéric Chapoton

jdemeyer · 2015-01-19T22:16:00Z

comment:16

Thanks for the review!

vbraun · 2015-01-24T13:22:33Z

comment:17

Merge conflict, probably with #14396

sagetrac-git · 2015-01-24T14:46:06Z

Branch pushed to git repo; I updated commit sha1. New commits:

`96aac18`	`trac #14396: ISGCI update, small graphs and recognition`
`7857634`	`trac #14396: Merged with 6.5.beta5`
`f287fee`	`trac #14396: Review`
`b44dcb0`	`trac #14396: Review`
`026b281`	`Merge ticket/14396 into ticket/17460`

sagetrac-git · 2015-01-24T14:46:06Z

Changed commit from d12c094 to 026b281

jdemeyer · 2015-01-26T17:27:38Z

comment:20

Merge needs review...

fchapoton · 2015-01-26T21:25:47Z

comment:21

ok, looks good to me.

vbraun · 2015-01-29T08:48:53Z

comment:22

sage -t --long src/sage/matrix/matrix_space.py
**********************************************************************
File "src/sage/matrix/matrix_space.py", line 129, in sage.matrix.matrix_space.MatrixSpace
Failed example:
    MatrixSpace(ZZ,10,2^31)
Expected:
    Traceback (most recent call last):                                   
    ...                                                                  
    ValueError: number of rows and columns must be less than 2^31 (on a 32-bit computer -- use a 64-bit computer for matrices with up to 2^63-1 rows and columns)           
Got:
    <BLANKLINE>
    Traceback (most recent call last):
      File "/home/buildslave-sage/slave/sage_git/build/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 488, in _run
        self.compile_and_execute(example, compiler, test.globs)
      File "/home/buildslave-sage/slave/sage_git/build/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 850, in compile_and_execute
        exec(compiled, globs)
      File "<doctest sage.matrix.matrix_space.MatrixSpace[2]>", line 1, in <module>
        MatrixSpace(ZZ,Integer(10),Integer(2)**Integer(31))
      File "sage/misc/classcall_metaclass.pyx", line 330, in sage.misc.classcall_metaclass.ClasscallMetaclass.__call__ (build/cythonized/sage/misc/classcall_metaclass.c:1176)
        return cls.classcall(cls,  *args, **opts)
      File "/home/buildslave-sage/slave/sage_git/build/local/lib/python2.7/site-packages/sage/matrix/matrix_space.py", line 228, in __classcall__
        cls, base_ring, nrows, ncols, sparse, implementation)
      File "sage/misc/cachefunc.pyx", line 1298, in sage.misc.cachefunc.WeakCachedFunction.__call__ (build/cythonized/sage/misc/cachefunc.c:8050)
        w = self.f(*args, **kwds)
      File "/home/buildslave-sage/slave/sage_git/build/local/lib/python2.7/site-packages/sage/structure/unique_representation.py", line 1021, in __classcall__
        instance = typecall(cls, *args, **options)
      File "sage/misc/classcall_metaclass.pyx", line 518, in sage.misc.classcall_metaclass.typecall (build/cythonized/sage/misc/classcall_metaclass.c:1603)
        res = <object> PyType_Type.tp_call(cls, args, opts)
      File "/home/buildslave-sage/slave/sage_git/build/local/lib/python2.7/site-packages/sage/matrix/matrix_space.py", line 287, in __init__
        raise ValueError("number of rows and columns may be at most %s" % sys.maxsize)
    ValueError: number of rows and columns may be at most 2147483647
**********************************************************************
File "src/sage/matrix/matrix_space.py", line 134, in sage.matrix.matrix_space.MatrixSpace
Failed example:
    MatrixSpace(ZZ,2^31,10)
Expected:
    Traceback (most recent call last):                                   
    ...                                                                  
    ValueError: number of rows and columns must be less than 2^31 (on a 32-bit computer -- use a 64-bit computer for matrices with up to 2^63-1 rows and columns)           
Got:
    <BLANKLINE>
    Traceback (most recent call last):
      File "/home/buildslave-sage/slave/sage_git/build/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 488, in _run
        self.compile_and_execute(example, compiler, test.globs)
      File "/home/buildslave-sage/slave/sage_git/build/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 850, in compile_and_execute
        exec(compiled, globs)
      File "<doctest sage.matrix.matrix_space.MatrixSpace[3]>", line 1, in <module>
        MatrixSpace(ZZ,Integer(2)**Integer(31),Integer(10))
      File "sage/misc/classcall_metaclass.pyx", line 330, in sage.misc.classcall_metaclass.ClasscallMetaclass.__call__ (build/cythonized/sage/misc/classcall_metaclass.c:1176)
        return cls.classcall(cls,  *args, **opts)
      File "/home/buildslave-sage/slave/sage_git/build/local/lib/python2.7/site-packages/sage/matrix/matrix_space.py", line 228, in __classcall__
        cls, base_ring, nrows, ncols, sparse, implementation)
      File "sage/misc/cachefunc.pyx", line 1298, in sage.misc.cachefunc.WeakCachedFunction.__call__ (build/cythonized/sage/misc/cachefunc.c:8050)
        w = self.f(*args, **kwds)
      File "/home/buildslave-sage/slave/sage_git/build/local/lib/python2.7/site-packages/sage/structure/unique_representation.py", line 1021, in __classcall__
        instance = typecall(cls, *args, **options)
      File "sage/misc/classcall_metaclass.pyx", line 518, in sage.misc.classcall_metaclass.typecall (build/cythonized/sage/misc/classcall_metaclass.c:1603)
        res = <object> PyType_Type.tp_call(cls, args, opts)
      File "/home/buildslave-sage/slave/sage_git/build/local/lib/python2.7/site-packages/sage/matrix/matrix_space.py", line 287, in __init__
        raise ValueError("number of rows and columns may be at most %s" % sys.maxsize)
    ValueError: number of rows and columns may be at most 2147483647
**********************************************************************
1 item had failures:
   2 of   7 in sage.matrix.matrix_space.MatrixSpace
    [261 tests, 2 failures, 2.05 s]

sagetrac-git · 2015-01-29T11:54:04Z

Branch pushed to git repo; I updated commit sha1. New commits:

`92de9fc`	`Make tests 32/64-bit independent`

sagetrac-git · 2015-01-29T11:54:04Z

Changed commit from 026b281 to 92de9fc

fchapoton · 2015-02-02T16:57:19Z

comment:25

ook. Positive review again.

vbraun · 2015-02-08T15:26:19Z

Changed branch from u/jdemeyer/ticket/17460 to 92de9fc

jdemeyer added this to the sage-6.5 milestone Dec 7, 2014

jdemeyer added p: minor / 4 labels Dec 7, 2014

jdemeyer added the s: needs review label Dec 24, 2014

fchapoton added s: positive review and removed s: needs review labels Jan 19, 2015

vbraun added s: needs work and removed s: positive review labels Jan 24, 2015

jdemeyer added s: needs review and removed s: needs work labels Jan 24, 2015

fchapoton added s: positive review and removed s: needs review labels Jan 26, 2015

vbraun added s: needs work and removed s: positive review labels Jan 29, 2015

jdemeyer added s: needs review and removed s: needs work labels Jan 29, 2015

fchapoton added s: positive review and removed s: needs review labels Feb 2, 2015

vbraun removed the s: positive review label Feb 8, 2015

vbraun closed this as completed in e14b587 Feb 8, 2015

jasongrout mentioned this issue Jan 2, 2015

Upgrade sagenb #10057

Closed

jm58660 mannequin mentioned this issue Feb 18, 2015

Convert database_odlyzko_zeta to new-style package #17064

Closed

a-andre mentioned this issue Jun 2, 2015

Changing .next() to next(...) #17398

Closed

This was referenced Feb 18, 2015

Deprecate src/sage/misc/db.py #17653

Closed

Fix more load/save bugs #17654

Closed

Remove some deprecated code #21506

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Deprecate moved imports from sage.misc #17460

Deprecate moved imports from sage.misc #17460

jdemeyer commented Dec 7, 2014

jdemeyer commented Dec 8, 2014

jdemeyer commented Dec 8, 2014

sagetrac-git mannequin commented Dec 18, 2014

sagetrac-git mannequin commented Dec 18, 2014

sagetrac-git mannequin commented Dec 18, 2014

sagetrac-git mannequin commented Dec 18, 2014

sagetrac-git mannequin commented Dec 18, 2014

sagetrac-git mannequin commented Dec 18, 2014

sagetrac-git mannequin commented Dec 24, 2014

sagetrac-git mannequin commented Dec 24, 2014

jdemeyer commented Dec 24, 2014

sagetrac-git mannequin commented Jan 19, 2015

sagetrac-git mannequin commented Jan 19, 2015

jdemeyer commented Jan 19, 2015

sagetrac-git mannequin commented Jan 19, 2015

sagetrac-git mannequin commented Jan 19, 2015

jdemeyer commented Jan 19, 2015

jdemeyer commented Jan 19, 2015

sagetrac-git mannequin commented Jan 19, 2015

sagetrac-git mannequin commented Jan 19, 2015

jdemeyer commented Jan 19, 2015

fchapoton commented Jan 19, 2015

fchapoton commented Jan 19, 2015

jdemeyer commented Jan 19, 2015

vbraun commented Jan 24, 2015

sagetrac-git mannequin commented Jan 24, 2015

sagetrac-git mannequin commented Jan 24, 2015

jdemeyer commented Jan 26, 2015

fchapoton commented Jan 26, 2015

vbraun commented Jan 29, 2015

sagetrac-git mannequin commented Jan 29, 2015

sagetrac-git mannequin commented Jan 29, 2015

fchapoton commented Feb 2, 2015

vbraun commented Feb 8, 2015

Deprecate moved imports from sage.misc #17460

Deprecate moved imports from sage.misc #17460

Comments

jdemeyer commented Dec 7, 2014

jdemeyer commented Dec 8, 2014

jdemeyer commented Dec 8, 2014

sagetrac-git mannequin commented Dec 18, 2014

sagetrac-git mannequin commented Dec 18, 2014

sagetrac-git mannequin commented Dec 18, 2014

sagetrac-git mannequin commented Dec 18, 2014

sagetrac-git mannequin commented Dec 18, 2014

sagetrac-git mannequin commented Dec 18, 2014

sagetrac-git mannequin commented Dec 24, 2014

sagetrac-git mannequin commented Dec 24, 2014

jdemeyer commented Dec 24, 2014

sagetrac-git mannequin commented Jan 19, 2015

sagetrac-git mannequin commented Jan 19, 2015

jdemeyer commented Jan 19, 2015

sagetrac-git mannequin commented Jan 19, 2015

sagetrac-git mannequin commented Jan 19, 2015

jdemeyer commented Jan 19, 2015

jdemeyer commented Jan 19, 2015

sagetrac-git mannequin commented Jan 19, 2015

sagetrac-git mannequin commented Jan 19, 2015

jdemeyer commented Jan 19, 2015

fchapoton commented Jan 19, 2015

fchapoton commented Jan 19, 2015

jdemeyer commented Jan 19, 2015

vbraun commented Jan 24, 2015

sagetrac-git mannequin commented Jan 24, 2015

sagetrac-git mannequin commented Jan 24, 2015

jdemeyer commented Jan 26, 2015

fchapoton commented Jan 26, 2015

vbraun commented Jan 29, 2015

sagetrac-git mannequin commented Jan 29, 2015

sagetrac-git mannequin commented Jan 29, 2015

fchapoton commented Feb 2, 2015

vbraun commented Feb 8, 2015