Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify cythonization of sage.misc #17767

Closed
robertwb opened this issue Feb 11, 2015 · 12 comments
Closed

Simplify cythonization of sage.misc #17767

robertwb opened this issue Feb 11, 2015 · 12 comments

Comments

@robertwb
Copy link
Contributor

I'm breaking down #15410 into individual tickets in the hopes that makes it easier to review.

Component: build

Author: Robert Bradshaw

Branch: 8b0d4ba

Reviewer: Jeroen Demeyer

Issue created by migration from https://trac.sagemath.org/ticket/17767

@robertwb robertwb added this to the sage-6.5 milestone Feb 11, 2015
@robertwb
Copy link
Contributor Author

Branch: u/robertwb/17767-simplify-misc

@robertwb
Copy link
Contributor Author

Changed branch from u/robertwb/17767-simplify-misc to none

@robertwb
Copy link
Contributor Author

Branch: u/robertwb/17767-simplify-misc

@jdemeyer
Copy link

comment:4

The only minor downside is that the order of Cythonization is random, no longer in the alphabetical order specified in module_list.py.


New commits:

8b0d4baSimplify cythonization of sage.misc.

@jdemeyer
Copy link

Commit: 8b0d4ba

@jdemeyer
Copy link

Reviewer: Jeroen Demeyer

@robertwb
Copy link
Contributor Author

comment:5

Thanks for looking at these!

The order is not random, it's (1) pyx files that were modified themselves, then (2) extensions that directly depend on modified files, then (3) everything else. This lets you catch errors early. Within each subgroup things are sorted alphabetically. (That should already be happening.)

@vbraun
Copy link
Member

vbraun commented Feb 18, 2015

Changed branch from u/robertwb/17767-simplify-misc to 8b0d4ba

@sagetrac-gouezel
Copy link
Mannequin

sagetrac-gouezel mannequin commented Feb 21, 2015

comment:7

Since this commit, misc/darwin_utilities.pyx (which should only be included on Darwin, see module_list.py) is included on all platforms (and, incidentally, fails on cygwin). Should it be moved to a directory of its own?

@sagetrac-gouezel
Copy link
Mannequin

sagetrac-gouezel mannequin commented Feb 21, 2015

Changed commit from 8b0d4ba to none

@jpflori
Copy link

jpflori commented Apr 17, 2015

comment:8

I concur with sebastien (who I guess also noticed some new modules should be linked to gmp)...
Maybe we could use the skip_build thingy from #18145 to solve the darwin thing.

@sagetrac-gouezel
Copy link
Mannequin

sagetrac-gouezel mannequin commented Apr 17, 2015

comment:9

This has indeed been solved by #18145 (see also #17961).

The missing links to gmp are in #17962.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants