New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move darwin_utilities to a directory of its own #17961
Comments
comment:1
NB: the patch is untested as I don't have a Mac... |
comment:2
I would not put this inside |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:4
If you really go for a |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:7
Good idea, done. |
comment:8
I have no more comments but somebody with OS X (not me, unfortunately) should test this. |
comment:9
I think that #18145 also fixes the issue on this ticket, but in a completely different way. |
Dependencies: #18145 |
comment:10
In any case, this patch will conflict with #18145. |
comment:11
Indeed, #18145 fixes the issue, so this ticket is not needed any more. |
Since #17767, all
pyx
files insage/misc
are compiled on all platforms, due to the following line inmodules_list.py
:This is in particular the case of
sage/misc/darwin_utilities.pyx
, which should however only be included on Darwin as specified on lines 2096 and following ofmodules_list.py
:This ticket moves this file and its friends to a subdirectory of its own.
Depends on #18145
Component: porting: BSD
Author: Sebastien Gouezel
Branch/Commit: u/gouezel/darwin_subdir @
d7b5d24
Issue created by migration from https://trac.sagemath.org/ticket/17961
The text was updated successfully, but these errors were encountered: