Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move darwin_utilities to a directory of its own #17961

Closed
sagetrac-gouezel mannequin opened this issue Mar 15, 2015 · 13 comments
Closed

Move darwin_utilities to a directory of its own #17961

sagetrac-gouezel mannequin opened this issue Mar 15, 2015 · 13 comments

Comments

@sagetrac-gouezel
Copy link
Mannequin

sagetrac-gouezel mannequin commented Mar 15, 2015

Since #17767, all pyx files in sage/misc are compiled on all platforms, due to the following line in modules_list.py:

Extension('*', ['sage/misc/*.pyx'])

This is in particular the case of sage/misc/darwin_utilities.pyx, which should however only be included on Darwin as specified on lines 2096 and following of modules_list.py:

# Only include darwin_utilities on OS_X >= 10.5

This ticket moves this file and its friends to a subdirectory of its own.

Depends on #18145

Component: porting: BSD

Author: Sebastien Gouezel

Branch/Commit: u/gouezel/darwin_subdir @ d7b5d24

Issue created by migration from https://trac.sagemath.org/ticket/17961

@sagetrac-gouezel sagetrac-gouezel mannequin added this to the sage-6.6 milestone Mar 15, 2015
@sagetrac-gouezel
Copy link
Mannequin Author

sagetrac-gouezel mannequin commented Mar 15, 2015

comment:1

NB: the patch is untested as I don't have a Mac...

@jdemeyer
Copy link

comment:2

I would not put this inside misc but perhaps a new top-level directory like src/sage/platform.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 22, 2015

Branch pushed to git repo; I updated commit sha1. New commits:

41df0ec #17961: move darwin_utilities to a new sage/platforms directory

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 22, 2015

Changed commit from 7b10c3a to 41df0ec

@jdemeyer
Copy link

comment:4

If you really go for a src/sage/platforms/darwin/ directory, you can drop the darwin_ prefix on all files.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 22, 2015

Changed commit from 41df0ec to d7b5d24

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 22, 2015

Branch pushed to git repo; I updated commit sha1. New commits:

d7b5d24 #17961: shorten file names

@sagetrac-gouezel
Copy link
Mannequin Author

sagetrac-gouezel mannequin commented Mar 22, 2015

comment:7

Good idea, done.

@jdemeyer
Copy link

comment:8

I have no more comments but somebody with OS X (not me, unfortunately) should test this.

@jdemeyer
Copy link

jdemeyer commented Apr 8, 2015

comment:9

I think that #18145 also fixes the issue on this ticket, but in a completely different way.

@jdemeyer
Copy link

jdemeyer commented Apr 9, 2015

Dependencies: #18145

@jdemeyer
Copy link

jdemeyer commented Apr 9, 2015

comment:10

In any case, this patch will conflict with #18145.

@sagetrac-gouezel
Copy link
Mannequin Author

sagetrac-gouezel mannequin commented Apr 9, 2015

comment:11

Indeed, #18145 fixes the issue, so this ticket is not needed any more.

@sagetrac-gouezel sagetrac-gouezel mannequin removed this from the sage-6.6 milestone Apr 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants