Remove matrix_modn_dense.pyx

[jdemeyer]

This has been unused since #4260, remove it.

Component: linear algebra

Author: Jeroen Demeyer

Branch: 766f1a5

Reviewer: Vincent Delecroix

Issue created by migration from https://trac.sagemath.org/ticket/17837

[jdemeyer]

Author: André Apitzsch

[jdemeyer]

Branch: u/jdemeyer/ticket/17837

[jdemeyer]

comment:3

Do we even need the determinant method in the first place? Why not rely on inheritance?

---

New commits:

e768168

fix some cython warnings

[jdemeyer]

Commit: e768168

[jdemeyer]

Changed author from André Apitzsch to Jeroen Demeyer

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

74d2c66

Remove matrix_modn_dense

[sagetrac-git]

Changed commit from e768168 to 74d2c66

[sagetrac-git]

Changed commit from 74d2c66 to a6112ce

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

a6112ce

Remove matrix_modn_dense

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

766f1a5

Remove matrix_modn_dense

[sagetrac-git]

Changed commit from a6112ce to 766f1a5

[videlec]

Reviewer: Vincent Delecroix

[videlec]

comment:11

Instead of

        if not (isinstance(b, Matrix_modn_dense_float) or
                isinstance(b, Matrix_modn_dense_double)):

you might have used

        if not isinstance(b, (Matrix_modn_dense_float, Matrix_modn_dense_double)):

which is handled in the exact same way by cython.

I will try to use the nice unpickle_override for #17824.

[videlec]

comment:12

Overlaps with #10734.

[vbraun]

Changed branch from u/jdemeyer/ticket/17837 to 766f1a5

[videlec]

Changed commit from 766f1a5 to none

[videlec]

comment:14

What is this transition "needs work -> closed"!?

[jdemeyer]

comment:15

On the other hand, I don't understand why the mere existence of ticket #10734 would be a reason for needs_work.

[jdemeyer]

comment:16

Replying to @videlec:

Instead of

        if not (isinstance(b, Matrix_modn_dense_float) or
                isinstance(b, Matrix_modn_dense_double)):

you might have used

        if not isinstance(b, (Matrix_modn_dense_float, Matrix_modn_dense_double)):

which is handled in the exact same way by cython.

Obviously, I just didn't think of that. It doesn't really matter anyway...

[videlec]

comment:17

Replying to @jdemeyer:

On the other hand, I don't understand why the mere existence of ticket #10734 would be a reason for needs_work.

Because there is a large amount of work on ticket #10734 that uses matrix_modn_dense. Before throwing away this work, it would have been nice to wait for the current status of this work. I am pretty sure that everything can be achieved with the LinBox classes anyway.

[jdemeyer]

comment:18

Replying to @videlec:

Because there is a large amount of work on ticket #10734 that uses matrix_modn_dense.

But with or without #17837, matrix_modn_dense is deprecated and no longer used. So if #10734 really uses Matrix_modn_dense, it should be changed anyway.