Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify base_extend, base_extend_c, base_extend_c_impl #17889

Closed
jdemeyer opened this issue Mar 3, 2015 · 7 comments
Closed

Unify base_extend, base_extend_c, base_extend_c_impl #17889

jdemeyer opened this issue Mar 3, 2015 · 7 comments
Labels
c: cython p: major / 3 t: enhancement
Milestone
sage-6.6

Comments

@jdemeyer
Copy link

jdemeyer commented Mar 3, 2015

Replace

    cdef base_extend_c(self, Parent R):
    cdef base_extend_c_impl(self, Parent R):
    def base_extend(self, R):

by

    cpdef base_extend(self, R):

Since base_extend_c and base_extend_c_impl aren't actually used anywhere, this is trivial.

Component: cython

Author: Jeroen Demeyer

Branch/Commit: 9db1cf7

Reviewer: André Apitzsch

Issue created by migration from https://trac.sagemath.org/ticket/17889
@jdemeyer jdemeyer added this to the sage-6.6 milestone Mar 3, 2015
@jdemeyer

This comment has been minimized.

Sign in to view
@jdemeyer
Copy link
Author

jdemeyer commented Mar 3, 2015

Branch: u/jdemeyer/unify_base_extend__base_extend_c__base_extend_c_impl

@jdemeyer
Copy link
Author

jdemeyer commented Mar 3, 2015

Commit: 9db1cf7

@jdemeyer
Copy link
Author

jdemeyer commented Mar 3, 2015

New commits:

9db1cf7Remove base_extend_c and base_extend_c_impl

@a-andre
Copy link

a-andre commented Mar 3, 2015

Reviewer: André Apitzsch

@a-andre
Copy link

a-andre commented Mar 3, 2015

comment:4

Looks good to me.

@vbraun
Copy link
Member

vbraun commented Mar 5, 2015

Changed branch from u/jdemeyer/unify_base_extend__base_extend_c__base_extend_c_impl to 9db1cf7

@vbraun vbraun closed this as completed in af17243 Mar 5, 2015
@jdemeyer jdemeyer mentioned this issue Jun 4, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: cython p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-6.6
Development

No branches or pull requests
3 participants
@vbraun @jdemeyer @a-andre