Add inversion number method to AlternatingSignMatrices

[jessicapalencia]

Add inversion number method to AlternatingSignMatrices

CC: @tscrim @kevindilks @egunawan

Component: combinatorics

Keywords: asm, days64, aim

Author: Jessica Striker

Branch/Commit: 82c96d7

Reviewer: Darij Grinberg

Issue created by migration from https://trac.sagemath.org/ticket/18075

[darijgr]

comment:1

first!

[jessicapalencia]

New commits:

8827ffe

18075: added inversion number to AlternatingSignMatrices

[jessicapalencia]

Commit: 8827ffe

[jessicapalencia]

Branch: u/jessicapalencia/inversion_number-18075

[nthiery]

comment:3

Just a couple suggestions:

• Add the definition of the inversions number of an asm, typically with a reference
• Explain that for permutation matrices this matches with the usual inversion number of the permutation, with an example where this is tested for all permutations of, say, 5.
• Add a couple more examples

[nthiery]

comment:4

Thanks for your contribution to Sage :-)

[nthiery]

Work Issues: more tests and doc

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

590afd1	documentation and example added
914e0ed	Added another test

[sagetrac-git]

Changed commit from 8827ffe to 914e0ed

[darijgr]

New commits:

018f406	Merge branch 'u/jessicapalencia/inversion_number-18075' of git://trac.sagemath.org/sage into asm
c6d341a	#18075 review patch
a524fad	ticket 18075 review patch

[darijgr]

Changed commit from 914e0ed to a524fad

[darijgr]

Changed branch from u/jessicapalencia/inversion_number-18075 to public/ticket/18075

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

0a442cb

ticket 18015 review patch

[sagetrac-git]

Changed commit from a524fad to 0a442cb

[darijgr]

Changed work issues from more tests and doc to error pointed out inside branch

[darijgr]

comment:10

Ignore my previous commits, and use the one below. Thanks, and sorry.

---

New commits:

0a442cb

ticket 18015 review patch

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

82c96d7

correcting whitespace

[sagetrac-git]

Changed commit from 0a442cb to 82c96d7

[darijgr]

comment:12

Review branch uploaded.

A few remarks:

I am not 100% sure whether the letter ℓ goes against coding standards, but I have replaced it by a regular l to be safe. The docstrings are sent to latex, and I think latex doesn't like things that aren't ascii.

Also removed all the trailing whitespace.

The error in the iterator I pointed out should either be fixed here or moved to another ticket. Other than this, the ticket is good to go if you think the review changes are fine!

[darijgr]

Reviewer: Darij Grinberg

[jessicapalencia]

comment:14

Hi Darij (or Travis),

Could you please open a new ticket for the error in the iterator or else fix the error on this ticket? I don't know exactly what the error is or how to fix it. Then can we set this ticket to positive review? Thanks!

[darijgr]

comment:15

Done, #18208. Can you pos_rev this one then?

[jessicapalencia]

comment:16

Yes, thanks for reviewing it!

[tscrim]

Changed work issues from error pointed out inside branch to none

[vbraun]

Changed branch from public/ticket/18075 to 82c96d7