AlternatingSignMatrices(3, use_monotone_triangles=False) broken

[darijgr]

I have added a comment in the sourcecode in #18075, but someone actually should fix this:

(path: root/src/sage/combinat/alternating_sign_matrix.py)

    def __iter__(self):
        r"""
        Iterator on the alternating sign matrices of size `n`.

        If defined using ``use_monotone_triangles``, this iterator
        will use the iteration on the monotone triangles. Else, it
        will use the iteration on contre-tableaux.

        TESTS::

            sage: A = AlternatingSignMatrices(4)
            sage: len(list(A))
            42
        """
        if self._umt:
            for t in MonotoneTriangles(self._n):
                yield self.from_monotone_triangle(t)
        else:
            for c in ContreTableaux(self._n):
                yield from_contre_tableau(c)
                # This is broken!
                # sage: A = AlternatingSignMatrices(3, use_monotone_triangles=False)
                # sage: list(A)
                # ---------------------------------------------------------------------------
                # NameError                                 Traceback (most recent call last)
                # ...
                # NameError: global name 'from_contre_tableau' is not defined
                # If this is really obsolete, the else-branch should be
                # removed and the doc modified accordingly.

Depends on #18075

CC: @tscrim @sagetrac-sage-combinat

Component: combinatorics

Keywords: alternating sign matrix, contretableaux, tableaux, sd67

Author: Travis Scrimshaw

Branch/Commit: 25a46bd

Reviewer: Darij Grinberg

Issue created by migration from https://trac.sagemath.org/ticket/18208

[tscrim]

Commit: 4effeae

[tscrim]

Branch: public/combinat/ASM_iter-18208

[tscrim]

comment:1

I deprecated the use_monotone_triangles input to the class, but I also reimplemented the from_contre_tableau as a method of the ASM parent class in case one wants to do that construction.

---

New commits:

8827ffe	18075: added inversion number to AlternatingSignMatrices
590afd1	documentation and example added
914e0ed	Added another test
018f406	Merge branch 'u/jessicapalencia/inversion_number-18075' of git://trac.sagemath.org/sage into asm
0a442cb	ticket 18015 review patch
82c96d7	correcting whitespace
d71c391	Merge branch 'public/ticket/18075' of trac.sagemath.org:sage into public/combinat/ASM_iter-18208
4effeae	Deprecating the old iterator but bringing back the contruction as a method.

[tscrim]

Changed keywords from alternating sign matrix, contretableaux, tableaux to alternating sign matrix, contretableaux, tableaux, sd67

[tscrim]

Author: Travis Scrimshaw

[tscrim]

Dependencies: #18075

[sagetrac-git]

Changed commit from 4effeae to 25a46bd

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

42e505e	do not use pip to install mistune
87b596a	Merge branch 'public/combinat/ASM_iter-18208' of git://trac.sagemath.org/sage into asm2
5cc4779	remove obsolete doc
25a46bd	some cleanup

[tscrim]

Reviewer: Darij Grinberg

[tscrim]

comment:4

LGTM.

[darijgr]

comment:5

Thanks Travis!

[vbraun]

Changed branch from public/combinat/ASM_iter-18208 to 25a46bd