-
-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CategoryObject: never cache gens_dict #18361
Comments
This comment has been minimized.
This comment has been minimized.
New commits:
|
Commit: |
comment:4
The patchbot complains about the usual example involving |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:6
Thanks. The patchbot is (temporarily) down, so I cannot see if there are other failures. |
comment:7
The class Vincent |
comment:8
Replying to @videlec:
Then why is there a It makes absolutely no sense to have a method on class If you prefer, I can move the whole |
comment:9
Replying to @jdemeyer:
This is indeed the problem!
Yes please. I found that doing what you proposed is just worse in the direction of cleaning |
comment:10
Replying to @jdemeyer:
That doesn't work:
|
comment:11
Replying to @videlec:
On the other hand, does it really hurt to have this extra attribute? We already have these attributes on
The point is: And my proposed patch is actually compatible with the deprecation of |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:13
Let me remind that this ticket is not about the proper place to put the |
comment:14
Would you prefer to remove the caching completely in |
comment:15
Replying to @jdemeyer:
+1 to me. Building a dictionary is very fast. I had a quick look through the source code. And no functions relies on it for critical computations (mostly it is to build a polynomial from a string). Note that the fastest way I found to allocate a dictionary is through Could you also remove the custom implementation in
Vincent |
Reviewer: Vincent Delecroix |
comment:17
Replying to @videlec:
No, I disagree. The reason is that the |
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
|
This comment has been minimized.
This comment has been minimized.
Changed branch from u/jdemeyer/categoryobject__always_cache_gens_dict to |
The
cdef class CategoryObject
has this strange method:which provides caching only for Python subclasses. It turns out that caching this doesn't really matter since
gens_dict()
is not used in critical code, so we can just remove the funny "caching".Component: categories
Author: Jeroen Demeyer
Branch/Commit:
1c26046
Reviewer: Vincent Delecroix
Issue created by migration from https://trac.sagemath.org/ticket/18361
The text was updated successfully, but these errors were encountered: