Make new-style packages define their type and dependencies

[nathanncohen]

With this branch, it is not necssary anymore to copy/paste a package's name in four different places in order to make it standard.

This is done by adding two files in each folder:

• 'type': can contain either 'base', 'standard', 'optional', or 'experimental'
• 'dependencies': lists the dependencies of a package in "Make" notation.

I regret not having been able to make the 'dependencies' files clearer (they are a copy of the target dependencies form the Makefiles). Making it more human-readable is complicated, as we have to handle the "|" Make character (for order-only-prerequisite). Also, some standard packages depend on targets with are not packages themselves (i.e. prereq).

The commit are split in order to ease the review.

Nathann

CC: @vbraun

Component: build

Author: Nathann Cohen, Jeroen Demeyer

Branch/Commit: f83b0c4

Reviewer: Volker Braun, Jeroen Demeyer, Nathann Cohen

Issue created by migration from https://trac.sagemath.org/ticket/18431

[nathanncohen]

Branch: u/ncohen/18341

[sagetrac-git]

Commit: 77f293f

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

da192bf	trac #18431: match var/pkg names (CONWAY->CONWAY_POLYNOMIALS)
3ff942a	trac #18431: match var/pkg names (FFLASFFPACK->FFLAS_FFPACK)
8f7dbe3	trac #18431: match var/pkg names (fplll->libfplll)
e1663b5	trac #18431: match var/pkg names (gd->libgd)
0928117	trac #18431: match var/pkg names (rpy -> rpy2)
fbe2a87	trac #18431: match var/pkg names (znpoly -> zn_poly)
4770518	trac #18431: Type file for each package+define var from pkg name
3efc9fb	trac #18431: package-specific 'dependencies' files
308ceff	trac #18431: Auto-generate make rules for standard packages
77f293f	trac #18431: auto-generated Make target "sage-standard-packages"

[a-andre]

comment:3

In build/pkgs/conway_polynomials/dependencies

CONWAY_POLYNOMIALS depends on depends on ...

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

e114874

trac #18431: typo

[sagetrac-git]

Changed commit from 77f293f to e114874

[vbraun]

comment:6

Can you replace the tabs by spaces in build/install. Apart from that, lgtm.

[vbraun]

Reviewer: Volker Braun

[sagetrac-git]

Changed commit from e114874 to 766798e

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

766798e

trac #18431: tab->spaces

[nathanncohen]

comment:9

Thanks !

Nathann

[vbraun]

Changed branch from u/ncohen/18341 to 766798e

[vbraun]

Changed commit from 766798e to none

[vbraun]

comment:11

PATCH is not defined in build/Makefile, so rebuilds from scratch fail

[jdemeyer]

Changed reviewer from Volker Braun to Volker Braun, Jeroen Demeyer, Nathann Cohen

[jdemeyer]

Last 10 new commits:

fbe2a87	trac #18431: match var/pkg names (znpoly -> zn_poly)
4770518	trac #18431: Type file for each package+define var from pkg name
3efc9fb	trac #18431: package-specific 'dependencies' files
308ceff	trac #18431: Auto-generate make rules for standard packages
77f293f	trac #18431: auto-generated Make target "sage-standard-packages"
e114874	trac #18431: typo
766798e	trac #18431: tab->spaces
47e438d	Merge tag '6.7' into t/18441/base_packages_except_configure_should_be_standard
4de8e37	Various changes to build system
f83b0c4	Correct variable name

[jdemeyer]

Changed branch from 766798e to u/jdemeyer/base_packages_except_configure_should_be_standard

[jdemeyer]

Commit: f83b0c4

[jdemeyer]

Changed author from Nathann Cohen to Nathann Cohen, Jeroen Demeyer

[jdemeyer]

comment:14

I made this ticket the union of #18431 and #18441, both positively reviewed.

[vbraun]

comment:15

So what am I supposed to merge? can you fix dependencies and milestones?

[nathanncohen]

comment:16

I made this ticket the union of #18431 and #18441, both positively reviewed.

Why on earth did you di that? O_o

The two were reviewed, the two would have been merged together O_o

[jdemeyer]

comment:17

Replying to @vbraun:

So what am I supposed to merge?

The branch on this ticket (which was formerly the branch of #18441 and which includes the commits of #18431).

can you fix dependencies and milestones?

Well, there is no sage-6.8 milestone but apart from that, it should be correct as-is.

[jdemeyer]

comment:18

Replying to @nathanncohen:

I made this ticket the union of #18431 and #18441, both positively reviewed.

Why on earth did you di that? O_o

Well, I didn't know the release manager's opinion on forcing tickets to be merged together and I didn't want to risk rejection.

[vbraun]

Changed branch from u/jdemeyer/base_packages_except_configure_should_be_standard to f83b0c4