New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unneeded BLAS linking for Cython modules #18777
Comments
This comment has been minimized.
This comment has been minimized.
New commits:
|
Commit: |
comment:4
OK I will check all of these with |
Reviewer: François Bissey |
comment:5
All these only link to |
Changed branch from u/jdemeyer/remove_unneeded_blas_linking_for_cython_modules to |
Various Cython modules implementing matrices and vectors list
in
src/module_list.py
.However, nothing in Sage directly uses BLAS, it is only used through external libraries (linbox, numpy, ...). So it makes no sense to link to BLAS and nothing else, which means that this is a mistake.
I checked the commit history and these extensions listing only
BLAS, BLAS2
as libraries go back to #3498 and #4206:and
It seems that the backends were changed from GSL to Numpy and I guess that the BLAS libraries (needed for GSL) were simply kept.
There might also be the mistaken assumption that BLAS was needed for numpy. It's true that numpy uses BLAS, but we use numpy using the standard Python
import
mechanism, it's not the usual dynamic linking (there is no-lnumpy
argument needed either).CC: @jasongrout @kiwifb @jpflori
Component: build
Author: Jeroen Demeyer
Branch/Commit:
be582ec
Reviewer: François Bissey
Issue created by migration from https://trac.sagemath.org/ticket/18777
The text was updated successfully, but these errors were encountered: