Python 3 preparation: Iterator protocol uses .next() in Py2 but __next__() in Py3

[wluebbe]

When defining a custom iterator one has to define a method that returns the next item. In Python 3 this method is called next() while in Python 3 this is the special method __next__().

More information can be found in http://python-future.org/compatible_idioms.html#custom-iterators and http://python-future.org/what_else.html#custom-iterators.

Remark: To advance some iterator it in Py2 often this method is called directly it.next().
But since Python 2.6 there is the builtin function next() which is compatible between Py2 and Py3: in Py2 it calls the iterator method next() while in Py3 it calls the special method __next__().
Ticket #16075 addresses the (stage 1) conversion from it.next() to next(it).

This ticket is tracked as a dependency of meta-ticket #16052.

Component: python3

Author: André Apitzsch

Branch/Commit: 840f968

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/18802

[a-andre]

Branch: u/aapitzsch/18802

[a-andre]

Author: André Apitzsch

[a-andre]

Commit: 840f968

[a-andre]

New commits:

840f968

rename next() to __next__() and keep next() as alias

[fchapoton]

comment:5

Are you sure that all these things are really iterators ?

[a-andre]

comment:6

Replying to @fchapoton:

Are you sure that all these things are really iterators ?

Yes.

[fchapoton]

comment:7

I do not quite agree with that. The next methods in permutation and partition are not really iterators (they are implemented on elements, not on a set, and they return False when they cannot return something), and should in fact not be called using next(p) but rather as a method p.next(). Of course, it may be convenient to use next(p) as a shortcut, but this is not the usual semantics of iterators, so I would rather deprecate that.

[fchapoton]

Reviewer: Frédéric Chapoton

[fchapoton]

comment:8

ok, let us do that, despite the fact that some are not really iterators.

[vbraun]

Changed branch from u/aapitzsch/18802 to 840f968