Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve assumption documentation and doctest recent improvements #19035

Closed
rwst opened this issue Aug 15, 2015 · 18 comments
Closed

Improve assumption documentation and doctest recent improvements #19035

rwst opened this issue Aug 15, 2015 · 18 comments

Comments

@rwst
Copy link

rwst commented Aug 15, 2015

With pynac-0.5 this will no longer give wrong results:

sage: assume(x,'integer')
sage: x.is_integer()
False

sage: assume(x>0)
sage: x.is_positive()
False

sage: f=function('f')(x)
sage: assume(f>0)
sage: f.is_positive()
False

Depends on #19312

Component: symbolics

Author: Ralf Stephan

Branch/Commit: 3f00cf9

Reviewer: Vincent Delecroix

Issue created by migration from https://trac.sagemath.org/ticket/19035

@rwst rwst added this to the sage-6.9 milestone Aug 15, 2015
@rwst
Copy link
Author

rwst commented Aug 15, 2015

@rwst
Copy link
Author

rwst commented Aug 17, 2015

comment:2

Example working with current Pynac master:

sage: assume(x>0)
sage: x.is_real()
True
sage: x.is_positive()
True
sage: forget(x>0)
sage: x.is_positive()
False
sage: x.is_real()
False
sage: assume(x,"real")
sage: x.is_real()
True
sage: x.is_positive()
False

New commits:

ee7068819035: sync elementary assumptions on symbols/functions with Pynac

@rwst
Copy link
Author

rwst commented Aug 17, 2015

Commit: ee70688

@rwst
Copy link
Author

rwst commented Aug 17, 2015

Dependencies: pynac-0.4.4

@rwst
Copy link
Author

rwst commented Oct 19, 2015

Changed commit from ee70688 to none

@rwst

This comment has been minimized.

@rwst
Copy link
Author

rwst commented Oct 19, 2015

Changed dependencies from pynac-0.4.4 to #19312

@rwst
Copy link
Author

rwst commented Oct 19, 2015

Changed branch from u/rws/sync_elementary_assumptions_on_symbols_functions_with_pynac to none

@rwst rwst changed the title sync elementary assumptions on symbols/functions with Pynac doctest syncing of elementary assumptions on symbols/functions with Pynac Oct 19, 2015
@rwst rwst modified the milestones: sage-6.9, sage-6.10 Oct 19, 2015
@rwst
Copy link
Author

rwst commented Dec 5, 2015

@rwst
Copy link
Author

rwst commented Dec 5, 2015

New commits:

b198a3f19035: document syncing of generic assumptions on symbols/functions with Pynac

@rwst

This comment has been minimized.

@rwst
Copy link
Author

rwst commented Dec 5, 2015

Commit: b198a3f

@rwst rwst changed the title doctest syncing of elementary assumptions on symbols/functions with Pynac Improve assumption documentation and doctest recent improvements Dec 5, 2015
@rwst rwst added t: enhancement and removed t: bug labels Dec 5, 2015
@videlec
Copy link
Contributor

videlec commented Dec 6, 2015

Reviewer: Vincent Delecroix

@videlec
Copy link
Contributor

videlec commented Dec 6, 2015

comment:6

I guess :meth:`assume` should be :func:`assume`. And similarly :meth:`forget()`.

In the complex plain do you mean the complex plane?

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 7, 2015

Branch pushed to git repo; I updated commit sha1. New commits:

3f00cf9fix typos

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 7, 2015

Changed commit from b198a3f to 3f00cf9

@rwst
Copy link
Author

rwst commented Dec 7, 2015

comment:8

Valid complaint.

@vbraun
Copy link
Member

vbraun commented Dec 9, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants