Update to pynac-0.5.2 #19312

rwst · 2015-09-29T13:28:19Z

The next big Pynac update has:

libgmp bigints and bigrats instead of Integer and Rational Python objects
assumptions/domains can influence Pynac computation
sync elementary assumptions on symbols/functions with Pynac (Improve assumption documentation and doctest recent improvements #19035)
C++11 results in better code readability
better decisions through more info flags and logic
return not implemented and undecidable for some decisions (for math. logic changes see the rewrite Expression.__nonzero__() #19040 description)
add inexact flag for possible expansions / FP simplifications
abs() expansion
function::info()
from GiNaC: Fix pow(+(...),2).expand()
remove some unused files and other cleanup; add missing autoconf macro;
some older memleaks closed

https://github.com/pynac/pynac/releases/download/pynac-0.5.2/pynac-0.5.2.tar.bz2

Depends on #19606

Component: packages: standard

Author: Ralf Stephan

Branch/Commit: bdda35e

Reviewer: Jeroen Demeyer, Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/19312

The text was updated successfully, but these errors were encountered:

rwst · 2015-09-29T13:31:20Z

Dependencies: #19298

rwst · 2015-09-29T13:33:12Z

comment:2

Mind you, it's not here yet. Git master has half a dozen small but difficult to trace bugs.

rwst · 2015-10-16T15:37:18Z

Branch: u/rws/19312-1

rwst · 2015-10-16T15:46:16Z

comment:4

This works and can be reviewed independently on machines with gcc>=4.6, but please wait with setting positive for the build system changes (i.e., #19298).

There are two failing doctests: one only happens on doctesting and needs the associated environment; the other is the "pi in RIF" doctest which presented a philosophical problem to Sage developers (see #17984) and thus cannot be resolved in my lifetime.

New commits:

`281541d`	`package version and checksum`
`e56e779`	`C++11 compile switches`
`474fff6`	`19312: pynac/Sage interface adaptations`
`5b51215`	`19312: link assume/forget to pynac`
`626fb47`	`19312: core of math logic rewrite of Expression.__nonzero__(), dedicated is_zero`
`9b8a09e`	`19312: code changes in consequence of ex.__nonzero__() math logic changes`
`361e3d8`	`19312: doc/doctest changes in consequence of math. logic changes`
`8421ab9`	`19312: other doc/doctest changes because of pynac changes`

rwst · 2015-10-16T15:46:16Z

Commit: 8421ab9

rwst · 2015-10-16T15:51:40Z

Author: Ralf Stephan

jdemeyer · 2015-10-16T18:28:03Z

comment:8

sage -t src/sage/plot/arc.py
**********************************************************************
File "src/sage/plot/arc.py", line 66, in sage.plot.arc.Arc.__init__
Failed example:
    bool(A[0].angle == pi/4)
Expected:
    True
Got:
    False
**********************************************************************
File "src/sage/plot/arc.py", line 70, in sage.plot.arc.Arc.__init__
Failed example:
    bool(A[0].s2 == pi)
Expected:
    True
Got:
    False
**********************************************************************
1 item had failures:
   2 of  12 in sage.plot.arc.Arc.__init__
    [47 tests, 2 failures, 2.28 s]
sage -t src/sage/structure/parent.pyx
**********************************************************************
File "src/sage/structure/parent.pyx", line 1227, in sage.structure.parent.Parent.__contains__
Failed example:
    pi in RIF # there is no element of RIF equal to pi
Expected:
    False
Got:
    True
**********************************************************************

sagetrac-git · 2015-10-17T14:19:02Z

Changed commit from 8421ab9 to 4784254

sagetrac-git · 2015-10-17T14:19:02Z

Branch pushed to git repo; I updated commit sha1. New commits:

`4784254`	`19312: fix omission, doctest`

rwst · 2015-10-17T14:53:02Z

comment:11

I agree to try first a merge of #19040 to reduce the size of this patch.

jdemeyer · 2015-10-17T15:19:32Z

comment:12

Replying to @rwst:

I agree to try first a merge of #19040 to reduce the size of this patch.

The other way around seems more logical to me: first merge this, then #19040.

rwst · 2015-10-19T09:05:21Z

Changed branch from u/rws/19312-1 to u/rws/19312-2

rwst · 2015-10-19T09:06:33Z

comment:14

I excised the math logic changes. Please review.

New commits:

`3a48446`	`19312: package version and checksum`
`cc6a6c9`	`19312: C++11 compile switches`
`caa0aeb`	`19312: pynac/Sage interface adaptations`
`a973071`	`19312: link assume/forget to pynac`
`6cf8edb`	`19312: changes in Expression.__nonzero__ due to Pynac interface change`
`d340d9d`	`19312: doctest adaptations`
`fd68fd5`	`19312: fix code for failing doctest`
`eeedddc`	19312: kludge to allow unchanged `__nonzero__` with pynac-0.5

rwst · 2015-10-19T09:06:33Z

Changed commit from 4784254 to eeedddc

sagetrac-git · 2015-11-28T08:59:50Z

Changed commit from af71087 to 6c27be1

tscrim · 2015-11-29T03:40:45Z

comment:63

There still is

e^{\sqrt{x}}^{x}

in functions/log.py.

Also, for the test in hyperbolic_isometry.py, if we add

sage: assume(a*d != b*c)

then would that avoid issues with #19040?

Other than that, I'm okay with the current state up to Jeroen's comments that haven't been addressed.

sagetrac-git · 2015-11-29T07:32:57Z

Branch pushed to git repo; I updated commit sha1. New commits:

`7722756`	`19312: fix doctest`

sagetrac-git · 2015-11-29T07:32:57Z

Changed commit from 6c27be1 to 7722756

rwst · 2015-11-29T07:33:39Z

comment:65

Replying to @tscrim:

Also, for the test in hyperbolic_isometry.py, if we add
sage: assume(a*d != b*c)
then would that avoid issues with #19040?

I'm unable to answer this at the moment but I appreciate the idea. Thanks for your review.

jdemeyer · 2015-11-29T13:49:13Z

comment:66

Regarding #19606: Is pynac now linked with gmp? If so, you need to revert #19606 and you need to change the dependencies of the package.

I have no other comments (which doesn't mean that I understand every change you made, but at least I don't see any obvious problems).

sagetrac-git · 2015-11-30T15:21:24Z

Branch pushed to git repo; I updated commit sha1. New commits:

`f71e3d8`	`19312: add new pynac dependencies`

sagetrac-git · 2015-11-30T15:21:24Z

Changed commit from 7722756 to f71e3d8

rwst · 2015-11-30T15:22:18Z

comment:69

Indeed, thanks.

tscrim · 2015-12-01T19:54:11Z

comment:70

I think then we are good to go.

vbraun · 2015-12-02T23:53:02Z

comment:71

32-bit fails with

sage -t --long src/sage/symbolic/expression.pyx
**********************************************************************
File "src/sage/symbolic/expression.pyx", line 1455, in sage.symbolic.expression.Expression.__hash__
Failed example:
    hash(SR(19.23))
Expected:
    2836855582
Got:
    -1458111714
**********************************************************************
File "src/sage/symbolic/expression.pyx", line 1457, in sage.symbolic.expression.Expression.__hash__
Failed example:
    hash(19.23)
Expected:
    2836855582
Got:
    -1458111714
**********************************************************************
1 item had failures:
   2 of  26 in sage.symbolic.expression.Expression.__hash__

sagetrac-git · 2015-12-03T08:54:10Z

Changed commit from f71e3d8 to bdda35e

sagetrac-git · 2015-12-03T08:54:10Z

Branch pushed to git repo; I updated commit sha1. New commits:

`bdda35e`	`19312: differentiate doctest result wrt 32/64 bit`

vbraun · 2015-12-03T23:23:19Z

Changed branch from u/rws/19312-2 to bdda35e

rwst added this to the sage-6.9 milestone Sep 29, 2015

rwst added c: packages: standard labels Sep 29, 2015

This comment has been minimized.

Sign in to view

rwst added the s: needs review label Oct 16, 2015

rwst modified the milestones: sage-6.9, sage-6.10 Oct 16, 2015

This comment has been minimized.

Sign in to view

jdemeyer added s: needs work and removed s: needs review labels Oct 16, 2015

rwst added s: needs review and removed s: needs work labels Oct 17, 2015

This comment has been minimized.

Sign in to view

jdemeyer added s: needs info and removed s: needs review labels Nov 29, 2015

rwst added s: needs review and removed s: needs info labels Nov 30, 2015

tscrim added s: positive review and removed s: needs review labels Dec 1, 2015

vbraun added s: needs work and removed s: positive review labels Dec 2, 2015

rwst added s: needs review and removed s: needs work labels Dec 3, 2015

vbraun added s: positive review and removed s: needs review labels Dec 3, 2015

vbraun removed the s: positive review label Dec 3, 2015

vbraun closed this as completed in 81a80a8 Dec 3, 2015

This was referenced Dec 9, 2015

Improve assumption documentation and doctest recent improvements #19035

Closed

Require C++11 in Sage #19298

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update to pynac-0.5.2 #19312

Update to pynac-0.5.2 #19312

rwst commented Sep 29, 2015

rwst commented Sep 29, 2015

rwst commented Sep 29, 2015

This comment has been minimized.

rwst commented Oct 16, 2015

rwst commented Oct 16, 2015

This comment has been minimized.

rwst commented Oct 16, 2015

rwst commented Oct 16, 2015

This comment has been minimized.

This comment has been minimized.

jdemeyer commented Oct 16, 2015

sagetrac-git mannequin commented Oct 17, 2015

sagetrac-git mannequin commented Oct 17, 2015

rwst commented Oct 17, 2015

jdemeyer commented Oct 17, 2015

rwst commented Oct 19, 2015

rwst commented Oct 19, 2015

rwst commented Oct 19, 2015

This comment has been minimized.

sagetrac-git mannequin commented Nov 28, 2015

tscrim commented Nov 29, 2015

sagetrac-git mannequin commented Nov 29, 2015

sagetrac-git mannequin commented Nov 29, 2015

rwst commented Nov 29, 2015

jdemeyer commented Nov 29, 2015

sagetrac-git mannequin commented Nov 30, 2015

sagetrac-git mannequin commented Nov 30, 2015

rwst commented Nov 30, 2015

tscrim commented Dec 1, 2015

vbraun commented Dec 2, 2015

sagetrac-git mannequin commented Dec 3, 2015

sagetrac-git mannequin commented Dec 3, 2015

vbraun commented Dec 3, 2015

Update to pynac-0.5.2 #19312

Update to pynac-0.5.2 #19312

Comments

rwst commented Sep 29, 2015

rwst commented Sep 29, 2015

rwst commented Sep 29, 2015

This comment has been minimized.

rwst commented Oct 16, 2015

rwst commented Oct 16, 2015

This comment has been minimized.

rwst commented Oct 16, 2015

rwst commented Oct 16, 2015

This comment has been minimized.

This comment has been minimized.

jdemeyer commented Oct 16, 2015

sagetrac-git mannequin commented Oct 17, 2015

sagetrac-git mannequin commented Oct 17, 2015

rwst commented Oct 17, 2015

jdemeyer commented Oct 17, 2015

rwst commented Oct 19, 2015

rwst commented Oct 19, 2015

rwst commented Oct 19, 2015

This comment has been minimized.

sagetrac-git mannequin commented Nov 28, 2015

tscrim commented Nov 29, 2015

sagetrac-git mannequin commented Nov 29, 2015

sagetrac-git mannequin commented Nov 29, 2015

rwst commented Nov 29, 2015

jdemeyer commented Nov 29, 2015

sagetrac-git mannequin commented Nov 30, 2015

sagetrac-git mannequin commented Nov 30, 2015

rwst commented Nov 30, 2015

tscrim commented Dec 1, 2015

vbraun commented Dec 2, 2015

sagetrac-git mannequin commented Dec 3, 2015

sagetrac-git mannequin commented Dec 3, 2015

vbraun commented Dec 3, 2015