AsymptoticRing: an_element #19048

dkrenn · 2015-08-17T19:33:59Z

Implement .an_element and .some_elements.

See also meta-ticket #17601.

Depends on #17716
Depends on #19047
Depends on #19068
Depends on #19319

CC: @behackl

Component: asymptotic expansions

Author: Daniel Krenn

Branch/Commit: 617c593

Reviewer: Benjamin Hackl, Clemens Heuberger

Issue created by migration from https://trac.sagemath.org/ticket/19048

The text was updated successfully, but these errors were encountered:

dkrenn · 2015-08-17T19:35:15Z

Branch: u/dkrenn/asy/an_element

dkrenn · 2015-08-17T19:35:46Z

Author: Daniel Krenn

dkrenn · 2015-08-17T19:35:46Z

Last 10 new commits:

`fbd6c93`	`implement QQ.some_elements()`
`c486e99`	`Merge branch 'rings/QQ-some-elements' into asy/an_element`
`0a13882`	`improve doctests of _an_element_`
`0f7412a`	`some_elements for growth groups`
`57d1720`	`product_diagonal iterator`
`fc20bf8`	`improve doctest of term.an_element`
`2ab534b`	`some_elements for terms`
`3e71113`	`_an_element_ and some_elements for asymptotic rings`
`43fd06d`	`delete stop-option from some_elements`
`4f294ce`	`improve product_diagonal so that input is read only when needed`

dkrenn · 2015-08-17T19:35:46Z

Commit: 4f294ce

behackl · 2015-08-17T20:48:32Z

comment:4

I've reviewed your changes, merged the latest asy/asymptoticExpression into this branch and applied a tiny reviewer's patch (somehow, 'exact was pasted where it definitely should not). In principal, everything looks good to me and the doctests pass.

However, do you think that asymptotic_term.py really is the best place for the product_diagonal function? I do understand that it is required as a helper function there -- but nevertheless, from my point of view, the function is sufficiently general so that it could also live, for example, in src/sage/misc/misc.py.

What do you think?

Last 10 new commits:

`43fd06d`	`delete stop-option from some_elements`
`4f294ce`	`improve product_diagonal so that input is read only when needed`
`186ecfc`	`simplified doctests: removed some unneccessary imports`
`aa4c647`	`Merge branch 'u/dkrenn/asy/asymptoticExpression' into asy/asymptoticExpression`
`5911564`	`typo fixed and line break introduced`
`7aa3e60`	`QQ` --> `\mathbb{Q}`
`3e2a7b3`	`typo fixed`
`f118772`	`some SEEALSO-blocks added`
`9354773`	`Merge branch 'asy/asymptoticExpression' into asy/an_element`
`9c1fc0e`	`cleanup documentation: strange 'exact removed`

behackl · 2015-08-17T20:48:32Z

Reviewer: Benjamin Hackl

behackl · 2015-08-17T20:48:32Z

Changed branch from u/dkrenn/asy/an_element to u/behackl/asy/an_element

behackl · 2015-08-17T20:48:32Z

Changed commit from 4f294ce to 9c1fc0e

dkrenn · 2015-08-21T11:11:30Z

Changed branch from u/behackl/asy/an_element to u/dkrenn/asy/an_element

dkrenn · 2015-08-21T11:13:27Z

Changed commit from 9c1fc0e to 3a44a01

dkrenn · 2015-08-21T11:13:27Z

comment:6

Replying to @behackl:

I've reviewed your changes, merged the latest asy/asymptoticExpression into this branch and applied a tiny reviewer's patch (somehow, 'exact was pasted where it definitely should not). In principal, everything looks good to me and the doctests pass.

Thanks.

However, do you think that asymptotic_term.py really is the best place for the product_diagonal function? I do understand that it is required as a helper function there -- but nevertheless, from my point of view, the function is sufficiently general so that it could also live, for example, in src/sage/misc/misc.py.

I would keep it here, as it is needed (at the moment) only here.

Last 10 new commits:

`6d01815`	`Merge branch 'asy/asymptoticTerm' into asy/asymptoticExpression`
`f6c4d80`	`doctests fixed`
`c7afc80`	`building documentation fixed`
`9305ca5`	`add . after seealso-lists`
`50d7166`	`\mathbb{Q} --> \QQ`
`2f8146d`	`doctests: add growth_group= and coefficient_ring= to AsymptoticRing(...) generation`
`6456300`	`minor rewording in docstring`
`4e7b080`	`Merge branch 'u/dkrenn/asy/asymptoticExpression' into asy/asymptoticExpression and fixed some merge conflicts`
`ae47bcb`	`Merge remote-tracking branch 'origin/u/behackl/asy/asymptoticExpression' into t/19048/asy/an_element`
`3a44a01`	`fix imports to make doctests pass`

sagetrac-git · 2015-09-09T15:23:02Z

Branch pushed to git repo; I updated commit sha1. New commits:

`7b8c1a0`	`fixed a conversion issue for terms with coefficient`
`83f74d3`	`Merge branch 'asy/asymptoticTerm' into asy/asymptoticExpression`
`1c81c12`	`language oddities fixed`
`032d8b8`	`Merge branch 'asy/growthGroup' into asy/growthGroup-factory`
`3a05be7`	`Merge tag '6.9.beta5' into t/17600/asy/growthGroup`
`58f931d`	`add asymptotic_expansions index`
`9d6f2da`	`Merge branch 't/17600/asy/growthGroup' into t/18930/asy/growthGroup-factory`
`6da5ade`	`Merge branch 't/18930/asy/growthGroup-factory' into t/17715/asy/asymptoticTerm`
`2c1c39d`	`Merge branch 't/17715/asy/asymptoticTerm' into t/17716/asy/asymptoticExpression`
`1108cfc`	`Merge branch 't/17716/asy/asymptoticExpression' into t/19048/asy/an_element`

sagetrac-git · 2015-09-09T15:23:02Z

Changed commit from 3a44a01 to 1108cfc

dkrenn · 2015-09-09T15:23:25Z

comment:9

Merged 6.9.beta5

sagetrac-git · 2015-09-16T07:12:53Z

Branch pushed to git repo; I updated commit sha1. New commits:

`e9ed005`	`fix docstring (:: instead of :)`

sagetrac-git · 2015-09-16T07:12:53Z

Changed commit from 1108cfc to e9ed005

behackl · 2015-09-23T10:43:24Z

Changed branch from u/dkrenn/asy/an_element to u/behackl/asy/an_element

behackl · 2015-09-23T10:43:24Z

comment:12

Merged positively reviewed dependencies into this branch and fixed a simple conflict.

Last 10 new commits:

`17e921f`	`remove sorted_set_by_tuple`
`7af4b6b`	`remove reverse keyword from shells`
`a49a20d`	`add comment in code to make it clear what happens`
`89b8209`	`change left/right to self/other`
`1d52f6c`	`add a note to the set operations methods`
`3b3b2fb`	`object --> SageObject`
`572a95d`	`Merge branch 'asy/mutable-poset' into asy/asymptoticExpression`
`5f54aec`	`explicitly forbid coercion from MutablePoset into the AsymptoticRing`
`4def011`	`Merge branch 'asy/asymptoticExpression' into asy/an_element`
`7bc65a7`	`base_ring --> base_ring()`

behackl · 2015-09-23T10:43:24Z

Changed commit from e9ed005 to 7bc65a7

cheuberg · 2015-09-29T16:00:41Z

Changed reviewer from Benjamin Hackl to Benjamin Hackl, Clemens Heuberger

cheuberg · 2015-09-29T16:00:41Z

comment:13

Perhaps the name product_diagonal could be changed to refer to the Cantor pairing function?

There is a module on multidimensional enumeration, but apparently, it only deals with finite iterators.

dkrenn · 2015-09-30T12:06:37Z

comment:14

Replying to @cheuberg:

Perhaps the name product_diagonal could be changed to refer to the Cantor pairing function?

There is a module on multidimensional enumeration, but apparently, it only deals with finite iterators.

follow up #19319 (is now a dependency of this ticket).

cheuberg · 2015-09-30T14:57:15Z

comment:18

Doctests pass on 6.9.beta5. On 6.9.rc0, they do not (cf. patchbot). After merging all dependencies into 6.9.rc0, there is still one failing doctest:

sage -t src/sage/rings/asymptotic/asymptotic_ring.py
**********************************************************************
File "src/sage/rings/asymptotic/asymptotic_ring.py", line 655, in sage.rings.asymptotic.asymptotic_ring.AsymptoticExpression.__pow__
Failed example:
    (y^2+O(y))^(-2)
Expected:
    Traceback (most recent call last):
    ...
    TypeError: unsupported operand parent(s) for '/':
    'Asymptotic Ring <y^ZZ> over Integer Ring' and 'Asymptotic
    Ring <y^ZZ> over Integer Ring'
Got:
    <BLANKLINE>
    Traceback (most recent call last):
    ...
    CoercionException: Infinite loop in action of Integer Ring (parent <type 'sage.rings.integer_ring.IntegerRing_class'>) and Asymptotic Ring <y^ZZ> over Integer Ring (parent <class 'sage.rings.asymptotic.asymptotic_ring.AsymptoticRing_with_category'>)!

cheuberg · 2015-09-30T15:02:54Z

comment:19

Merging #19068 would solve the problem, but perhaps you could have a look whether there is some deeper problem before.

sagetrac-git · 2015-10-01T06:37:11Z

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

`abb08ff`	`improve _element_constructor_`
`78b9e96`	`Trac #17716: additional doctest`
`055e35b`	`Trac #17716: Fix ReSt error`
`e8e2501`	`make entry in reference/index`
`e81d77d`	`Merge branch 'u/dkrenn/asy/asymptoticExpression' of trac.sagemath.org:sage into t/19048/asy/an_element`
`9a77311`	`deal with product(empty, infinite)`
`70185c3`	`remove unneccesary try/except block`
`d4dec2b`	`Trac #19319: alternative implementation`
`fde8e6d`	`minor changes to code: spacings, PEP8, remove comment`
`f0b1172`	`Merge branch 'u/dkrenn/product_cantor_pairing' of trac.sagemath.org:sage into t/19048/asy/an_element`

sagetrac-git · 2015-10-01T06:37:11Z

Changed commit from ba99790 to f0b1172

sagetrac-git · 2015-10-01T06:41:10Z

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

`8894fce`	`Merge branch 't/17716/asy/asymptoticExpression' into t/19068/asy/inversion`
`dc38b28`	`Merge branch 'asy/asymptoticExpression' into asy/inversion`
`59e5d38`	`Merge tag '6.9.rc0' into asy/inversion`
`f0b759a`	`Merge branch 'asy/asymptoticExpression' into asy/inversion`
`b37740f`	`remove code duplicate`
`bfc460a`	`fix removed keyword 'default_prec'`
`fc9bcf2`	`add result to doctest`
`4edaa39`	`slightly improve __pow__`
`c7023dd`	`todo-block with remark w.r.t. L-terms added`
`f6b06c9`	`Merge branch 'u/behackl/asy/inversion' of trac.sagemath.org:sage into t/19048/asy/an_element`

sagetrac-git · 2015-10-01T06:41:10Z

Changed commit from f0b1172 to f6b06c9

dkrenn · 2015-10-01T06:42:17Z

Changed dependencies from #17716, #19047, #19319 to #17716, #19047, #19068, #19319

dkrenn · 2015-10-01T06:42:48Z

comment:23

Replying to @cheuberg:

Merging #19068 would solve the problem, but perhaps you could have a look whether there is some deeper problem before.

Merging #19068 is fine.

cheuberg · 2015-10-02T17:37:33Z

comment:24

#19319 now has completely new code which is guaranteed to produce merge conflicts here.

cheuberg · 2015-10-03T07:18:04Z

Changed branch from u/dkrenn/asy/an_element to u/cheuberg/asy/an_element

sagetrac-git · 2015-10-03T07:19:05Z

Changed commit from f6b06c9 to 617c593

sagetrac-git · 2015-10-03T07:19:05Z

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

`c41435f`	`Revert "copy code from #19048"`
`c655f9f`	`Trac 19319: Cantor iteration of cartesian products`
`4a52a84`	`Trac 19319: fix doctests`
`3c5af3b`	`Trac #19319: fix typo`
`c20bfe5`	`Trac #19319: a.next() -> next(a) (Python3 compliance)`
`1fee722`	`Trac #19319: added a few blanks`
`96c0366`	`Trac 19319: return tuples + repeat argument`
`ceb1db5`	`Trac #19048: Merge #19319`
`3fd53d6`	`Trac #19048: rename product_cantor_pairing to cantor_product (see #19319)`
`617c593`	`Trac #19048: Fix doctests (order in cantor_product changed)`

cheuberg · 2015-10-03T07:23:15Z

comment:27

I reviewed this code before #19319 had been factored out and did not have any objections to the part which is still in this ticket.

Replying to @cheuberg:

#19319 now has completely new code which is guaranteed to produce merge conflicts here.

I now reverted all changes by the old branch of #19319, merged the new branch of #19319 and fixed code and doctests here.

Please cross-review this revert+merge+fix and set the ticket to positive_review if you are satisfied.

behackl · 2015-10-05T10:40:30Z

comment:28

Thanks for your review and the merge of the changes at #19319. I cross-checked everything; your changes look fine; documentation builds and doctests pass.

Together with your previous review, this is positive_review.

vbraun · 2015-10-14T00:59:30Z

Changed branch from u/cheuberg/asy/an_element to 617c593

dkrenn added this to the sage-6.9 milestone Aug 17, 2015

dkrenn added c: symbolics labels Aug 17, 2015

This comment has been minimized.

Sign in to view

dkrenn added the s: needs review label Aug 21, 2015

dkrenn removed the c: symbolics label Sep 15, 2015

cheuberg added s: needs work and removed s: needs review labels Sep 30, 2015

dkrenn added s: needs review and removed s: needs work labels Oct 1, 2015

cheuberg added s: needs work and removed s: needs review labels Oct 2, 2015

cheuberg added s: needs review and removed s: needs work labels Oct 3, 2015

behackl added s: positive review and removed s: needs review labels Oct 5, 2015

vbraun removed the s: positive review label Oct 14, 2015

vbraun closed this as completed in b384d0b Oct 14, 2015

This was referenced Dec 29, 2022

Meta ticket: Asymptotic Expansions in SageMath #17601

Open

exp & log for the AsymptoticRing #19094

Closed

dkrenn mentioned this issue Oct 12, 2015

iterator over products on diagonals a la Cantor #19319

Closed

AsymptoticRing: an_element #19048

AsymptoticRing: an_element #19048

Comments

dkrenn commented Aug 17, 2015

dkrenn commented Aug 17, 2015

dkrenn commented Aug 17, 2015

dkrenn commented Aug 17, 2015

dkrenn commented Aug 17, 2015

This comment has been minimized.

behackl commented Aug 17, 2015

behackl commented Aug 17, 2015

behackl commented Aug 17, 2015

behackl commented Aug 17, 2015

dkrenn commented Aug 21, 2015

dkrenn commented Aug 21, 2015

dkrenn commented Aug 21, 2015

sagetrac-git mannequin commented Sep 9, 2015

sagetrac-git mannequin commented Sep 9, 2015

dkrenn commented Sep 9, 2015

sagetrac-git mannequin commented Sep 16, 2015

sagetrac-git mannequin commented Sep 16, 2015

behackl commented Sep 23, 2015

behackl commented Sep 23, 2015

behackl commented Sep 23, 2015

cheuberg commented Sep 29, 2015

cheuberg commented Sep 29, 2015

dkrenn commented Sep 30, 2015

cheuberg commented Sep 30, 2015

cheuberg commented Sep 30, 2015

sagetrac-git mannequin commented Oct 1, 2015

sagetrac-git mannequin commented Oct 1, 2015

sagetrac-git mannequin commented Oct 1, 2015

sagetrac-git mannequin commented Oct 1, 2015

dkrenn commented Oct 1, 2015

dkrenn commented Oct 1, 2015

cheuberg commented Oct 2, 2015

cheuberg commented Oct 3, 2015

sagetrac-git mannequin commented Oct 3, 2015

sagetrac-git mannequin commented Oct 3, 2015

cheuberg commented Oct 3, 2015

behackl commented Oct 5, 2015

vbraun commented Oct 14, 2015