Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exp & log for the AsymptoticRing #19094

Closed
behackl opened this issue Aug 26, 2015 · 73 comments
Closed

exp & log for the AsymptoticRing #19094

behackl opened this issue Aug 26, 2015 · 73 comments

Comments

@behackl
Copy link
Member

behackl commented Aug 26, 2015

On this ticket, taking the logarithm and the exponential function (both with arbitrary appropriate bases) of asymptotic expressions (as implemented in #17716) shall be implemented.

Depends on #19048
Depends on #19073
Depends on #19079
Depends on #19110

CC: @dkrenn @cheuberg

Component: asymptotic expansions

Author: Benjamin Hackl, Daniel Krenn

Reviewer: Daniel Krenn, Clemens Heuberger

Issue created by migration from https://trac.sagemath.org/ticket/19094

@behackl behackl added this to the sage-6.9 milestone Aug 26, 2015
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 26, 2015

Changed commit from 8337efa to 187442b

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 26, 2015

Branch pushed to git repo; I updated commit sha1. This was a forced push. Last 10 new commits:

1ac20d7rewrite element_constructor of AsymptoticRing to accept SR and polynomials
15ba65ecorrect a bug in growth_group_cartesian._element_constructor_
4bbe5f3add a doctest to convert from SR
c7c4de9__ne__ implemented for growth group elements
549a155dummy implementations of log for monomial and exponential growth groups
ec04d5eexponential element constructor: exp(...) covered
16514c0exponential growth elements: representation string simplified
5f04fd5implemented factor for cartesian product elements
6498396implemented log_factor
187442bimplemented log for growth groups

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 26, 2015

Changed commit from 187442b to 737dc93

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 26, 2015

Branch pushed to git repo; I updated commit sha1. New commits:

737dc93rpow and exp implemented.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 28, 2015

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

1e625e3add a doctest for scalar multiplication
be23e63fix bug with "is" and change_parameter
0c2b6e4improves working with categories and use CommutativeAlgebras()
ee071a7fix scalar multiplication by zero
f54e588some checks on the given names of the generators (when using R.<....>)
92861edmore on names/gens
18bc9e8correct handling of parent in __invert__
d833544minor rewrite of __pow__
cf79733Merge branch 'u/dkrenn/asy/prototype' of git://trac.sagemath.org/sage into asy/ring-exp-log
2d4c680doctest fixed

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 28, 2015

Changed commit from 737dc93 to 2d4c680

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 28, 2015

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

123d0c8Merge branch 'u/dkrenn/asy/mutable-poset' into asy/prototype
6c04529fix lazy import problem when using short representations
1d023c6import AsymptoticRing lazy
e02895fremove some empty lines
738f4edexplicitly use coefficient_ring(-1) in subtraction
ecf5ba8use simplify/convert everywhere explicit
55d6ad3restructure and rewrite classcall and init of growth group
3e449dfsolve non-uniquenessbug by rewriting classcall and init of term
5068df9rewrite classcall and init of asymptotic ring
85dcb7aMerge branch 'u/dkrenn/asy/prototype' of git://trac.sagemath.org/sage into asy/ring-exp-log

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 28, 2015

Changed commit from 2d4c680 to 85dcb7a

@dkrenn
Copy link
Contributor

dkrenn commented Aug 31, 2015

Changed branch from u/behackl/asy/ring-exp-log to u/dkrenn/asy/ring-exp-log

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 31, 2015

Changed commit from 85dcb7a to 32b422d

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 31, 2015

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

ba62bfbrewrite log_factor
b8208a4doc of `_log_factor_` helper method
03d4b95move log_factor to growth_group
d825419make log_factor working again
3ac612bfix doc and doctests
4629e82improve doc of log
15cc256move log to growth_group
1dca8c0get rid of old log method
d67d4aaminor doc change in exp + one additional doctest
32b422dmajor rpow rewriting in growth group

@dkrenn
Copy link
Contributor

dkrenn commented Aug 31, 2015

Changed author from Benjamin Hackl to Benjamin Hackl, Daniel Krenn

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 1, 2015

Changed commit from 32b422d to 797eb74

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 1, 2015

Branch pushed to git repo; I updated commit sha1. New commits:

9b8e8a6simplify rpow code
fc3a77fminor rewrite of _rpow_element_
797eb74docstrings for rpow and rpow_element

@dkrenn
Copy link
Contributor

dkrenn commented Sep 1, 2015

Reviewer: Daniel Krenn

@dkrenn
Copy link
Contributor

dkrenn commented Sep 1, 2015

comment:9

A lot of reviewer commits added. Need a cross review; but positive review from my side (so far).

@dkrenn
Copy link
Contributor

dkrenn commented Sep 1, 2015

Changed dependencies from #17716, #19073 to #17716, #19083, #19073

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 1, 2015

Changed commit from 797eb74 to 780d26b

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 1, 2015

Branch pushed to git repo; I updated commit sha1. New commits:

780d26bfix ALGORITHM block

@behackl
Copy link
Member Author

behackl commented Sep 2, 2015

Changed commit from 780d26b to ff3e536

@behackl
Copy link
Member Author

behackl commented Sep 2, 2015

Changed branch from u/dkrenn/asy/ring-exp-log to u/behackl/asy/ring-exp-log

@behackl
Copy link
Member Author

behackl commented Sep 2, 2015

Last 10 new commits:

4d6bc7eMerge branch 'u/dkrenn/asy/prototype' of git://trac.sagemath.org/sage into asy/ring-exp-log
9d0b39cis_constant for terms implemented
bdf8ae7helper functions `_construct_exp_` for terms implemented
8ff9e7bimplemented helper function _rpow_
2e3dec4doctests for exp are now actually tested
7adba3cadaption of __pow__: call to _rpow_
0ea030c_log_factor_ (exponential growth group): improved handling of base=None
bb3f707exponentiation of constant terms with base=None
d4ae5d3doctests added
ff3e536some small doctests for `__pow__` added

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 8, 2015

Changed commit from 74cd899 to eb4e3c9

@dkrenn
Copy link
Contributor

dkrenn commented Oct 8, 2015

@dkrenn
Copy link
Contributor

dkrenn commented Oct 8, 2015

Changed dependencies from #17716, #19028, #19048, #19073, #19079, #19110 to #19048, #19073, #19079, #19110

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 8, 2015

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

c655f9fTrac 19319: Cantor iteration of cartesian products
4a52a84Trac 19319: fix doctests
3c5af3bTrac #19319: fix typo
c20bfe5Trac #19319: a.next() -> next(a) (Python3 compliance)
1fee722Trac #19319: added a few blanks
96c0366Trac 19319: return tuples + repeat argument
ceb1db5Trac #19048: Merge #19319
3fd53d6Trac #19048: rename product_cantor_pairing to cantor_product (see #19319)
617c593Trac #19048: Fix doctests (order in cantor_product changed)
9213baaMerge branch 'u/cheuberg/asy/an_element' of trac.sagemath.org:sage into t/19094/asy/ring-exp-log

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 8, 2015

Changed commit from eb4e3c9 to 9213baa

@dkrenn
Copy link
Contributor

dkrenn commented Oct 8, 2015

comment:37

Now really merged in all dependencies.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 12, 2015

Changed commit from 9213baa to 05862f4

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 12, 2015

Branch pushed to git repo; I updated commit sha1. New commits:

2a80346Trac #19073: simplify signatures of helper functions in merge_overlapping
1583ffcTrac #19073: Reword and add doctest for _pushout_
8a32f1fcorrect PEP8-spacings in doctest
05862f4Merge branch 't/19073/asy/groups-coercion' into t/19094/asy/ring-exp-log

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 12, 2015

Branch pushed to git repo; I updated commit sha1. New commits:

b160261forgotten changes of last merge

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 12, 2015

Changed commit from 05862f4 to b160261

@behackl
Copy link
Member Author

behackl commented Oct 13, 2015

Changed branch from u/dkrenn/asy/ring-exp-log to u/behackl/asy/ring-exp-log

@behackl
Copy link
Member Author

behackl commented Oct 13, 2015

Changed commit from b160261 to 5562a66

@behackl
Copy link
Member Author

behackl commented Oct 13, 2015

comment:40

added the TODO-blocks as suggested by cheuberg, back to needs_review.


New commits:

5562a66add two TODO-blocks

@cheuberg
Copy link
Contributor

comment:41

I review this ticket and the follow-up-ticket #19083 in one go, as there are many interdependencies.

@cheuberg
Copy link
Contributor

Changed reviewer from Daniel Krenn to Daniel Krenn, Clemens Heuberger

@cheuberg cheuberg modified the milestones: sage-6.9, sage-6.10 Oct 14, 2015
@cheuberg
Copy link
Contributor

comment:43

As this is reviewed in #19083, it seems best to close this as a duplicate.

@cheuberg
Copy link
Contributor

Changed commit from 5562a66 to none

@cheuberg
Copy link
Contributor

Changed branch from u/behackl/asy/ring-exp-log to none

@cheuberg cheuberg removed this from the sage-6.10 milestone Oct 16, 2015
@dkrenn
Copy link
Contributor

dkrenn commented Oct 16, 2015

comment:44

Replying to @cheuberg:

As this is reviewed in #19083, it seems best to close this as a duplicate.

Ok.

@cheuberg
Copy link
Contributor

comment:45

Replying to @dkrenn:

Replying to @cheuberg:

As this is reviewed in #19083, it seems best to close this as a duplicate.

Ok.

in that case, please set this ticket to positive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants