Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConstructionFunctor: remove __str__ #19079

Closed
dkrenn opened this issue Aug 24, 2015 · 8 comments
Closed

ConstructionFunctor: remove __str__ #19079

dkrenn opened this issue Aug 24, 2015 · 8 comments

Comments

@dkrenn
Copy link
Contributor

dkrenn commented Aug 24, 2015

sage.categories.pushout.ConstructionFunctor still uses __str__ and _repr_ calls this str. It should be the other way round as for SageObject.

Component: coercion

Author: Daniel Krenn

Branch/Commit: bc2f089

Reviewer: Marc Mezzarobba

Issue created by migration from https://trac.sagemath.org/ticket/19079

@dkrenn dkrenn added this to the sage-6.9 milestone Aug 24, 2015
@dkrenn
Copy link
Contributor Author

dkrenn commented Aug 24, 2015

Branch: u/dkrenn/functor-str-on-6.8

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 24, 2015

Commit: 6a6a40b

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 24, 2015

Branch pushed to git repo; I updated commit sha1. New commits:

19247a5fix derived classes
6a6a40bMerge remote-tracking branch 'origin/u/dkrenn/pushout/functor-str' into u/dkrenn/functor-str-on-6.8

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 25, 2015

Branch pushed to git repo; I updated commit sha1. New commits:

dacbfcbmore replacements of `__str__` by _repr_
bc2f089Merge remote-tracking branch 'origin/u/dkrenn/pushout/functor-str' into u/dkrenn/functor-str-on-6.8

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 25, 2015

Changed commit from 6a6a40b to bc2f089

@mezzarobba
Copy link
Member

Reviewer: Marc Mezzarobba

@mezzarobba
Copy link
Member

comment:5

Sounds reasonable. I kicked the patchbot as it says TestsFailed with errors that look unrelated to your changes.

@vbraun
Copy link
Member

vbraun commented Sep 7, 2015

Changed branch from u/dkrenn/functor-str-on-6.8 to bc2f089

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants