Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

calling findstat with first argument being a FindStatCollection does not work #19314

Closed
mantepse opened this issue Sep 30, 2015 · 8 comments
Closed

calling findstat with first argument being a FindStatCollection does not work #19314

mantepse opened this issue Sep 30, 2015 · 8 comments
Labels
c: interfaces p: major / 3 t: bug
Milestone
sage-6.9

Comments

@mantepse
Copy link
Contributor 

sage: from sage.databases.findstat import FindStatCollection
sage: findstat(FindStatCollection("Permutations"), lambda pi: pi.length())

yields an error, which is fixed by this ticket.

CC: @stumpc5

Component: interfaces

Keywords: FindStat

Author: Martin Rubey

Branch/Commit: dc390fc

Reviewer: Christian Stump

Issue created by migration from https://trac.sagemath.org/ticket/19314
@mantepse mantepse added this to the sage-6.9 milestone Sep 30, 2015
@stumpc5
Copy link
Contributor

stumpc5 commented Sep 30, 2015

comment:1

Currently, FindStatCollection is purely internal, isn't it? Of course you can fix this issue, but I would not recommend to have this as a user point of entry to the findstat functionality...

@mantepse
Copy link
Contributor Author

Branch: u/mantepse/calling_findstat_with_first_argument_being_a_findstatcollection_does_not_work

@mantepse
Copy link
Contributor Author

comment:3

I really do have to fix it, since it might be called internally... Also, personally, I use FindStatCollections quite a bit.

New commits:

dc390fcforgot an else

@mantepse
Copy link
Contributor Author

Commit: dc390fc

@stumpc5
Copy link
Contributor

stumpc5 commented Oct 1, 2015

comment:4

This is ready to go, are you going to set it to needs review? Please also have a look at #19307 and #19296, both ready for review with green patchbot.

@stumpc5
Copy link
Contributor

stumpc5 commented Oct 4, 2015

Reviewer: Christian Stump

@stumpc5
Copy link
Contributor

stumpc5 commented Oct 4, 2015

Author: Martin Rubey

@vbraun
Copy link
Member

vbraun commented Oct 12, 2015

Changed branch from u/mantepse/calling_findstat_with_first_argument_being_a_findstatcollection_does_not_work to dc390fc

@vbraun vbraun closed this as completed in e966fbf Oct 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: interfaces p: major / 3 t: bug
Projects
None yet
Milestone
sage-6.9
Development

No branches or pull requests
3 participants
@vbraun @stumpc5 @mantepse