New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QQbar.polynomial_root(): allow approximate root #19356
Comments
Commit: |
comment:4
I'm not sure why this never got reviewed, so I am reviewing it after rebasing it on 7.1.beta3 (actually merging not rebasing). The code looks good, but I suppose that #19362 needs finishing first. I am not sure what the needs_work issue is with that one? |
Changed branch from u/jdemeyer/qqbar_polynomial_root____allow_approximate_root to u/cremona/19356 |
New commits:
|
comment:6
I merged with current develop (7.1.beta3). One minor doctest change was needed in QQbar. I hope I did not break etiquette ('ticket-etiquette'!) by doing so and pushing the branch with my name on... |
comment:7
merge conflict |
Changed keywords from none to qqbar |
Instead of only allowing an interval containing a root, an approximate root should also be accepted.
Depends on #19362
Component: algebra
Keywords: qqbar
Author: Jeroen Demeyer
Branch/Commit: u/cremona/19356 @
afa1798
Issue created by migration from https://trac.sagemath.org/ticket/19356
The text was updated successfully, but these errors were encountered: