Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QQbar.polynomial_root(): allow approximate root #19356

Open
jdemeyer opened this issue Oct 5, 2015 · 11 comments
Open

QQbar.polynomial_root(): allow approximate root #19356

jdemeyer opened this issue Oct 5, 2015 · 11 comments

Comments

@jdemeyer
Copy link

jdemeyer commented Oct 5, 2015

Instead of only allowing an interval containing a root, an approximate root should also be accepted.

Depends on #19362

Component: algebra

Keywords: qqbar

Author: Jeroen Demeyer

Branch/Commit: u/cremona/19356 @ afa1798

Issue created by migration from https://trac.sagemath.org/ticket/19356

@jdemeyer jdemeyer added this to the sage-6.9 milestone Oct 5, 2015
@jdemeyer
Copy link
Author

jdemeyer commented Oct 6, 2015

Changed dependencies from #19330 to #19362

@jdemeyer
Copy link
Author

jdemeyer commented Oct 6, 2015

@jdemeyer
Copy link
Author

jdemeyer commented Oct 6, 2015

Commit: 41aaf04

@jdemeyer
Copy link
Author

jdemeyer commented Oct 6, 2015

New commits:

2049f5aMove refine_root() to refine_root.pyx
3b34e49Improve refine_root()
41aaf04Allow approximate root in polynomial_root()

@JohnCremona
Copy link
Member

comment:4

I'm not sure why this never got reviewed, so I am reviewing it after rebasing it on 7.1.beta3 (actually merging not rebasing). The code looks good, but I suppose that #19362 needs finishing first. I am not sure what the needs_work issue is with that one?

@JohnCremona
Copy link
Member

Changed commit from 41aaf04 to afa1798

@JohnCremona
Copy link
Member

@JohnCremona
Copy link
Member

New commits:

afa1798Merge branch 'develop (7.1.beta3)' into 19356

@JohnCremona
Copy link
Member

comment:6

I merged with current develop (7.1.beta3). One minor doctest change was needed in QQbar. I hope I did not break etiquette ('ticket-etiquette'!) by doing so and pushing the branch with my name on...

@cheuberg
Copy link
Contributor

comment:7

merge conflict

@jplab
Copy link

jplab commented Apr 22, 2019

Changed keywords from none to qqbar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants