New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve refine_root() #19362
Comments
Branch: u/jdemeyer/ticket/19362 |
Commit: |
Branch pushed to git repo; I updated commit sha1. New commits:
|
This comment has been minimized.
This comment has been minimized.
comment:5
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:10
I am going to continue working on this a bit more. If anybody feels like reviewing this code, let me know and I'll put up the current version for review. |
comment:13
Did you notice that some code in |
comment:14
Replying to @videlec:
Yes, there are way too many re-implementations of this in Sage. My eventual goal is to replace all "real/complex root refining" code in Sage by this new |
comment:15
Making it support all use cases of the various existing implementations is also what makes it tricky. |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:17
What is the work which needs doing? |
comment:18
I don't really remember myself, I do remember that it wasn't ready. It was trickier than I initially estimated. I will need to look at it again. |
comment:19
You probably know that, but just in case: it is not strictly true that you cannot use the interval Newton method and must switch to bisection when the slope interval contains zero. Another option is to interpret 1/[-a,b] as a kind of ”projective interval” containing ∞ (which gives rise to two disjoint complex intervals after intersecting with the previous estimate, so you'll still need to deal with several pieces). |
comment:20
IMHO, On the other hand, there are some possible alternative in the real case that does not involve convergence of Newton algorithm (and might already be implemented elsewhere). Namely
|
In particular, allow both real and complex input. Also implement bisection if Newton-Raphson cannot be used.
Component: algebra
Author: Jeroen Demeyer
Branch/Commit: u/jdemeyer/ticket/19362 @
9d5f99c
Issue created by migration from https://trac.sagemath.org/ticket/19362
The text was updated successfully, but these errors were encountered: