Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move refine_root() to a new file #19361

Closed
jdemeyer opened this issue Oct 6, 2015 · 9 comments
Closed

Move refine_root() to a new file #19361

jdemeyer opened this issue Oct 6, 2015 · 9 comments
Labels
c: algebra p: major / 3 t: enhancement
Milestone
sage-6.10

Comments

@jdemeyer
Copy link

jdemeyer commented Oct 6, 2015

The function refine_root() from complex_roots.py is a pretty general Newton­-Raphson implementation. In light of further changes at #19362, we move this to a new Cython file.

There are no changes at all to the code.

Component: algebra

Author: Jeroen Demeyer

Branch: 2049f5a

Reviewer: Julian Rueth

Issue created by migration from https://trac.sagemath.org/ticket/19361
@jdemeyer jdemeyer added this to the sage-6.9 milestone Oct 6, 2015
@jdemeyer
Copy link
Author

jdemeyer commented Oct 6, 2015

Branch: u/jdemeyer/move_refine_root___to_a_new_file

@jdemeyer
Copy link
Author

jdemeyer commented Oct 6, 2015

New commits:

2049f5aMove refine_root() to refine_root.pyx

@jdemeyer
Copy link
Author

jdemeyer commented Oct 6, 2015

Commit: 2049f5a

@jdemeyer

This comment has been minimized.

Sign in to view
@jdemeyer jdemeyer modified the milestones: sage-6.9, sage-6.10 Oct 6, 2015
@jdemeyer

This comment has been minimized.

Sign in to view
@saraedum
Copy link
Member

Reviewer: Julian Rüth

@vbraun
Copy link
Member

vbraun commented Oct 14, 2015

Changed branch from u/jdemeyer/move_refine_root___to_a_new_file to 2049f5a

@vbraun vbraun closed this as completed in 9893082 Oct 14, 2015
@jdemeyer
Copy link
Author

Changed reviewer from Julian Rüth to Julian Rueth

@jdemeyer
Copy link
Author

Changed commit from 2049f5a to none

@pjbruin pjbruin mentioned this issue Dec 29, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: algebra p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-6.10
Development

No branches or pull requests
3 participants
@saraedum @vbraun @jdemeyer