EnumeratedSets.ParentMethods.map should not rely on CombinatorialClass #19474
Labels
Comments
5 tasks
vbraun
pushed a commit
to vbraun/sage
that referenced
this issue
Apr 20, 2024
<!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> - Fixes sagemath#36133 - Fixes sagemath#33384 - Fixes sagemath#19474 - Fixes sagemath#12913 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [ ] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#37722 Reported by: Matthias Köppe Reviewer(s): Martin Rubey, Matthias Köppe, Travis Scrimshaw
vbraun
pushed a commit
to vbraun/sage
that referenced
this issue
May 2, 2024
<!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> - Fixes sagemath#36133 - Fixes sagemath#33384 - Fixes sagemath#19474 - Fixes sagemath#12913 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [ ] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#37722 Reported by: Matthias Köppe Reviewer(s): Martin Rubey, Matthias Köppe, Travis Scrimshaw
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
See the
mapmethod insrc/sage/categories/enumerated_sets.py. We want to deprecate combinatorial classes, so let's not use them here.Might be a good idea to rename/alias this as
direct_imageand make this a functorial construction that works for various other categories.CC: @nthiery @tscrim @stumpc5
Component: categories
Keywords: enumerated sets, OOP
Issue created by migration from https://trac.sagemath.org/ticket/19474
The text was updated successfully, but these errors were encountered: