Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up factoring PARI interface #20205

Closed
jdemeyer opened this issue Mar 14, 2016 · 9 comments
Closed

Clean up factoring PARI interface #20205

jdemeyer opened this issue Mar 14, 2016 · 9 comments
Labels
c: interfaces p: major / 3 t: enhancement
Milestone
sage-7.1

Comments

@jdemeyer
Copy link

  1. Instead of manually checking primality, we should just use PARI's factor_proven default.

  2. Stop using deprecated PARI features like factor0() and lim=0.

CC: @defeo

Component: interfaces

Author: Jeroen Demeyer

Branch/Commit: c0ed97a

Reviewer: Vincent Delecroix

Issue created by migration from https://trac.sagemath.org/ticket/20205
@jdemeyer jdemeyer added this to the sage-7.1 milestone Mar 14, 2016
@jdemeyer
Copy link
Author

Branch: u/jdemeyer/get_rid_of_factorint_withproof_sage_in_pari_interface

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 14, 2016

Commit: 5ab73c1

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 14, 2016

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

5ab73c1Get rid of factorint_withproof_sage in PARI interface

@jdemeyer

This comment has been minimized.

Sign in to view
@jdemeyer jdemeyer changed the title Get rid of factorint_withproof_sage in PARI interface Clean up factoring PARI interface Mar 14, 2016
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 14, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

c0ed97aStop using deprecated PARI factoring features

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 14, 2016

Changed commit from 5ab73c1 to c0ed97a

@videlec
Copy link
Contributor

videlec commented Mar 16, 2016

comment:8

good to go!

@videlec
Copy link
Contributor

videlec commented Mar 16, 2016

Reviewer: Vincent Delecroix

@vbraun
Copy link
Member

vbraun commented Mar 22, 2016

Changed branch from u/jdemeyer/get_rid_of_factorint_withproof_sage_in_pari_interface to c0ed97a

@vbraun vbraun closed this as completed in 2d10dab Mar 22, 2016
This was referenced Mar 22, 2016
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: interfaces p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-7.1
Development

No branches or pull requests
3 participants
@vbraun @jdemeyer @videlec