Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant functions from pari_instance.pyx #20217

Closed
jdemeyer opened this issue Mar 16, 2016 · 9 comments
Closed

Remove redundant functions from pari_instance.pyx #20217

jdemeyer opened this issue Mar 16, 2016 · 9 comments

Comments

@jdemeyer
Copy link

Many functions in src/sage/libs/pari/pari_instance.pyx are just manual copies of auto-generated code. Remove those functions, but keep the doctests in src/sage/libs/pari/tests.py.

Depends on #20210
Depends on #20205
Depends on #20213
Depends on #20216

CC: @defeo

Component: interfaces

Author: Jeroen Demeyer

Branch/Commit: d7d2d7d

Reviewer: Luca De Feo

Issue created by migration from https://trac.sagemath.org/ticket/20217

@jdemeyer jdemeyer added this to the sage-7.1 milestone Mar 16, 2016
@jdemeyer
Copy link
Author

Dependencies: #20210, #20205, #20213, #20216

@jdemeyer
Copy link
Author

@jdemeyer
Copy link
Author

Commit: d7d2d7d

@jdemeyer
Copy link
Author

New commits:

03458eaUpgrade cysignals package
dce67fcMove memory functions to cysignals
4bb8337Rename sage_malloc -> sig_malloc and friends
5ab73c1Get rid of factorint_withproof_sage in PARI interface
c0ed97aStop using deprecated PARI factoring features
edc5ce2Merge branch 't/20205/get_rid_of_factorint_withproof_sage_in_pari_interface' into HEAD
5fb408dReplace pari_catch_sig_on by sig_on
d5c934cDeprecate PARI nth_prime and prime_list
d7d2d7dRemove redundant functions from pari_instance.pyx

@jdemeyer
Copy link
Author

Author: Jeroen Demeyer

@defeo
Copy link
Member

defeo commented Mar 16, 2016

comment:4

I just doctested this. All tests pass.

I suggest one more removal: default(self, variable, value=None).

@defeo
Copy link
Member

defeo commented Mar 21, 2016

comment:5

Since the default function is to be dealt in #20224, I have no more objections.

@defeo
Copy link
Member

defeo commented Mar 21, 2016

Reviewer: Luca De Feo

@vbraun
Copy link
Member

vbraun commented Mar 22, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants