Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix enumeration of finitely generated semigroups #20403

Closed
tscrim opened this issue Apr 9, 2016 · 28 comments
Closed

Fix enumeration of finitely generated semigroups #20403

tscrim opened this issue Apr 9, 2016 · 28 comments

Comments

@tscrim
Copy link
Collaborator

tscrim commented Apr 9, 2016

We use breadth-first-search via RecursivelyEnumeratedSet to iterate through the elements of a finitely generated semigroup. This will allow us to deprecate TransitiveIdeal*

Depends on #13580

CC: @sagetrac-sage-combinat @nthiery

Component: algebra

Author: Travis Scrimshaw

Branch/Commit: 702d333

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/20403

@tscrim
Copy link
Collaborator Author

tscrim commented Apr 9, 2016

comment:1

I want to do the deprecation on a separate ticket because only this part is needed for #17039.


New commits:

a0307f3Changed iterator for finitely generated semigroups.

@tscrim
Copy link
Collaborator Author

tscrim commented Apr 9, 2016

@tscrim
Copy link
Collaborator Author

tscrim commented Apr 9, 2016

Commit: a0307f3

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 9, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

859b05fChange TODO list in backtrack to state we can deprecate TransitiveIdeal* now.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 9, 2016

Changed commit from a0307f3 to 859b05f

@tscrim
Copy link
Collaborator Author

tscrim commented Apr 9, 2016

comment:3

Deprecation ticket is #20404.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 9, 2016

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

c427ca9Change TODO list in backtrack to state we can deprecate TransitiveIdeal* now.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 9, 2016

Changed commit from 859b05f to c427ca9

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 9, 2016

Changed commit from c427ca9 to a27f383

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 9, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

a27f383trac #20403 fixing one doctest

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 9, 2016

Changed commit from a27f383 to c20562e

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 9, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

c20562etrac #20403 doc formatting

@fchapoton
Copy link
Contributor

Reviewer: Frédéric Chapoton

@fchapoton
Copy link
Contributor

comment:7

looks good to me

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 10, 2016

Changed commit from c20562e to 67521dd

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 10, 2016

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. Last 10 new commits:

a5f4d67Improved doc for map-reduce
569de0dMerge branch 'develop' into t/13580/map_reduce
b07dfe2Doc of the two implementationsof ActiveTaskCounter
beebcbc#13580: Added comment on timing in the doc
58eca2e#13580: Removed comment which is now in the doc
1badd8a#13580: Renamed ActiveTaskCounter(Posix)
46cbab913580: Fixed doctests to pass on Darwin
134c1fa13580: doc rereading
4c82d1bMerge branch 'u/hivert/ticket/13580' of trac.sagemath.org:sage into u/hivert/ticket/13580
67521ddMerge branch 'u/hivert/ticket/13580' into public/semigroups/iterator_finitely_generated_semigroups-20403

@tscrim
Copy link
Collaborator Author

tscrim commented Apr 10, 2016

Dependencies: #13580

@tscrim
Copy link
Collaborator Author

tscrim commented Apr 10, 2016

comment:9

Trivial conflict/rebase over #13580.

@vbraun
Copy link
Member

vbraun commented Apr 11, 2016

comment:11

See patchbot

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 11, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

6272efdRemoving tab character.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 11, 2016

Changed commit from 67521dd to 6272efd

@vbraun
Copy link
Member

vbraun commented Apr 11, 2016

comment:14

There is another failure on 32-bit that seems to come from this ticket: http://build.sagedev.org/release/builders/%20%20slow%20AIMS%20%20%28Debian%207%2032%20bit%29%20incremental/builds/479/steps/shell_4/logs/stdio

@kiwifb
Copy link
Member

kiwifb commented Apr 11, 2016

comment:15

My own doctesting earlier this afternoon, complained about a tab in backtrack.py as well.

@tscrim
Copy link
Collaborator Author

tscrim commented Apr 11, 2016

comment:16

The tab character should be fixed in 6272efd.

I am actually surprised the breadth first search is so consistent. It is somewhat non-deterministic because it uses a set for the next level, whereas it probably should be a list. However, that is an issue for another ticket because it will require much more large-scale changes.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 11, 2016

Changed commit from 6272efd to 702d333

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 11, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

702d333Fix doctest output order (for 32-bit).

@tscrim
Copy link
Collaborator Author

tscrim commented Apr 11, 2016

comment:18

Quick-n-dirty fix for doctest order.

@vbraun
Copy link
Member

vbraun commented Apr 12, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants