Allow IndexedGenerators to handle `names` #17039

tscrim · 2014-09-25T12:17:40Z

So we can do things like

sage: C.<x,y,z> = CombinatorialFreeModule(QQ)

Depends on #17035
Depends on #20403
Depends on #20405

CC: @nthiery @nbruin @fchapoton @bsalisbury1

Component: misc

Keywords: variable names input

Author: Travis Scrimshaw

Branch/Commit: 73cf1a7

Reviewer: Jeroen Demeyer, Ben Salisbury

Issue created by migration from https://trac.sagemath.org/ticket/17039

The text was updated successfully, but these errors were encountered:

tscrim · 2014-09-25T12:19:03Z

Dependencies: #17035

tscrim · 2014-09-25T16:34:07Z

Commit: d23726c

tscrim · 2014-09-25T16:34:07Z

comment:2

Done and up for review.

New commits:

`f94c3f8`	`Another optio for indexed generators.`
`5b546c2`	`Fixed failing doctest.`
`d23726c`	`Added support for C. for CombinatorialFreeModule.`

tscrim · 2014-09-25T16:34:07Z

Branch: public/misc/names_argument_indexed_generators-17039

sagetrac-git · 2015-03-06T23:29:46Z

Changed commit from d23726c to 06e7a3c

sagetrac-git · 2015-03-06T23:29:46Z

Branch pushed to git repo; I updated commit sha1. New commits:

`06e7a3c`	`Merge branch 'public/misc/names_argument_indexed_generators-17039' of trac.sagemath.org:sage into public/misc/names_argument_indexed_generators-17039`

sagetrac-git · 2015-05-26T04:57:31Z

Changed commit from 06e7a3c to 1aae120

sagetrac-git · 2015-05-26T04:57:31Z

Branch pushed to git repo; I updated commit sha1. New commits:

`1aae120`	`Merge branch 'public/misc/names_argument_indexed_generators-17039' of trac.sagemath.org:sage into public/misc/names_argument_indexed_generators-17039`

sagetrac-git · 2016-03-09T11:57:28Z

Changed commit from 1aae120 to e3175db

sagetrac-git · 2016-03-09T11:57:28Z

Branch pushed to git repo; I updated commit sha1. New commits:

`7a387fa`	`Merge branch 'public/misc/names_argument_indexed_generators-17039' of trac.sagemath.org:sage into public/misc/names_argument_indexed_generators-17039`
`e3175db`	`Fixing doctest ordering.`

sagetrac-git · 2016-04-09T20:22:51Z

Branch pushed to git repo; I updated commit sha1. New commits:

`84792f6`	`Merge branch 'public/misc/names_argument_indexed_generators-17039' of trac.sagemath.org:sage into public/misc/names_argument_indexed_generators-17039`
`ee0536e`	`Added (indexed) monoids to finitely generated monoids category.`
`63e54b0`	`Merge branch 'public/monoids/free_monoids_finitely_generated-20405' into public/misc/names_argument_indexed_generators-17039`
`a0307f3`	`Changed iterator for finitely generated semigroups.`
`c427ca9`	`Change TODO list in backtrack to state we can deprecate TransitiveIdeal* now.`
`dfa5c75`	`Merge branch 'public/semigroups/iterator_finitely_generated_semigroups-20403' into public/misc/names_argument_indexed_generators-17039`
`fc9a4f8`	`Being more python3 compatible.`

sagetrac-git · 2016-04-09T20:22:51Z

Changed commit from e3175db to fc9a4f8

tscrim · 2016-04-09T20:23:57Z

Changed dependencies from #17035 to #17035 #20403 #20405

sagetrac-git · 2016-04-10T08:33:21Z

Branch pushed to git repo; I updated commit sha1. New commits:

`0c3452d`	`Changing behavior of _first_ngens to support using gens().`
`c95e024`	`Fixing trivial failing doctests due to new iterator.`
`52f7f98`	`Merge branch 'public/monoids/free_monoids_finitely_generated-20405' into public/misc/names_argument_indexed_generators-17039`

sagetrac-git · 2016-04-10T08:33:21Z

Changed commit from fc9a4f8 to 52f7f98

sagetrac-git · 2016-04-10T12:45:18Z

Branch pushed to git repo; I updated commit sha1. New commits:

`a27f383`	`trac #20403 fixing one doctest`
`c20562e`	`trac #20403 doc formatting`
`fabe683`	`Merge branch 'public/semigroups/iterator_finitely_generated_semigroups-20403' of trac.sagemath.org:sage into public/misc/names_argument_indexed_generators-17039`
`e640249`	`Last fix of doctests.`
`2d48ce1`	`Merge branch 'public/monoids/free_monoids_finitely_generated-20405' into public/misc/names_argument_indexed_generators-17039`
`02df281`	`Fixing doctests.`

sagetrac-git · 2016-04-10T12:45:18Z

Changed commit from 52f7f98 to 02df281

sagetrac-git · 2016-04-10T12:49:26Z

Changed commit from 02df281 to 94f081b

sagetrac-git · 2016-04-10T12:49:26Z

Branch pushed to git repo; I updated commit sha1. New commits:

`1c07d56`	`Merge branch 'public/semigroups/iterator_finitely_generated_semigroups-20403' of trac.sagemath.org:sage into public/monoids/free_monoids_finitely_generated-20405`
`e7914d4`	`Pulling changes from #17039 to fix doctest with this (#20405) + #20403.`
`94f081b`	`Merge branch 'public/monoids/free_monoids_finitely_generated-20405' into public/misc/names_argument_indexed_generators-17039`

sagetrac-git · 2016-04-10T19:07:02Z

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

`569de0d`	`Merge branch 'develop' into t/13580/map_reduce`
`b07dfe2`	`Doc of the two implementationsof ActiveTaskCounter`
`beebcbc`	`#13580: Added comment on timing in the doc`
`58eca2e`	`#13580: Removed comment which is now in the doc`
`1badd8a`	`#13580: Renamed ActiveTaskCounter(Posix)`
`46cbab9`	`13580: Fixed doctests to pass on Darwin`
`134c1fa`	`13580: doc rereading`
`4c82d1b`	`Merge branch 'u/hivert/ticket/13580' of trac.sagemath.org:sage into u/hivert/ticket/13580`
`67521dd`	`Merge branch 'u/hivert/ticket/13580' into public/semigroups/iterator_finitely_generated_semigroups-20403`
`fc1eb23`	`Merge branch 'public/misc/names_argument_indexed_generators-17039' of trac.sagemath.org:sage into public/misc/names_argument_indexed_generators-17039`

sagetrac-git · 2016-04-10T19:07:02Z

Changed commit from 94f081b to fc1eb23

sagetrac-git · 2017-05-27T17:11:04Z

Branch pushed to git repo; I updated commit sha1. New commits:

`ad23fbd`	`Merge branch 'public/misc/names_argument_indexed_generators-17039' of git://trac.sagemath.org/sage into public/misc/names_argument_indexed_generators-17039`
`1c1cad1`	`Use normalize_names.`
`627e5e0`	`Removing code duplication.`

sagetrac-git · 2017-05-27T17:14:25Z

Changed commit from 627e5e0 to 06eae33

sagetrac-git · 2017-05-27T17:14:25Z

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

`06eae33`	`Removing code duplication.`

tscrim · 2017-05-27T17:15:34Z

comment:23

Thank you for looking at this.

comment:18 Good point. IIRC, back when I did this, that was not separated as a standalone function but instead a method of CategoryObject. I also made some other changes to remove code duplication and improve the documentation.

comment:20 I don't want to do that because other keyword options that are used should not default to False, such as scalar_mult.

sagetrac-git · 2017-05-27T22:18:37Z

Changed commit from 06eae33 to 76b3be2

sagetrac-git · 2017-05-27T22:18:37Z

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

`76b3be2`	`Removing code duplication.`

jdemeyer · 2017-05-28T21:22:24Z

comment:25

Replying to @tscrim:

comment:20 I don't want to do that because other keyword options that are used should not default to False, such as scalar_mult.

I don't get your point. I am saying that you can replace

if 'bracket' not in kwds:
    kwds['bracket'] = False

by

kwds.setdefault('bracket', False)

You can do the same for string_quotes but I'm not saying that you must do this for every keyword if you don't want.

jdemeyer · 2017-05-28T21:24:08Z

comment:26

Replying to @tscrim:

comment:18 Good point. IIRC, back when I did this, that was not separated as a standalone function but instead a method of CategoryObject.

Yes, this was fixed in #19675.

sagetrac-git · 2017-05-29T21:02:49Z

Branch pushed to git repo; I updated commit sha1. New commits:

`8f7d3e6`	`Use setdefault instead of manually checking.`

sagetrac-git · 2017-05-29T21:02:49Z

Changed commit from 76b3be2 to 8f7d3e6

tscrim · 2017-05-29T21:04:13Z

comment:28

Replying to @jdemeyer:

Replying to @tscrim:

comment:20 I don't want to do that because other keyword options that are used should not default to False, such as scalar_mult.

I don't get your point. I am saying that you can replace
if 'bracket' not in kwds:
    kwds['bracket'] = False
by
kwds.setdefault('bracket', False)
You can do the same for string_quotes but I'm not saying that you must do this for every keyword if you don't want.

I misread setdefault. I was thinking it made the dict behave like a defaultdict. I agree that this is a better way to go.

tscrim · 2017-06-03T13:42:33Z

comment:29

Patchbot is back to (essentially) green.

sagetrac-git · 2017-06-12T03:48:00Z

Branch pushed to git repo; I updated commit sha1. New commits:

`06f1536`	`Merge branch 'public/misc/names_argument_indexed_generators-17039' of git://trac.sagemath.org/sage into public/misc/names_argument_indexed_generators-17039`

sagetrac-git · 2017-06-12T03:48:00Z

Changed commit from 8f7d3e6 to 06f1536

sagetrac-git · 2017-06-23T12:52:26Z

Changed commit from 06f1536 to 451d60b

sagetrac-git · 2017-06-23T12:52:26Z

Branch pushed to git repo; I updated commit sha1. New commits:

`451d60b`	`Merge branch 'public/misc/names_argument_indexed_generators-17039' of git://trac.sagemath.org/sage into public/misc/names_argument_indexed_generators-17039`

sagetrac-git · 2017-06-23T12:56:13Z

Branch pushed to git repo; I updated commit sha1. New commits:

`73cf1a7`	`Updating split_index_keywords.`

sagetrac-git · 2017-06-23T12:56:13Z

Changed commit from 451d60b to 73cf1a7

tscrim · 2017-06-23T12:58:27Z

comment:33

Rebased over beta12.

bsalisbury1 · 2017-06-26T15:17:17Z

Reviewer: Ben Salisbury

bsalisbury1 · 2017-06-26T15:17:17Z

comment:34

Changes look good and everything builds and passes on my machine.

tscrim · 2017-06-27T02:26:31Z

Changed reviewer from Ben Salisbury to Jeroen Demeyer, Ben Salisbury

tscrim · 2017-06-27T02:26:31Z

comment:35

Thank you.

vbraun · 2017-06-29T06:46:51Z

Changed branch from public/misc/names_argument_indexed_generators-17039 to 73cf1a7

tscrim added this to the sage-6.4 milestone Sep 25, 2014

tscrim added p: major / 3 labels Sep 25, 2014

tscrim self-assigned this Sep 25, 2014

tscrim added the s: needs review label Sep 25, 2014

tscrim modified the milestones: sage-6.4, sage-6.8 May 26, 2015

tscrim modified the milestones: sage-6.8, sage-7.2 Apr 9, 2016

tscrim added s: needs review and removed s: needs work labels May 27, 2017

bsalisbury1 added s: positive review and removed s: needs review labels Jun 26, 2017

vbraun removed the s: positive review label Jun 29, 2017

vbraun closed this as completed in f1c959d Jun 29, 2017

Allow IndexedGenerators to handle names #17039

Allow IndexedGenerators to handle names #17039

Comments

tscrim commented Sep 25, 2014

tscrim commented Sep 25, 2014

tscrim commented Sep 25, 2014

tscrim commented Sep 25, 2014

tscrim commented Sep 25, 2014

sagetrac-git mannequin commented Mar 6, 2015

sagetrac-git mannequin commented Mar 6, 2015

sagetrac-git mannequin commented May 26, 2015

sagetrac-git mannequin commented May 26, 2015

sagetrac-git mannequin commented Mar 9, 2016

sagetrac-git mannequin commented Mar 9, 2016

sagetrac-git mannequin commented Apr 9, 2016

sagetrac-git mannequin commented Apr 9, 2016

tscrim commented Apr 9, 2016

sagetrac-git mannequin commented Apr 10, 2016

sagetrac-git mannequin commented Apr 10, 2016

sagetrac-git mannequin commented Apr 10, 2016

sagetrac-git mannequin commented Apr 10, 2016

sagetrac-git mannequin commented Apr 10, 2016

sagetrac-git mannequin commented Apr 10, 2016

sagetrac-git mannequin commented Apr 10, 2016

sagetrac-git mannequin commented Apr 10, 2016

sagetrac-git mannequin commented May 27, 2017

sagetrac-git mannequin commented May 27, 2017

sagetrac-git mannequin commented May 27, 2017

tscrim commented May 27, 2017

sagetrac-git mannequin commented May 27, 2017

sagetrac-git mannequin commented May 27, 2017

jdemeyer commented May 28, 2017

jdemeyer commented May 28, 2017

sagetrac-git mannequin commented May 29, 2017

sagetrac-git mannequin commented May 29, 2017

tscrim commented May 29, 2017

tscrim commented Jun 3, 2017

sagetrac-git mannequin commented Jun 12, 2017

sagetrac-git mannequin commented Jun 12, 2017

sagetrac-git mannequin commented Jun 23, 2017

sagetrac-git mannequin commented Jun 23, 2017

sagetrac-git mannequin commented Jun 23, 2017

sagetrac-git mannequin commented Jun 23, 2017

tscrim commented Jun 23, 2017

bsalisbury1 commented Jun 26, 2017

bsalisbury1 commented Jun 26, 2017

tscrim commented Jun 27, 2017

tscrim commented Jun 27, 2017

vbraun commented Jun 29, 2017

Allow IndexedGenerators to handle `names` #17039

Allow IndexedGenerators to handle `names` #17039