Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LatticePoset() arguments not forwarded to Poset() #20434

Open
jm58660 mannequin opened this issue Apr 13, 2016 · 14 comments
Open

LatticePoset() arguments not forwarded to Poset() #20434

jm58660 mannequin opened this issue Apr 13, 2016 · 14 comments

Comments

@jm58660
Copy link
Mannequin

jm58660 mannequin commented Apr 13, 2016

Docstring of LatticePoset() says that **options if forwarded to Poset(). It is not:

sage: P = Poset( ([0, 1,3,2, 10], [[0,1],[0,3],[0,2], [1,10],[3,10],[2,10]]), linear_extension=True)
sage: L = LatticePoset( ([0, 1,3,2, 10], [[0,1],[0,3],[0,2], [1,10],[3,10],[2,10]]), linear_extension=True)
sage: P.list()
[0, 1, 3, 2, 10]
sage: L.list()
[0, 1, 2, 3, 10]

CC: @kevindilks

Component: combinatorics

Keywords: poset

Author: Jori Mäntysalo

Branch/Commit: public/posets/forwarding_args_from_lattices-20434 @ 0fd62bc

Issue created by migration from https://trac.sagemath.org/ticket/20434

@jm58660 jm58660 mannequin added this to the sage-7.2 milestone Apr 13, 2016
@jm58660 jm58660 mannequin added c: combinatorics labels Apr 13, 2016
@jm58660
Copy link
Mannequin Author

jm58660 mannequin commented Apr 14, 2016

comment:1

This can be seen also with plain posets:

P1 = Poset({1:[2]}, linear_extension=False, facade=False)
P2 = Poset(P1)
Q1 = Poset({1:[2]}, linear_extension=True, facade=True)
Q2 = Poset(Q1)
print P1._with_linear_extension, P1._is_facade, "-->", P2._with_linear_extension, P2._is_facade
print Q1._with_linear_extension, Q1._is_facade, "-->", Q2._with_linear_extension, Q2._is_facade

outputs

False False --> False False
True True --> False True

i.e. linear_extension=True is not copied along the data and facade argument.

I suppose that this relates to #18776.

@jm58660
Copy link
Mannequin Author

jm58660 mannequin commented Apr 23, 2016

comment:2

Kevin, want to look at this?

As of my previous comment: Travis noticed at sage-devel that linear_extension=False is the default, whereas default for facade is None.

@jm58660
Copy link
Mannequin Author

jm58660 mannequin commented Oct 16, 2016

Author: Jori Mäntysalo

@jm58660
Copy link
Mannequin Author

jm58660 mannequin commented Oct 16, 2016

comment:3

#21666 will conflict, added as dependency.

@jm58660
Copy link
Mannequin Author

jm58660 mannequin commented Oct 16, 2016

Dependencies: #21666

@jm58660
Copy link
Mannequin Author

jm58660 mannequin commented Oct 16, 2016

Branch: u/jmantysalo/faster-DivisorLattice

@jm58660
Copy link
Mannequin Author

jm58660 mannequin commented Oct 16, 2016

Commit: 5ae54b3

@jm58660
Copy link
Mannequin Author

jm58660 mannequin commented Oct 16, 2016

comment:5

Duh. I did something really wrong with git and trac.

Waiting for 7.5 beta.


New commits:

8ee46bcModify DivisorLattice(n).
87bd385Parentheses from import.
5ae54b3Make LatticePoset(..., linear_extension=True) work.

@jm58660 jm58660 mannequin modified the milestones: sage-7.2, sage-7.5 Oct 16, 2016
@tscrim
Copy link
Collaborator

tscrim commented Oct 17, 2016

@tscrim
Copy link
Collaborator

tscrim commented Oct 17, 2016

comment:6

Fixing the branch issues with #21666.


New commits:

0fd62bcMake LatticePoset(..., linear_extension=True) work.

@tscrim
Copy link
Collaborator

tscrim commented Oct 17, 2016

Changed dependencies from #21666 to none

@tscrim
Copy link
Collaborator

tscrim commented Oct 17, 2016

Changed commit from 5ae54b3 to 0fd62bc

@fchapoton
Copy link
Contributor

Changed keywords from none to poset

@fchapoton fchapoton modified the milestones: sage-7.5, sage-9.3 Sep 18, 2020
@mkoeppe
Copy link
Member

mkoeppe commented Feb 13, 2021

comment:8

Setting new milestone based on a cursory review of ticket status, priority, and last modification date.

@mkoeppe mkoeppe modified the milestones: sage-9.3, sage-9.4 Feb 13, 2021
@mkoeppe mkoeppe modified the milestones: sage-9.4, sage-9.5 Jul 19, 2021
@mkoeppe mkoeppe modified the milestones: sage-9.5, sage-9.6 Dec 18, 2021
@mkoeppe mkoeppe modified the milestones: sage-9.6, sage-9.7 May 3, 2022
@mkoeppe mkoeppe modified the milestones: sage-9.7, sage-9.8 Sep 19, 2022
@mkoeppe mkoeppe removed this from the sage-9.8 milestone Jan 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants